A crashing problem by changing the leader on 1.11.8.

[SkyOne]

Hello,

BfW crashes on one of my add-on campaigns when the leader attacks any enemies on 1.11.8 (it is fine on 1.11.7). It only occurs after the leader changes. What I am doing for the leader change is to keep the same in the [side] tag, then replacing the leader with [if] + [have_unit] tags, and [store_unit] tags with "kill=yes" key for the original leader in the prestart event. And each of the changed leaders is replaced to the original leader on the next scenario.

reported by HD-Berlin here: - http://forums.wesnoth.org/viewtopic.php ... 94#p566694

A strange thing is that I am doing the same process on other two of add-on campaigns (one is not published yet), and both are fine on this matter. So what I need to know is that it is a bug or something has been changed on 1.11.8. I will appreciate if someone responds.


thanks
best regard

[mattsc]

Hi SkyOne,

The WML reason for this crash is that the overlay for Jil points to a file that does not exist. It doesn't exist in 1.11.7 either, but only causes problems in 1.11.8 because of a change to the source code during 1.11.7+dev (so that's the C++ reason for the crash). So if I see that correctly, that means that it has nothing to do with the unit being the side leader or anything, but only with it having an overlay that does not exist.

It also means that you can fix your campaign for 1.11.8 by changing the overlay file name. Of course, pointing to a non-existing overlay should not crash the game. We will fix that, but it won't take effect until 1.11.9.

[Iris]

Fixed in commit 0f1e3fab3ebe95a105b53961a9f93114bd6aec7c.

[SkyOne]

These are perfect responses.
I really appreciate how great this community is.
Thank you so much.