Non-Fatal Wounds: Maimed Edition
Moderator: Forum Moderators
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Non-Fatal Wounds: Maimed Edition
This is an extension of the Non-Fatal Wounds add-on by Octalot and Armagedonus that adds lasting injuries to your units whom nearly escaped death.
current injuries
injuries that can be toggled off
Injury healing system
Features I want to add
Last edited by CookieLord on August 22nd, 2022, 10:09 pm, edited 3 times in total.
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
Apparently the dependencies are set wrong and I don't know how to fix it.
- Atreides
- Posts: 1227
- Joined: March 30th, 2019, 10:38 pm
- Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off
Re: Non-Fatal Wounds: Maimed Edition
Nice idea! I kind of wished for something like this.
However I've tried it and while it shows messages for maiming when units (incl. enemy) are killed when I recall mine next scenario they don't seem to have any maimage. I lost a bowman in one scenario at the end and saw he was amnesiad but in the next when I recalled all my bowmen none had 0 xp.
However I've tried it and while it shows messages for maiming when units (incl. enemy) are killed when I recall mine next scenario they don't seem to have any maimage. I lost a bowman in one scenario at the end and saw he was amnesiad but in the next when I recalled all my bowmen none had 0 xp.
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
Do you have both Non-Fatal Wounds and my mod installed and activated?
The original Non-fatal wounds is needed to add your dead unit to the recall list.
The original Non-fatal wounds is needed to add your dead unit to the recall list.
Last edited by CookieLord on July 29th, 2022, 5:17 pm, edited 1 time in total.
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
The messages for enemy deaths is a side affect of allowing the player to see the messages when it is not their turn.
Eventually I would like to change that, but I felt knowing what happened to your own units was more important than the increased number of messages on screen.
Eventually I would like to change that, but I felt knowing what happened to your own units was more important than the increased number of messages on screen.
- Atreides
- Posts: 1227
- Joined: March 30th, 2019, 10:38 pm
- Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off
Re: Non-Fatal Wounds: Maimed Edition
Of course. The problem isn't that they're not on the recall list. They are. But they're not maimed. The original is working but the maiming isn't. I've updated to 1.03 also and tried it again and still none of the wounded units show any maiming in the next scenario.CookieLord wrote: ↑July 29th, 2022, 5:00 pm Do you have both Non-Fatal Wounds and my mod installed and activated?
The original Non-fatal wounds is needed to add your dead unit to the recall list.
Oh and don't worry about that the msg appears on enemy units, I think that's just fine. I was merely amused to think that the ai can't recall those maimees. ; ) In fact it's quite a bit of fun to see the enemy being maimed. Muahaha! <evil grin>
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
My guess is that wesnoth is loading Non-Fatal before it loads Maimed Edition, causing it to copy units to the recall list before the maimed effects are applied.
Assuming this is the problem ive updated the add-on to force the load order, but this means that Non-Fatal needs to be disabled (but still installed).
Assuming this is the problem ive updated the add-on to force the load order, but this means that Non-Fatal needs to be disabled (but still installed).
- Atreides
- Posts: 1227
- Joined: March 30th, 2019, 10:38 pm
- Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off
Re: Non-Fatal Wounds: Maimed Edition
Hi, I had a peek into your add-on's code and it appears you are using traits for the maiming. Alas, as I found out the hard way, you can't add traits to units. I believe you could do it using abilities. Sorry about the bad news. : (CookieLord wrote: ↑August 1st, 2022, 5:57 pm My guess is that wesnoth is loading Non-Fatal before it loads Maimed Edition, causing it to copy units to the recall list before the maimed effects are applied.
Assuming this is the problem ive updated the add-on to force the load order, but this means that Non-Fatal needs to be disabled (but still installed).
-
- Posts: 564
- Joined: August 4th, 2019, 5:27 pm
- Contact:
Re: Non-Fatal Wounds: Maimed Edition
Not true, you can add traits. In LotI GEARED trait is added/removed when you equip an item/unequip all items. In World Conquest the "trained" trait is randomly added for trained units
Co-founder and current maintainer of IsarFoundation, Afterlife Rated and overall Wesnoth Autohost Project
Developer and maintainer of my fork of World Conquest, Invincibles Conquest II
Developer and maintainer of my fork of World Conquest, Invincibles Conquest II
- Atreides
- Posts: 1227
- Joined: March 30th, 2019, 10:38 pm
- Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off
Re: Non-Fatal Wounds: Maimed Edition
Interesting, I just looked into WC and it appears to use lua to do it. Can it also be done via wml as Cookielord is trying to? (I don't have Lotl so I couldn't see how it did it)dwarftough wrote: ↑August 2nd, 2022, 12:41 amNot true, you can add traits. In LotI GEARED trait is added/removed when you equip an item/unequip all items. In World Conquest the "trained" trait is randomly added for trained units
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
in my own testing it was working. A quick way to test if the traits are working is to change the last_breath event to a recruit event in the randomizer file.
health modifications and the dead trait wont trigger until the following scenario.
health modifications and the dead trait wont trigger until the following scenario.
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
Also originally I was going to use objects, but i wanted there to be a way for players to see what is modifying their units at a glance.
the only way i can think of for objects to display themselves would be a custom overlay for each wound.
the only way i can think of for objects to display themselves would be a custom overlay for each wound.
-
- Posts: 564
- Joined: August 4th, 2019, 5:27 pm
- Contact:
Re: Non-Fatal Wounds: Maimed Edition
This code from Hejnevar's PYR adds a trait to 7 moves leaders with pure wml
Code: Select all
[event]
name = prestart
[modify_unit]
[filter]
canrecruit = yes
[filter_wml]
max_moves = 7
[/filter_wml]
[not]
trait = lazy
[/not]
[/filter]
{TRAIT_LAZY}
[effect]
apply_to = hitpoints
heal_full = yes
[/effect]
[/modify_unit]
[/event]
Co-founder and current maintainer of IsarFoundation, Afterlife Rated and overall Wesnoth Autohost Project
Developer and maintainer of my fork of World Conquest, Invincibles Conquest II
Developer and maintainer of my fork of World Conquest, Invincibles Conquest II
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
Finished the base versions of the injuries I was planning on adding.
Next I will probably swap the traits to objects using dummy specials to inform the player of the injury (the remove_trait tag wasn't working for me).
edited original post to reflect current add-on version
Next I will probably swap the traits to objects using dummy specials to inform the player of the injury (the remove_trait tag wasn't working for me).
edited original post to reflect current add-on version
-
- Posts: 19
- Joined: June 22nd, 2022, 8:57 pm
Re: Non-Fatal Wounds: Maimed Edition
v1.3.0
-changed most traits to objects with specials to allow removing them (left dead, undead_ghost, undead_corpse unchanged)
-changed undead_corpse image change to an overlay of a soulless
-added the sick wound to the random wound table
-changed most traits to objects with specials to allow removing them (left dead, undead_ghost, undead_corpse unchanged)
-changed undead_corpse image change to an overlay of a soulless
-added the sick wound to the random wound table