Infinity loop during lvluping.

[ChaosRider]

Anyone know why game is doing infinity loop during lvluping unit with advance unit macro (for example advancing inferno drake to armageddon drake, same with lvluping lich to ancient lich)? Below code from my addon called "More units forms" (which was working fine on Wesnoth v1.10):

Spoiler:

Code: Select all

#define Able_Armageddon_Drake
	[event]
		name=advance
		first_time_only=no
		id=new_units_forms_019
		[filter]
			type=Inferno Drake
			x,y=$x1,$y1
		[/filter]
		{VARIABLE extra_unit_advance_inferno_drake yes}
	[/event]
	[event]
		name=post advance
		first_time_only=no
		id=new_units_forms_020
		[if]
			[variable]
				name=extra_unit_advance_inferno_drake
				equals=yes
			[/variable]
			[then]
				{ADVANCE_UNIT x,y=$x1,$y1 "Armageddon Drake"}
				{CLEAR_VARIABLE extra_unit_advance_inferno_drake}
				{CLEAR_VARIABLE unit.underlying_id,unit.id} 
			[/then]
		[/if]
	[/event]
#enddef

Spoiler:

Code: Select all

#define ADVANCE_UNIT FILTER ID_STRING
    # Advances all units matching the filter to ID_STRING or if missing, their normal advancement
    #
    # Example to advance all spearmen to a cavalrymen:
    #! {ADVANCE_UNIT type=Spearman Cavalryman}
    # Example to advance your leader normally:
    #! {ADVANCE_UNIT canrecruit,side=yes,1 ""}

    [modify_unit]
        [filter]
            {FILTER}
        [/filter]
        type={ID_STRING}
    [/modify_unit]
#enddef

[Ravana]

Code: Select all

    # Example to advance your leader normally:
    #! {ADVANCE_UNIT canrecruit,side=yes,1 ""}

That does not look correct. There is no reason why [modify_unit] should treat empty type as advancement.

[ChaosRider]

Code: Select all

    # Example to advance your leader normally:
    #! {ADVANCE_UNIT canrecruit,side=yes,1 ""}

That does not look correct. There is no reason why [modify_unit] should treat empty type as advancement.

Where in code Ive empty type ?

[Atreides]

Code: Select all

    # Example to advance your leader normally:
    #! {ADVANCE_UNIT canrecruit,side=yes,1 ""}

That does not look correct. There is no reason why [modify_unit] should treat empty type as advancement.

Where in code Ive empty type :P?

Not familiar with that macro but it's very likely the "" at the end is supposed to take a unit type as a parameter.

[ChaosRider]

This code was taken from core macros in Wesnoth v1.18.3.

Code: Select all

Example to advance your leader normally:
    #! {ADVANCE_UNIT canrecruit,side=yes,1 ""}

It looks wrong to me but its not why infinity loop happens after unit advance.

[Ravana]

I found that it is custom logic in modify_unit.lua, added to wiki.

[lhybrideur]

On thing that happened in my add-on was that I was using a [modify_unit] in a pre_advance event. However, [modify_unit] is refreshing the unit, so was triggering a new pre_advance event thus looping.
You might have a similar problem.
Now I use [store_unit], manually modify, then [unstore_unit] to prevent that.

[ChaosRider]

On thing that happened in my add-on was that I was using a [modify_unit] in a pre_advance event. However, [modify_unit] is refreshing the unit, so was triggering a new pre_advance event thus looping.
You might have a similar problem.
Now I use [store_unit], manually modify, then [unstore_unit] to prevent that.

Once I reach 5000 different units in WOTG I will try rewrite code to use store unit and transform code.