vghetto port project

[vghetto]

It'd be nice if wmllint could do this automatically for us

There are many things I wish wmllint would do.
The one that irks me the most is changing [option] message= into [option] label=.
I don't have a good way for changing those with sed. I do them by hand.

Edit: Oh btw, wmllint isn't changing Ggf into Gg^Efm

[octalot]

I don't know why the core {FOREACH} macros aren't just changed from a [while] to a [for] :/

It was implemented that way for a while and then reverted back to being a [while] in 8bbe4189edd0c11f57c77e30a2c012af0ca30319. I don't know for sure, but I'd guess someone's UMC was incrementing or decrementing the index variable inside the loop.

[Konrad2]

The Fall of Wesnoth works and is beatable. I've the typos I found here.

Btw, I'm pretty sure that 'End of the Legion' is only one scenario.

[egallager]

It'd be nice if wmllint could do this automatically for us

There are many things I wish wmllint would do.
The one that irks me the most is changing [option] message= into [option] label=.
I don't have a good way for changing those with sed. I do them by hand.

Edit: Oh btw, wmllint isn't changing Ggf into Gg^Efm

I feel like opening some bugs against wmllint; should we have a giant one for everything noticed in this thread, or split out separate ones for each individual issue?

[vghetto]

Btw, I'm pretty sure that 'End of the Legion' is only one scenario.

Should I port it or drop it in your opinion?

I feel like opening some bugs against wmllint; should we have a giant one for everything noticed in this thread, or split out separate ones for each individual issue?

What's more convenient for Elvish_Hunter? Maybe he can let us know.

--------

I'm currently not porting anything and have gone back to updating and testing Wesband myself.
After that, I'll do an update round on what has been published under this project, both my work and Argesilao2's.

[Konrad2]

Should I port it or drop it in your opinion?

If you want to port it, drop its priority to the lowest.

[Atreides]

Edit: Oh btw, wmllint isn't changing Ggf into Gg^Efm

Ironically I just found out that wmllint does change that.... but only after a terrain=

And to boot it does it buggily by deleting the comma in between meaning I had to fix wmllint's fix!

I'm glad there is a wmllint and don't want to look a gift horse in the mouth but heh, it could be improved.

[vghetto]

Edit: Oh btw, wmllint isn't changing Ggf into Gg^Efm

Ironically I just found out that wmllint does change that.... but only after a terrain=
And to boot it does it buggily by deleting the comma in between meaning I had to fix wmllint's fix!
I'm glad there is a wmllint and don't want to look a gift horse in the mouth but heh, it could be improved.

hmm, there might more than one bug with this.

Both Ggf and Qv have a comma inside the quote, and it's replacing the Ggf with mushrooms instead of flowers.
^Efm is flowers right?

Code: Select all

# Changes meant to be done on maps and .cfg lines.
mapchanges = (
    ("^Voha", "^Voa"),
    ("^Voh",  "^Vo"),
    ("^Vhms", "^Vhha"),
    ("^Vhm",  "^Vhh"),
    ("^Vcha", "^Vca"),
    ("^Vch",  "^Vc"),
    ("^Vcm",  "^Vc"),
    ("Ggf,",  "Gg^Emf"),
    ("Qv,",  "Mv"),
    )

From wesnoth 1.10.7

Code: Select all

#### This one is replaced by an overlay
[terrain_type]
    symbol_image=grass/flowers
    id=grassland_flowers
    name= "Deprecated. Use Flower Overlay"
    string=Ggf
    aliasof=Gt
    editor_group=flat
    hidden=yes
[/terrain_type]

[Argesilao2]

Hi! I just ported Girl unDead in the 1.16 addons server.

The campaign is complete and seems to be fully operational, but update it was much much much easier than testing it.
The objectives are sometimes confusing, especially the first scenario, and about the last scenario I have come to suspect that the original author, tapaboy, has disappeared because he was hit by the curses that those who played that scenario cast against him.
It isn't difficult, is ... well, it's necessary to play it to understand what I mean.

In addition to this, events happen, here and there, for which there are no logical explanations, they just happen.

All these trifles aside, in my opinion it's a nice campaign, with an original story and some really fun scenarios to play and well balanced scenarios.

Surely it deserves to have a maintainer to take care of it, but don't ask me. I care too much about my mental health.

[vghetto]

Hi! I just ported Girl unDead in the 1.16 addons server.

Thanks! I updated the list.

[Descacharrado]

I could not find the old terrain codes to port 1.2 campaigns to newer versions... here it says:

"Note: the old (1.2) terrain system is no longer documented here. If you have 1.2 maps you will need to convert them using wmllint."
but the wmllint version 1.4 is unsupported by the GUI.pyw (and I do not know how to run the scripts without using the GUI). Edit: nvm I found out it is as easy as doing this:
py "C:\(PATH TO WESNOTH)\wesnoth\data\tools\wmllint-1.4" (OPTIONS) "C:\(PATH TO WESNOTH USER FILES)\Wesnoth1.16\data\add-ons\(Addon namepath)"

Edit: I'll leave the post anyways in case anyone finds it useful

So here goes an image for manual translation of old terrain codes (new terrain codes can be seen here):

s - deep water
c - shallow water
w - swamp
k - ford
\,|,/ - bridge (directions)
d - sand
I (capital letter i) - desert sand
R - cobbled road
E - road
r - dirt
g - grassland
G - semi-dry grassland (savana grassland)
v - village
Z - water village
Y - Swamp village
t - elvish village
B - desert village 1
U - desert village 2
P - Oasis
L - goblin villages
A,a,b - Hill villages
V - snow village
e - snow elvish village
D,p - cave villages
S - snow
i - ice
h - regular hills
J - desert hills
H - Snowy hills
[ - cave hills
m - regular mountain
f - forest
M - Sandy mountains
] - mushrooms
T - tropical forest
F - Snowy forest
u - cave floor
' - lit cave floor
& (ampersand) - Impassable mountains
W - Cave walls
X - Chasm
l (lowercase L) - lava chasm
? - great tree
C - human castle
n - encampment
o - dwarvish castle
K - human keep
N - castle ruins
Q - sunken ruins
q - swampy ruins

[Atreides]

Excellent, thank you for the post. I've not yet tried any 1.2 maps but I have come across terrain liked with those codes and now I understand them.

Also thanks to vghetto for the post about the bugs in wmllint. Yikes! That had me scrambling to find any errors it might have introduced but all I found was one in War of Legends whom I notified immediately.
N.B. turns out wmllint is a text file and can be edited, so anyone can repair the bug in it themselves. Removing the comma inside the "'s for the last two terrains fixed it (tested). It should now also convert maps with those (untested).

P.S. Merry Christmas, Frohe Weihnachten!

[Descacharrado]

Ported "A Walk in the Woods", disregarded "A Princes Tale" for being poor quality.

[vghetto]

Ported "A Walk in the Woods", disregarded "A Princes Tale" for being poor quality.

Fantastic. I updated the list.
Did you use 16 xs for the password?
The thread in the _server.pbl points to here. Don't worry about it, I'll update it when I do my rounds
Thank you for the port!

Edit: What's A Princes Tale? I don't see it on my list.

[Lord-Knightmare]

Add_s_Army
An_Innocent_Man
Anthalia
Between_the_Worlds
Birth_of_Sorcery
BorderWars
Class_Changing_AMLA_Elves
Comrades_in_Arms
Divided_Battle
Dungeon_Creeper_the_Lich
Elves_Banding_For_War
End_of_the_Legion
Fate_of_a_Princess
Fingerbone_Of_Destiny
Follow_The_Arrow
Hunter
Hunters_of_the_East
IIIO_Test_field
Langrisser_Sample_Campaign
Liberating_Alduin
Lisar_and_the_AMLA_Elves
Lord_Of_The_South
Love_To_Death
Martian_Invasion_1594
Missing_Scepter
Mutiny_in_1626
Mystery_in_1596
Northern_Forces
Offensive
PC_Campaign
Rally_For_Roanic
Rebellion_in_the_North
Red_Winter
Revenge_of_the_Rogue
Roar_of_the_Woses
Roboke
Royalties_Forgotten
Silly_AI_Example
Sleuth_Sisters
Stormtrooper
Tale_of_Alan
The_Attack_Of_The_Western_Cavalry
The_Blind_Sentinel
The_Desolation_Of_Karlag
The_Fellowship_of_the_Clay
The_Hidden_Kingdom
The_Invasion
The_Stone_Of_The_North
Thrugbad_The_Good

This is the current list and I shall see if we can cut them down in some way.
Campaigns by Makepeace McEvoy can be ported as they seem to be done (by description). Needs to be checked if they are actually finished...

Campaigns by WhiteWolf should be left to the author as he is active on the forums and might be back after his thesis submission and presentation.

Can be dropped:

• Anthalia - Heavy dependency and too much effort to port
• Birth of Sorcery - description says only 25% is done. Premise is good/decent. I don't want incomplete abandoned works
• Borderwars - Not a campaign/SP scenario. MP scenario
• Divided_Battle - MP Scenaro pack. Sadly uploaded as type scenario.
• End_of_the_Legion - incomplete, abandoned and part of a story line which does not exist anymore.
• Fate_of_a_Princess - Being ported by someone as far as I can recall. No clue on the progress though. I will keep it on the list.
• Follow_The_Arrow - MP scenario
• IIIO_Test_field - Test thing or something
• Lord_Of_The_South - there is no addon of this name in 1.12/1.10/1.8/1.6
• Offensive - MP scenario
• PC_Campaign - does not exist?
• Royalties_Forgotten - incomplete and stated as abandoned.
• Silly_AI_Example - scenario/outdated lua
• Tale_of_Alan - abandoned and incomplete
• The_Invasion - Stub of a campaign and not worth it.

Updated List:

Add_s_Army
An_Innocent_Man
Between_the_Worlds
Class_Changing_AMLA_Elves
Comrades_in_Arms
Dungeon_Creeper_the_Lich
Elves_Banding_For_War
Fate_of_a_Princess
Hunter
Hunters_of_the_East
Langrisser_Sample_Campaign
Liberating_Alduin
Lisar_and_the_AMLA_Elves
Love_To_Death
Martian_Invasion_1594
Missing_Scepter
Mutiny_in_1626
Mystery_in_1596
Northern_Forces
Rally_For_Roanic
Rebellion_in_the_North
Red_Winter
Revenge_of_the_Rogue
Roar_of_the_Woses
Roboke
Sleuth_Sisters
Stormtrooper
The_Fellowship_of_the_Clay
The_Hidden_Kingdom
Thrugbad_The_Good

I hope my sanity checking will help the project progress a bit by cutting down on things not worth it.