question about out of sync errors

[myav]

What is wrong in this code?

I have tested this many times.

When 1 player plays and one game side is under control of the "AI" - all works without any errors.

But when 2 players + 1 "AI" plays together, this code works without errors, but the second player always got the next out of sync error: unfound location for source of attack, when "AI" does 4-5 his turn and try to attack any enemy unit.

Code: Select all

[event]
    name=recruit
    first_time_only=no			  
        [store_side]
            side=$side_number
            variable=storedside			  
	[/store_side]			  
    [if]
        [variable]
            name=storedside.controller
            contains="ai"
        [/variable]
    [then]	
	 [object]
	     [filter]
             #without this filter - the same error
	         x,y=$x1,$y1
	     [/filter]
	  silent=yes				  
              [effect]
                  #any effect
              [/effect]		
	  [/object]
    [/then]
    [/if]	
#without this clear - the same error
{CLEAR_VARIABLE storedside}
[/event] 

without this code, second player not receive out of sync, it means that problem is there.

[Anonymissimus]

The controller attribute of sides is ambiguous.
E.g. if you have a mp game on the server with 2 human players and 1 ai, for player 1's (human, host) BfW instance:
side[1].controller -> "human"
side[2].controller -> "network"
side[3].controller -> "ai"

But for player 2's (human but no host) BfW instance:
side[1].controller -> "network"
side[2].controller -> "human"
side[3].controller -> "network"

And side 3 is a true ai.
wml events are executed simultaneously on each of the clients (instances) independently. Thus, if you base in your wml a decision on the value of side.controller, these wml events can get executed differently on the clients => OOS.

EDIT
Yes, it's currently actually this way. It can be tested by starting wesnoth with --debug and using the command line
lua wesnoth.message(wesnoth.sides[3].controller)
(and similar) since this code is then only executed on the client which types it. There is apparently supposed to be a value "NETWORK_AI" so I guess it may be a bug that side[3].controller doesn't shop up as network_ai for player 2 in the above (which would also allow you to detect whether side 3 is ai for the networked clients too).

[myav]

Can you offer any variant how to replace this check with similar sense but without oos in the network ?

Code: Select all

[if]
        [variable]
            name=storedside.controller
            contains="ai"
        [/variable]
[then]

[Anonymissimus]

Can you offer any variant how to replace this check with similar sense but without oos in the network ?

Code: Select all

[if]
        [variable]
            name=storedside.controller
            contains="ai"
        [/variable]
[then]

If what I guess is a bug would get fixed I guess you could add to that condition

Code: Select all

[or]
    [variable]
        name=storedside.controller
        equals=network_ai
#...

and get the same decision on all of the clients then. But since currently on non-hosts an ai can't be distinguished from a human: No.
If you know for a side that it has allow_player=false you could exclude the case that it's a human.

[myav]

Code: Select all

[or]
    [variable]
        name=storedside.controller
        equals=network_ai

It hasn't helped, I have received oos again, because for second player, AI controller is not "network_ai", but: "network" (I have checked this with $variable| in the [message])


Why this code not works too ?

Spoiler:

Code: Select all

#define CHECK_AI
{VARIABLE temp_check 0}
{VARIABLE temp_side $side_number}			  
[if]
    [variable]
        name=temp_side
        equals=1
    [/variable]	
[and]
    [variable]
        name=ai1
        equals=1
    [/variable]
[/and]	
[then]
{VARIABLE temp_check 1}
[/then]
[/if]
[if]
    [variable]
        name=temp_side
        equals=2
    [/variable]	
[and]
    [variable]
        name=ai2
        equals=1
    [/variable]
[/and]	
[then]
{VARIABLE temp_check 1}
[/then]
[/if]
[if]
    [variable]
        name=side_number
        equals=3
    [/variable]	
[and]
    [variable]
        name=ai3
        equals=1
    [/variable]
[/and]	
[then]
{VARIABLE temp_check 1}
[/then]
[/if]
			  
[if]
    [variable]
        name=temp_check
        equals=1
    [/variable]		
[then]
{CLEAR_VARIABLE temp_side}
{CLEAR_VARIABLE temp_check}
#enddef

[event]
    name=side turn
    first_time_only=no		
	{VARIABLE ai1 0}
	{VARIABLE ai2 0}
	{VARIABLE ai3 0}
[/event]
   
[event]
    name=ai turn
    first_time_only=no	
{VARIABLE temp_side $side_number}
      [if]
          [variable]
              name=temp_side
              equals=1
          [/variable]
      [then]
	      {VARIABLE ai1 1}
      [/then]
      [/if]
      [if]
          [variable]
              name=temp_side
              equals=2
          [/variable]
      [then]
	      {VARIABLE ai2 1}
      [/then]
      [/if]	  
      [if]
          [variable]
              name=temp_side
              equals=3
          [/variable]
      [then]
	      {VARIABLE ai3 1}
      [/then]
      [/if]	
{CLEAR_VARIABLE temp_side}  
[/event]	

[event]
name=recruit
first_time_only=no			  
    {CHECK_AI}	
    [object]
        silent=yes				  
        [effect]
            # any effect
        [/effect]
    [/object]
[/then]
[/if]
[/event]

[Anonymissimus]

Code: Select all

[or]
    [variable]
        name=storedside.controller
        equals=network_ai

It hasn't helped, I have received oos again, because for second player, AI controller is not "network_ai", but: "network" (I have checked this with $variable| in the [message])

Of course, due to the bug.

Did you understand my previous post ?
BfW does not even know about which side is an ai, you cannot detect this in wml.
Anyway, the usage of an ai turn event is a mistake. It's neither synced nor does it fire in replays: http://wiki.wesnoth.org/EventWML

[SlowThinker]

E.g. if you have a mp game on the server with 2 human players and 1 ai, for player 1's (human, host) BfW instance:
side[1].controller -> "human"
side[2].controller -> "network"
side[3].controller -> "ai"

If the hosting player controls also side 4 then
side[4].controller -> "human"

But what happens if side 5 is another local player on same computer? Is he detected as "human" too? If so then WML can't reliably detect sides controlled by a player.

-----------------------
edit: a related info is here: A way how to limit [scroll_to] to a side?

[Anonymissimus]

But what happens if side 5 is another local player on same computer? Is he detected as "human" too? If so then WML can't reliably detect sides controlled by a player.

I don't understand that.
What do you think the controller should be ? Are the 2 persons using the same BfW instance ?
And if they are, how could BfW possibly know that it is not the same person who makes the actions for all 3 sides ?

[SlowThinker]

I tempted to think the option 'local player' in the lobby informed BfW that the hotseat was used. You think there is no real difference between 'SlowThinker' and 'local player'?

So you think every side on the same BfW instance is "human", even if they are in different teams?

[Anonymissimus]

I suggest you do what I'm describing above in BfW 1.9.8 to know what the controllers are in certain various game setups so you can answer your question yourself:

It can be tested by starting wesnoth with --debug and using the command line
lua wesnoth.message(wesnoth.sides[3].controller)
(and similar) since this code is then only executed on the client which types it. There is apparently supposed to be a value "NETWORK_AI" so I guess it may be a bug that side[3].controller doesn't shop up as network_ai for player 2 in the above (which would also allow you to detect whether side 3 is ai for the networked clients too).

If you know how to do that it's very good for muplitplayer development in general. You can pass command line parameters in windows (for instance) by using a link to the program executable and adding the parameter in the target line in the link's properties.

[Pentarctagon]

Moved to the correct forum.