the KNOCKBACK ability

[fog_of_gold]

Yes, of course. So @Dixie, use [/specials] and [/attack] instead of [/abilities] and [+attack] and [+specials] instead of [+abilities].
@zookeeper:
It will work for weapon specials.(I even tested it (not this specials itself) with the new version) Why shouldn't it?

[Dixie]

Well I'll try it out. There are three things I still don't understand about it though:

1) You suggest two tags. Should I put both? Or just the [+special] one? Or what?

2) I suppose it is intentionnal, but what is the logic of putting the [/special] (or attack or ability, whichever) before the [+special]? Shouldn't the slash ("/") tag be used for closing, thus coming after the plus ("+") tag?

3) Why would I in particular need those tags? I've never any specials using those, be it in mainline or other user-made eras. If it makes it work though, why not? But I just don't get it.

[fog_of_gold]

[...]1) You suggest two tags. Should I put both? Or just the [+special] one? Or what?

That aren't really tags. You need both:

Spoiler:

Code: Select all

[...]
[/specials]
[/attack]
[...]
[+attack]
[+specials]
[...]

2) I suppose it is intentionnal, but what is the logic of putting the [/special] (or attack or ability, whichever) before the [+special]? Shouldn't the slash ("/") tag be used for closing, thus coming after the plus ("+") tag?

Like I said above, it isn't really a tag, I just called it tag. With [+xx], you can add something to last tag of this type. The code, if you add the pieces of macros and files together, may look like following for the [unit_type] tag:

Spoiler:

Code: Select all

[unit_type]
	#a unit here
	[attack]
		#attack's stuff here
		[specials]
			[knockback]		#this ability won't do anything expect just showing it's there
				id=knockback
				name=_ "knockback"
			[/knockback]
		[/specials]
	[/attack]
	[event]
		#all these event's stuff here
	[/event]
	[+attack]
		[+specials]
			{WEAPON_SPECIAL_POISON}
		[/specials]
	[/attack]
[/unit_type]

And the game will change it to this:

Spoiler:

Code: Select all

[unit_type]
	#a unit here
	[attack]
		#attack's stuff here
		[specials]
			[knockback]		#this ability won't do anything expect just showing it's there
				id=knockback
				name=_ "knockback"
			[/knockback]
			{WEAPON_SPECIAL_POISON}
		[/specials]
	[/attack]
	[event]
		#all these event's stuff here
	[/event]
[/unit_type]

And because these events are in a [unit_type] tag now, they'll be written into the game, too.

I hope you understand now. If not, feel free to ask. Also, look in the mainline ability "feeding". This ability have got this method, too.

3) Why would I in particular need those tags? I've never any specials using those, be it in mainline or other user-made eras. If it makes it work though, why not? But I just don't get it.

Unfortunatly, the game will only notice the events in [scenario], [unit_type] and maybe some less others. Any event tag in another tag will be ignored, even if this tag is also in one of the tags above.
Like above, I hope you understand. If not, feel free to ask.

[Dixie]

Ok, I get that about event tag working only in specific places, and bout the "+" "tags" not really being tags.

I wonder though. In your last post, in the "spoilers", you just did the opposite of what you said just above.

First Spoiler:

[/specials]
[/attack]
[...]
[+attack]
[+specials]

Second and Third spoiler:

[+attack]
[+specials]
{WEAPON_SPECIAL_POISON}
[/specials]
[/attack]

Was that an error?

Also, I notice the feeding ability seems to put the "+" tag before the "/", unless I'm mistaken? See:

Spoiler:

Code: Select all

# wmllint: unbalanced-on
#define ABILITY_FEEDING
    # Canned definition of the Feeding ability to be included in an
    # [abilities] clause.  Note: this is deliberately unbalanced WML,
    # in order to close the abilities clause then insert the event
    # then reopen the abilities clause.
    [dummy]
        id=feeding
        name= _ "feeding"
        female_name= _ "female^feeding"
        description=_ "Feeding:
This unit gains 1 hitpoint added to its maximum whenever it kills a living unit."
    [/dummy] # a hack to please wmlxgettext (using a bug in wmlxgettext!): dummy tag start: [abilities]
[/abilities]
[event]
    name=die
    first_time_only=no

    [filter]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
    [/filter]

    [filter_second]
        ability=feeding
    [/filter_second]

    [unstore_unit]
        variable=second_unit
        {COLOR_HEAL}
        text= _ "+1 max HP"
        find_vacant=no
    [/unstore_unit]

    [object]
        silent=yes
        duration=forever

        [filter]
            x,y=$x2,$y2
        [/filter]

        [effect]
            apply_to=hitpoints
            increase_total=1
            increase=1
        [/effect]
    [/object]
[/event]
[+abilities] # a hack to please wmlxgettext (using a bug in wmlxgettext!): dummy tag end: [/abilities]
#enddef
# wmllint: unbalanced-off

And jsut to make sure, you are telling me to include these "tags" in the ability.cfg file, not in every unit file, right? So I can link it like any other weapon special macro afterwards?

Anyway, I'll try it out and tell you how it goes. Thanks a lot!

[fog_of_gold]

[...]Was that an error?

The ability macro looks in this way, not in the way you thought:

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_WITH_EVENTS
	[knockback]      #this ability won't do anything expect just showing it's there
		id=knockback
		name=_ "knockback"
	[/knockback]
	[/specials]
		[/attack]
			[event]
				#all these event's stuff here
			[/event]
		[+attack]
	[+specials]
#enddef

and the file includes the macro looks like this:

Spoiler:

Code: Select all

[unit_type]
   #a unit here
   [attack]
      #attack's stuff here
      [specials]
         {WEAPON_SPECIAL_WITH_EVENTS}
         {WEAPON_SPECIAL_POISON}
      [/specials]
   [/attack]
[/unit_type]

So everything after [+specials] is already the next special.

Also, I notice the feeding ability seems to put the "+" tag before the "/", unless I'm mistaken? See:

Spoiler:

Code: Select all

# wmllint: unbalanced-on
#define ABILITY_FEEDING
    # Canned definition of the Feeding ability to be included in an
    # [abilities] clause.  Note: this is deliberately unbalanced WML,
    # in order to close the abilities clause then insert the event
    # then reopen the abilities clause.
    [dummy]
        id=feeding
        name= _ "feeding"
        female_name= _ "female^feeding"
        description=_ "Feeding:
This unit gains 1 hitpoint added to its maximum whenever it kills a living unit."
    [/dummy] # a hack to please wmlxgettext (using a bug in wmlxgettext!): dummy tag start: [abilities]
[/abilities]
[event]
    name=die
    first_time_only=no

    [filter]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
    [/filter]

    [filter_second]
        ability=feeding
    [/filter_second]

    [unstore_unit]
        variable=second_unit
        {COLOR_HEAL}
        text= _ "+1 max HP"
        find_vacant=no
    [/unstore_unit]

    [object]
        silent=yes
        duration=forever

        [filter]
            x,y=$x2,$y2
        [/filter]

        [effect]
            apply_to=hitpoints
            increase_total=1
            increase=1
        [/effect]
    [/object]
[/event]
[+abilities] # a hack to please wmlxgettext (using a bug in wmlxgettext!): dummy tag end: [/abilities]
#enddef
# wmllint: unbalanced-off

The [abilities] tag is still within a comment. The same thing with [/abilities]. So ignore these two commands. If I remove every comment, it would look this way:

Spoiler:

Code: Select all

#define ABILITY_FEEDING
    [dummy]
        id=feeding
        name= _ "feeding"
        female_name= _ "female^feeding"
        description=_ "Feeding:
This unit gains 1 hitpoint added to its maximum whenever it kills a living unit."
    [/dummy]
[/abilities]
[event]
    name=die
    first_time_only=no

    [filter]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
    [/filter]

    [filter_second]
        ability=feeding
    [/filter_second]

    [unstore_unit]
        variable=second_unit
        {COLOR_HEAL}
        text= _ "+1 max HP"
        find_vacant=no
    [/unstore_unit]

    [object]
        silent=yes
        duration=forever

        [filter]
            x,y=$x2,$y2
        [/filter]

        [effect]
            apply_to=hitpoints
            increase_total=1
            increase=1
        [/effect]
    [/object]
[/event]
[+abilities]
#enddef

And jsut to make sure, you are telling me to include these "tags" in the ability.cfg file, not in every unit file, right? So I can link it like any other weapon special macro afterwards?

Yes you can, just like it's a usually weapon special. Just make sure, that you can't use them in any [effect] (a way to include abilities and weapon specials manually within [event] or [advancement]), just in the [units]-[unit_type]-[abilities] tag.

[edited to correct some mistakes]

[Dixie]

Victory! The knockback ability now works! This was merely a WML battle, not the war, though, as I've got some more issues to fix. Let's just adress the first (and probably simplest) one in this post. I'll work on the second afterwards.

Here goes: Knockback works... but only on offense, as the original description said. There is no "active_on=" line anywhere, though. I tried adding such a line and leaving the space after the "=" blank, as to imply it's active both on offense and defense (which is what I actually want). That's what the wiki says at least. I placed it just under the [event] tag, along with the "first_time_only=no" line, which seemed like a suitable place to me, since the wiki doesn't precise where it should go. Well, anyway, it still just works on defense. Did I forget something? Is there a line or command the wiki omits that I should be aware of? Are my ambitions impossible?

Here's the code:

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_KNOCKBACK
       [knockback]
           id=knockback
           name= _ "knockback"
           description=_ "Knockback:
   When a unit is hit with a knockback attack, it is immediately pushed back one hex away from the attacker. Units cannot be knocked back into an occupied hex, out of villages or onto terrain they normally could not move to."
       [/knockback]
       [/specials]
       [/attack]

[event]
       name=attacker hits
       first_time_only=no
       active_on=
   
       [filter_attack]
           special=knockback
       [/filter_attack]
   
       [filter_second]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter_second]
   
       [if]
           [variable]
               name=second_unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x1,$y1
                       [filter_adjacent]
                           x,y=$x2,$y2
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE knockback_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x1,$y1
                               [filter_adjacent]
                                   x,y=$x2,$y2
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE knockback_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x1,$y1
                                       [filter_adjacent]
                                           x,y=$x2,$y2
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE knockback_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x1,$y1
                                               [filter_adjacent]
                                                   x,y=$x2,$y2
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE knockback_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x1,$y1
                                                       [filter_adjacent]
                                                           x,y=$x2,$y2
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE knockback_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x1,$y1
                                                               [filter_adjacent]
                                                                   x,y=$x2,$y2
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE knockback_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x2,$y2
                       adjacent=-$knockback_direction
                   [/filter_adjacent_location]
   
                   variable=knockback_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=knockback_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x2,$y2
                           [/filter]
   
                           x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=fist.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$knockback_target_hex.x,$knockback_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=knockbacked
                               [/store_unit]
   
                               {VARIABLE_OP knockbacked.experience add $unit.level}
   
                               [unstore_unit]
                                   variable=knockbacked
                                   text= _ "knocked back!"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE knockbacked}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE knockback_direction,knockback_target_hex}
           [/then]
       [/if]
   [/event]
	[+attack]
	[+specials]
#enddef

Thanks a lot, people!

[fog_of_gold]

Well, unfortunatly, it isn't that much easy. If you take a look at EventWML, you'll see, that it'll only be fired, if the unit hits is the attacker. As far as I know, just adding 'defender hits' with a comma after the 'name' key should make it work. If not we'll have to copy the whole event code and change attacker hits to defender hits. Hopefully we haven't to. So to make the code work in the way you want to have it, change the part of the code into this:

Code: Select all

[...]
[event]
        name=attacker hits,defender hits
        first_time_only=no
[...]

I just looked at your 'retreat' specials, and at least one problem was, that you was filtering a location being always blocked by the enemy. This should work (removed every minus from the directions, added our method and added defender hits):

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_RETREAT
       [dummy]
           id=retreat
           name= _ "retreat"
           female_name= _ "female^retreat"
           description=_ "Retreat:
   When a unit scores a hit with a retreat attack, it allows it to move back one hex, thus interupting the attack. A unit can't retreat from a village, however, and can't move into an occupied space or a space it couldn't normally move to."
       [/dummy]
       [/specials]
               [/attack]
[event]
       name=attacker hits,defender hits
       first_time_only=no
   
       [filter_attack]
           special=retreat
       [/filter_attack]
   
       [filter_second]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter_second]
   
       [if]
           [variable]
               name=second_unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x1,$y1
                       [filter_adjacent]
                           x,y=$x2,$y2
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE retreat_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x1,$y1
                               [filter_adjacent]
                                   x,y=$x2,$y2
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE retreat_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x1,$y1
                                       [filter_adjacent]
                                           x,y=$x2,$y2
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE retreat_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x1,$y1
                                               [filter_adjacent]
                                                   x,y=$x2,$y2
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE retreat_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x1,$y1
                                                       [filter_adjacent]
                                                           x,y=$x2,$y2
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE retreat_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x1,$y1
                                                               [filter_adjacent]
                                                                   x,y=$x2,$y2
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE retreat_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x1,$y1
                       adjacent=$retreat_direction
                   [/filter_adjacent_location]
   
                   variable=retreat_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=retreat_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x1,$y1
                           [/filter]
   
                           x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=fist.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$retreat_target_hex.x,$retreat_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=fled
                               [/store_unit]
   
                               {VARIABLE_OP fled.experience add $unit.level}
   
                               [unstore_unit]
                                   variable=fled
                                   text= _ "escaped"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE fled}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE retreat_direction,retreat_target_hex}
           [/then]
       [/if]
   [/event]
   [+attack]
           [+specials]
#enddef

[edited because I forgot to add [/xx] [+xx]]

[Dixie]

Hm. You have managed to fix my retreat ability (which was my second issue). However the "name=attacker hits,defender hits" thing doesn't work. The game misinterpretsthe code. Here is what it does:

Say U1 has knockback and attacks U2.
U1 (the attacker) hits = U2 is knocked back. OR U2 (the defender) hits U1 in retaliation, but U2 is still knocked back.
If U2 attacks U1 afterwards, the knockback ability is totally void.

So I don't really know what to do. If I had the choice between either jsut offense or jsut defense, I would pick defense. Would a line saying "active_on=defense" work? What else would you suggest?

I'll continue looking at the event wiki page, just in case.

Thanks again for your concern

EDIT:
Could it be possible to do it using an additionnal macro or something using the [filter_second_attack] filter tag, and then inversing the code in the [event] tag or something to make it work on defense? Where would I put such a command? In every [era] tag of my IME_eras.cfg?

[Dixie]

Double post, sorry to all purists out there. The situation has evolved though, so I figured a double-post was needed.

I must declare... this is a success! I managed to have it work on defense! Yay!

Here is the code to knockback:

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_KNOCKBACK
       [knockback]
           id=knockback
           name= _ "knockback"
           description=_ "Knockback:
   When a unit is hit with a knockback attack, it is immediately pushed back one hex away from the attacker. Units cannot be knocked back into an occupied hex, out of villages or onto terrain they normally could not move to."
       [/knockback]
       [/specials]
       [/attack]
[event]
       name=attacker hits
       first_time_only=no
   
       [filter_attack]
           special=knockback
       [/filter_attack]
   
       [filter_second]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter_second]
   
       [if]
           [variable]
               name=second_unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x1,$y1
                       [filter_adjacent]
                           x,y=$x2,$y2
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE knockback_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x1,$y1
                               [filter_adjacent]
                                   x,y=$x2,$y2
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE knockback_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x1,$y1
                                       [filter_adjacent]
                                           x,y=$x2,$y2
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE knockback_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x1,$y1
                                               [filter_adjacent]
                                                   x,y=$x2,$y2
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE knockback_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x1,$y1
                                                       [filter_adjacent]
                                                           x,y=$x2,$y2
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE knockback_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x1,$y1
                                                               [filter_adjacent]
                                                                   x,y=$x2,$y2
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE knockback_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x2,$y2
                       adjacent=-$knockback_direction
                   [/filter_adjacent_location]
   
                   variable=knockback_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=knockback_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x2,$y2
                           [/filter]
   
                           x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=fist.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$knockback_target_hex.x,$knockback_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=knockbacked
                               [/store_unit]
   
                               {VARIABLE_OP knockbacked.experience add $unit.level}
   
                               [unstore_unit]
                                   variable=knockbacked
                                   text= _ "knocked back"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE knockbacked}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE knockback_direction,knockback_target_hex}
           [/then]
       [/if]
   [/event]
[event]
       name=defender hits
       first_time_only=no
   
       [filter_second_attack]
           special=knockback
       [/filter_second_attack]
   
       [filter]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter]
   
       [if]
           [variable]
               name=unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x2,$y2
                       [filter_adjacent]
                           x,y=$x1,$y1
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE knockback_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x2,$y2
                               [filter_adjacent]
                                   x,y=$x1,$y1
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE knockback_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x2,$y2
                                       [filter_adjacent]
                                           x,y=$x1,$y1
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE knockback_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x2,$y2
                                               [filter_adjacent]
                                                   x,y=$x1,$y1
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE knockback_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x2,$y2
                                                       [filter_adjacent]
                                                           x,y=$x1,$y1
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE knockback_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x2,$y2
                                                               [filter_adjacent]
                                                                   x,y=$x1,$y1
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE knockback_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x1,$y1
                       adjacent=-$knockback_direction
                   [/filter_adjacent_location]
   
                   variable=knockback_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=knockback_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x1,$y1
                           [/filter]
   
                           x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$knockback_target_hex.x,$knockback_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=fist.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$knockback_target_hex.x,$knockback_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=knockbacked
                               [/store_unit]
   
                               {VARIABLE_OP knockbacked.experience add $second_unit.level}
   
                               [unstore_unit]
                                   variable=knockbacked
                                   text= _ "knocked back"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE knockbacked}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE knockback_direction,knockback_target_hex}
           [/then]
       [/if]
   [/event]
	[+attack]
	[+specials]
#enddef

Here is the code to retreat:

Spoiler:

Code: Select all

#define WEAPON_SPECIAL_RETREAT
       [retreat]
           id=retreat
           name= _ "retreat"
           description=_ "Retreat:
   When a unit scores a hit with a retreat attack, it allows it to move back one hex, thus interupting the attack. A unit can't retreat from a village, however, and can't move into an occupied space or a space it couldn't normally move to."
       [/retreat]
[/specials]
[/attack]
[event]
       name=attacker hits
       first_time_only=no
   
       [filter_attack]
           special=retreat
       [/filter_attack]
   
       [filter]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter]
   
       [if]
           [variable]
               name=unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x1,$y1
                       [filter_adjacent]
                           x,y=$x2,$y2
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE retreat_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x1,$y1
                               [filter_adjacent]
                                   x,y=$x2,$y2
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE retreat_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x1,$y1
                                       [filter_adjacent]
                                           x,y=$x2,$y2
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE retreat_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x1,$y1
                                               [filter_adjacent]
                                                   x,y=$x2,$y2
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE retreat_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x1,$y1
                                                       [filter_adjacent]
                                                           x,y=$x2,$y2
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE retreat_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x1,$y1
                                                               [filter_adjacent]
                                                                   x,y=$x2,$y2
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE retreat_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x1,$y1
                       adjacent=$retreat_direction
                   [/filter_adjacent_location]
   
                   variable=retreat_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=retreat_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x1,$y1
                           [/filter]
   
                           x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=magic-faeriefire-miss.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$retreat_target_hex.x,$retreat_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=fled
                               [/store_unit]
   
                               {VARIABLE_OP fled.experience add $second_unit.level}
   
                               [unstore_unit]
                                   variable=fled
                                   text= _ "escaped"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE fled}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE retreat_direction,retreat_target_hex}
           [/then]
       [/if]
   [/event]
[event]
       name=defender hits
       first_time_only=no
   
       [filter_second_attack]
           special=retreat
       [/filter_second_attack]
   
       [filter_second]
           [not]
               [filter_location]
                   terrain=*^V*
               [/filter_location]
           [/not]
       [/filter_second]
   
       [if]
           [variable]
               name=unit.hitpoints
               greater_than=0
           [/variable]
   
           [then]
               [if]
                   [have_unit]
                       x,y=$x2,$y2
                       [filter_adjacent]
                           x,y=$x1,$y1
                           adjacent=n
                       [/filter_adjacent]
                   [/have_unit]
                   [then]
                       {VARIABLE retreat_direction n}
                   [/then]
                   [else]
                       [if]
                           [have_unit]
                               x,y=$x2,$y2
                               [filter_adjacent]
                                   x,y=$x1,$y1
                                   adjacent=ne
                               [/filter_adjacent]
                           [/have_unit]
                           [then]
                               {VARIABLE retreat_direction ne}
                           [/then]
                           [else]
                               [if]
                                   [have_unit]
                                       x,y=$x2,$y2
                                       [filter_adjacent]
                                           x,y=$x1,$y1
                                           adjacent=se
                                       [/filter_adjacent]
                                   [/have_unit]
                                   [then]
                                       {VARIABLE retreat_direction se}
                                   [/then]
                                   [else]
                                       [if]
                                           [have_unit]
                                               x,y=$x2,$y2
                                               [filter_adjacent]
                                                   x,y=$x1,$y1
                                                   adjacent=s
                                               [/filter_adjacent]
                                           [/have_unit]
                                           [then]
                                               {VARIABLE retreat_direction s}
                                           [/then]
                                           [else]
                                               [if]
                                                   [have_unit]
                                                       x,y=$x2,$y2
                                                       [filter_adjacent]
                                                           x,y=$x1,$y1
                                                           adjacent=sw
                                                       [/filter_adjacent]
                                                   [/have_unit]
                                                   [then]
                                                       {VARIABLE retreat_direction sw}
                                                   [/then]
                                                   [else]
                                                       [if]
                                                           [have_unit]
                                                               x,y=$x2,$y2
                                                               [filter_adjacent]
                                                                   x,y=$x1,$y1
                                                                   adjacent=nw
                                                               [/filter_adjacent]
                                                           [/have_unit]
                                                           [then]
                                                               {VARIABLE retreat_direction nw}
                                                           [/then]
                                                       [/if]
                                                   [/else]
                                               [/if]
                                           [/else]
                                       [/if]
                                   [/else]
                               [/if]
                           [/else]
                       [/if]
                   [/else]
               [/if]
   
               [store_locations]
                   [not]
                       [filter]
                       [/filter]
                   [/not]
   
                   [filter_adjacent_location]
                       x,y=$x2,$y2
                       adjacent=$retreat_direction
                   [/filter_adjacent_location]
   
                   variable=retreat_target_hex
               [/store_locations]
   
               [if]
                   [variable]
                       name=retreat_target_hex.length
                       greater_than=0
                   [/variable]
   
                   [then]
                       [teleport]
                           [filter]
                               x,y=$x2,$y2
                           [/filter]
   
                           x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           ignore_passability=no
                       [/teleport]
   
                       [if]
                           [have_unit]
                               x,y=$retreat_target_hex.x,$retreat_target_hex.y
                           [/have_unit]
   
                           [then]
                               [sound]
                                   name=magic-faeriefire-miss.ogg
                               [/sound]
   
                               # the knockbacked unit doesn't seem to receive experience by default,
                               # so we need to add it manually
                               [store_unit]
                                   [filter]
                                       x,y=$retreat_target_hex.x,$retreat_target_hex.y
                                   [/filter]
   
                                   kill=yes
                                   variable=fled
                               [/store_unit]
   
                               {VARIABLE_OP fled.experience add $unit.level}
   
                               [unstore_unit]
                                   variable=fled
                                   text= _ "escaped"
                                   {COLOR_HARM}
                                   advance=true
                               [/unstore_unit]
   
                               {CLEAR_VARIABLE fled}
                           [/then]
                       [/if]
                   [/then]
               [/if]
   
               {CLEAR_VARIABLE retreat_direction,retreat_target_hex}
           [/then]
       [/if]
   [/event]
[+attack]
[+specials]

#enddef

There still are some issues, though. Here are my observations:

- Retreat on defense gives exp to both units.
- Retreat on defense makes you abandon a village.
- Retreat on defense doesn,t work if the attacker (the not-retreating unit) is on a village!

- Retreat on offense doesn't give exp to retreating unit.
- Retreat on offense makes you abandon a village.
- Retreat on offense doesn't work if the defender (the not-retreating unit) is on a village!

- Knockback on defense gives exp to both units.
- However, knockback on defense gives its own level in exp to the knockbacked unit (if it is knockbacked)
(ex: U1 has knockback and is lv1, and is attacked by U2, which is lv2. If U2 is knockbacked, it will earn 2 exps, instead of the 1 exp it should)!
- Knockback on defense doesn't make you leave a village.

- Knockback on offense gives exp to both units.
- Knockback on offense doesn't make you leave a village.

As of now, I can't seem to think straight anymore. I don't really understand how the experience-giving part of the code works, I'd have to look at it longer. Also, I can't find the line about not knocking back out of a village, so I can't reverse it to make retreat work properly.

Anyway, I'll inspect it some more tomorrow, thanks for any help. This is getting real close to being a complete success!

Edit:
I managed to have it work properly! Everything looks fine, and I've edited the above code to put the correct one in. Feel free to test it and report any bugs if you wish, but it should be ok now.

Thanks to all of you for your support!

[Dixie]

Well people, seems I'm pseudo thread-necroing some more, but...

Well, knockback worked perfectly fine a few weeks ago. I had tested it in every conceivable way. And now, this morning, it doesn't work on attack anymore. It works on defense, though, and retreat works top-notch! I've tried different previous supposedly working versions of knockback, I've tried various units, maps, terrains... But to no avail. I've proof-read the code over and over, and couldn't figure what the problem was. I even rebooted my laptop, rebooted the wesnoth app several times... I just don't get it. This is so god damn frustrating!

Anyway, would anybody have an explanation? Or at least try the above code and tell me if it's working for them?

Thanks, people.

[zookeeper]

Well people, seems I'm pseudo thread-necroing some more, but...

Well, knockback worked perfectly fine a few weeks ago. I had tested it in every conceivable way. And now, this morning, it doesn't work on attack anymore. It works on defense, though, and retreat works top-notch! I've tried different previous supposedly working versions of knockback, I've tried various units, maps, terrains... But to no avail. I've proof-read the code over and over, and couldn't figure what the problem was. I even rebooted my laptop, rebooted the wesnoth app several times... I just don't get it. This is so god damn frustrating!

Anyway, would anybody have an explanation?

Well, the fact that the following doesn't make any sense at all could be one:

Code: Select all

       [filter_second]
           [not]
               [filter_second_location]
                   terrain=*^V*
               [/filter_second_location]
           [/not]
       [/filter_second]

That is, is there a [filter_second_location] somewhere on this page? I think not.

Other than that, you could just find out what it is which isn't working right.

[Dixie]

Oh god, I feel so dumb right now, it looks so obvious now *face palm*.

Still I could have sworn it used to work in every conceivable way a few weeks ago, and that it contained that code. How could I possibly have missed such an obvious bug in my tests? Anyway, it's fixed now... Thank you dearly, zookeeper, your WML wisdom is always most appreciated.

Anyway, I've corrected it in the above code, so fear not using it if you need to.