Code Review

[Hannibal Barca]

Greetings,

I suspect there is ancient code in the Elves and Wose scenarios.

I started with the intent of simply getting it running but I am starting to lean to changing it as I go.

Right now I am only getting it to work on 1.4

Here is the first scenario. It runs but there are things I don't like about it. For example an Elf lord running around and Orks don't place it as a high priority target.

Can people give it a look and offer suggestions? I am curious to code structure in particular.

Thank you

[Mathemagician]

Looks OK to me, though you might want to run wmllint on it just to be sure. All I found were minor things:

• You can replace {DAWN}, {MORNING}, etc with {DEFAULT_SCHEDULE}
• Greentall needs a user_description
• The indentation is inconsistent. You can use wmlindent to fix it.

Take a look at AiWML if you want to tweak the AI to attack lone Elf Lords.