Another problem...

[toms]

The attached scenario ends after the second turn. (and that´s wrong)

(You will need the utils files to understand)

[scott]

The human player doesn't have any sides with canrecruit=1

[toms]

There is still nothing.
Also the {ENEMIES_APPEAR} doesn´t work.

[scott]

Does this scenario end in victory or defeat? Besides not having a side 1 leader, you don't have an enemy leader either. Try adding victory_when_enemies_defeated=no.

In ENEMIES_APPEAR, although I didn't see them defined anywhere, xx and yy need $ in these lines:

Code: Select all

			 		[unit]
			 		type=Wolf
			 		x=xx
			 		y=yy
			 		[/unit] 

In the scenario, try using numerical_equals in this statement:

Code: Select all

	[event]
	name=new turn
		[if]
		{VAR missing equals 0}
			[then]
			{RANDOM_NEXT_SCENARIO no}
			[/then]
		[/if]
	[/event]

In STARTING_SCENE_BEG, the {VAR} macro has a spurious underscore and looks like this: {VAR_ }

In LASTLEVEL_MAP_CHG, I don't think the x and y variables are going to be expressed: {TERRAIN ($tmp_caveloc[$i].x) ($tmp_caveloc[$i].y) m}
Try using a format statement to put them into temp variables first. I could be wrong.

There may be some more bugs, but this is what I saw upon second look.

[toms]

Thank you for all, but what do you mean with a format statement?
I can imagine what it is about, but I don´t know what i should do.

I already have done the other things, but I still win on the first turn.

And do I need numerical_equals whenever the value of a variable is a number?

[scott]

With regards to the format statement, sometimes variable expression with $ doesn't work. The exact details are in the wiki, which I recommend you read. My take on the matter may be wrong, but it does err on the side of caution.

If you have a key

Code: Select all

x=$tmp_caveloc[$i].x

That may not work - not all of the $'s are expressed. Instead, do this:

Code: Select all

{VARIABLE_OP x_temp format $tmp_caveloc[$i].x}

then use the temp variable in the key:

Code: Select all

x=$x_temp

The VARIABLE_OP macro above is expanded to this (FYI):

Code: Select all

[set_variable]
name=x_temp
format=$tmp_caveloc[$i].x
[/set_variable]

At this point, I would start cutting out all your events and getting the bare-bones scenario to work. Once it does, add the events back slowly to isolate which one is causing the problems. Could you post an updated scenario file? Perhaps you overlooked something that you thought you fixed.

Edit: yes, you should use numerical_equals whenever it's a number.

Edit 2: I fixed the mistake pointed out below

[zookeeper]

then use the temp variable in the key:

Code: Select all

x=x_temp

Otherwise correct, but x=$x_temp would be a bit better.

[scott]

then use the temp variable in the key:

Code: Select all

x=x_temp

Otherwise correct, but x=$x_temp would be a bit better.

Whoops! Right.

[toms]

Thank you for all, but In noticed another problem:
This stuff doesn´t work:

Code: Select all

[recall]
description=Tith
[/recall]
[recall]
description=Illanin
[/recall]

And it does in another scenario.

[scott]

Check to make sure they are in your recall list, either by attempting to recall them or examining the saved game. You probably killed them in another scenario, cleared their storage variable somewhere, or forgot to unstore them if stored.

[toms]

The end of the scenario on the first turn is now fixed.

...I forgot the evil victory_when_enemies_defeated=no.

Remaining problems:
No unit is unstored correctly. (the leader was already on level 2 when playtesting, now he´s back on level 1)
The map overlay is not working.
I posted the actual scenario and the corrected macros here.

[scott]

For the map overlay, try making the path relative to userdata/data, that is, try {@campaigns/campaignname/maps/variations/landing1}

It may not be necessary, but it can't hurt (especially if it works).


Next, I couldn't find any instance of [unstore_unit] or [store_unit] in these files. Without an [unstore_unit] tag, a unit can't be unstored.

[toms]

Yes, you will have to try hard because they are unstored 2 levels before.

And about the overlay stuff: Unfortunately, your suggestion does not work.

[toms]

The overlay works now. It was something wrong with the path, because I temporarily inserted the terrain letter block.

The only remaining problem is the macro {ENEMIES_APPEAR}, then it should basically go.