Log error message

[Spannerbag]

yes that correct, only the "orignal" action is put on the unit stack

(actually i see little reason why it shoul dbe that way, i think we could drather easily make for examle [move_unit] call [on_undo] internally to add itself to the undo stack)

Good idea; making all movement (that doesn't change gamestate) undoable would be more consistent for players (perhaps ).
No idea whether it'd be feasible to also include non-player originated [teleport], [tunnel] etc. as well as [move_unit].
Heh, but then it wouldn't be me doing the coding, I'm great at generating work for other people.

I can kinda see why recruitment is not undoable, even if something like [kill] might do the job (assuming [kill] syncs in multiplayer) as this would presumably also remove all the random number dependent data generated as part of the recruit action for this unit.

As I see it if recruitment was made undoable then redo should, for consistency, also be available as a single simple action: i.e. implemented in the game engine without the need for [on_redo].
Generally, recruited units have various random elements; id, name, trait(s) etc. so there would be no way to redo that (i.e. reinstate the "un-recruited" unit exactly, as Celtic_Minstrel explained) unless the last recruited unit was automatically stored internally by the game engine?
My head's starting to hurt now...

Thanks ever so much for your help and patience, much appreciated.
Cheers!
-- Spannerbag

[Celtic_Minstrel]

I can kinda see why recruitment is not undoable, even if something like [kill] might do the job (assuming [kill] syncs in multiplayer) as this would presumably also remove all the random number dependent data generated as part of the recruit action for this unit.

Actually, I'm pretty sure recruiting a skeleton is undoable in the absence of that random stuff. For example, if I'm not mistaken, I believe you can undo the recruit of a skeleton.

As I see it if recruitment was made undoable then redo should, for consistency, also be available as a single simple action: i.e. implemented in the game engine without the need for [on_redo].

Presumably there was a good reason to remove [on_redo], so I don't see reinstating it as something likely to happen.

Generally, recruited units have various random elements; id, name, trait(s) etc. so there would be no way to redo that (i.e. reinstate the "un-recruited" unit exactly, as Celtic_Minstrel explained) unless the last recruited unit was automatically stored internally by the game engine?

No, this isn't really the case – storing the last recruited unit isn't necessary. I think the only thing you would need for fully undoable recruits is a way to rewind the random number generator. If the generator were rewound, you would get the exact same unit when you redo anyway.

[Spannerbag]

I can kinda see why recruitment is not undoable...

Actually, I'm pretty sure recruiting a skeleton is undoable in the absence of that random stuff. For example, if I'm not mistaken, I believe you can undo the recruit of a skeleton.

Just tried this and yes, that is so!

As I see it if recruitment was made undoable then redo ...

Presumably there was a good reason to remove [on_redo], so I don't see reinstating it as something likely to happen.

Oops, didn't realise [on_redo] had been binned. Never used it.

...recruited units have various random elements ... so there would be no way to redo that (... unless the last recruited unit was automatically stored internally by the game engine?

No, this isn't really the case – storing the last recruited unit isn't necessary. I think the only thing you would need for fully undoable recruits is a way to rewind the random number generator. If the generator were rewound, you would get the exact same unit when you redo anyway.

That is a much more elegant method!

Thanks very much for clarifying and explaining all of this, it helped. A lot.
Cheers!
-- Spannerbag

[gfgtdf]

i wonder why we even mention [on_redo] in the wiki, it wasn't supported in any stable release

[beetlenaut]

If the generator were rewound, you would get the exact same unit when you redo anyway.

Not if you recruited your units in a different order to make sure that didn't happen. This would allow you to fish around for specific traits on at least some of your units.

[Celtic_Minstrel]

But that's not redo.