Dixie's Thread

[fog_of_gold]

Why? -It's already random since hitting is random.

[Dixie]

Well I am not on my computer since I'm not home, and thus cannot copy you the code, but it could be done pretty easily by replacing 1 by some throw_a_dice variable which can be easily randomnly generated. I know there was a thread about a month old or two that suggested that code. Or if you want it, you can go look at my Kamikaze weapon special, in Internet Meme Era, which uses it to generate random splash damage.

But Fog_of_gold's point is actually pretty good as fine as my interests go.

[Dixie]

Well, well, I feel a bit weird fetching this thread at the bottom of page four, but it's my dear ability questionning thread, so I just had to fetch it

Anyway, I've worked on some of the new abilities for IME's robot faction. I think I managed to deal with most of the stuff, and although I haven't tested it yet, I'd like you to take a peek at a few of them if you don't overly mind and give me your opinion.


Bulldoze

That ability is a terrain-altering one for a bulldozer unit. When it ends/starts its turn on a snow/forest/hill hex, it should change it to dirt (flat). All kind of desert terrains should be changed to desert roads, and rocky caves/mushroom grves should be changed to caves. (illuminated rocky caves are changed to illuminated caves. The wiki didn't mention illuminated mushroom groves, and I don't remember them: should I include them?)

So anyway, here's the code. Tell me if there's something wrong, or if there are stuff I could have done better (it gets confusing pretty easily with the layers!...)

Bulldoze ability's code:

Code: Select all

#################################

#define ABILITY_BULLDOZE
	[dummy]
		id=bulldoze
		name= _ "bulldoze"
	    description= _ "Bulldoze: As this unit moves on any kind of hill, forest or snow hex, it will change it into dirt. It will also change the various desert terrains to desert roads, as well as rocky caves and mushroom groves into ordinary caves." 
	[/dummy]

[/abilities]
[event]

	name=side turn
	first_time_only=no

	[filter]
          ability=bulldoze
	[/filter]

	[if]
	  terrain=*^F*
	 [or]
	  terrain=Hh
	 [/or]
	 [or]
	  terrain=Aa
	 [/or]
	 [or]
	  terrain=Re^Gvs
	 [/or]
	 [or]
	  terrain=Gg^Wm
	 [/or]
	    [then]
		[terrain]
		   terrain=Re
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=Dd^Dc
	 [or]
	  terrain=Dd
	 [/or]
	 [or]
	  terrain=Dd^Dr
	 [/or]
	 [or]
	  terrain=Hd
	 [/or]
	 [or]
	  terrain=Ds
	 [/or]
	    [then]
		[terrain]
		   terrain=Rd
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=*^Uf
	 [or]
	  terrain=Uh
	 [/or]
	    [then]
		[terrain]
		   terrain=Uu
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=Uh^li
	    [then]
		[terrain]
		   terrain=Uu^li
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]

[/event]
[+abilities]

#enddef

#################################

Relentless

So this attack is meant for drills. I've changed lindsay40k's original idea a bit. Drill attacks are gonne be pierce, with many weak strikes. It should have normal CTH at first, but as soon as it scores a hit, CTH is changed to 90%. If a ulterior attack misses, it goes back to normal. And it could theorially go back and forth from either 90% or normal% CTH as much as luck would allow it until the attack ends.

Now, I've tried something with the [effect] tag, which is the best option I could think of. It basically adds a 90% CTH special ("surehit") to the attack, and removes it afterwards. My concern, however, is wether you can change CTH in the middle of an attack like that, and wether it'll go back and forth between either mode smoothly.

Relentless ability's code; Surehit's at the bottom:

Code: Select all

########################

#define WEAPON_SPECIAL_RELENTLESS

   [dummy]
      id=relentless
      name= _ "relentless"
      description= _ "Relentless:
As soon as a strike from a relentless attack hits, all the remaining strikes have a 90% chance to hit. If bad luck made an attack miss afterward, the chance to hit percentage would return to normal (until another attack hits). Available both on offense and defense."
   [/dummy]

[/specials]
[/attack]
[event]
    name=attacker_hits
    first_time_only=no
   
    [filter_attack]
        special=relentless
	[not]
	    special=surehit
	[/not]
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x1,$y1
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless
    	  [/filter_attack]
		[set_specials]
		    mode=append
		    special=surehit
		[/set_specials]
    [/effect]

[/event]

[event]
    name=attacker_misses
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x1,$y1
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]


[event]
    name=defender_hits
    first_time_only=no
   
    [filter_attack]
        special=relentless
	[not]
	    special=surehit
	[/not]
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x2,$y2
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless
    	  [/filter_attack]
		[set_specials]
		    mode=append
		    special=surehit
		[/set_specials]
    [/effect]

[/event]

[event]
    name=defender_misses
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x2,$y2
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]


[event]
    name=attack_end
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]

#enddef

########################

#define WEAPON_SPECIAL_SUREHIT
   [dummy]
      id=surehit
      name= _ "surehit"
      description= _ "Surehit:
90% chance to hit."
   [/dummy]

    [chance_to_hit]
	id=surehit
        value=90
        cumulative=no
    [/chance_to_hit]

#enddef

###########################

Dazzle

Now that's the tough one! Honestly, I've looked all over the wiki, but I could find no way to achieve what I want this special to do, and I know of no other era that uses a similar effect. Here is what it should do: when a unit with a dazzling attack scores a hit, the target's CTH are maxed at 50% for the next turn. It disappears by itself one turn later much like slow does. I thought of using the same (possibly dubious) method as relentless, but I could find no way to set a maximum CTH, and I couldn't figure out a way to make it vanish after a turn. Also, I haven't overlooked that last issue since it is not the most essential, but it'd be nice to be able to add "dazzled" to the target's stat, or something like that, much like poison and slow show under a unit's name in the right-handed pannel.

So, any idea how we could go about this ability?

Thanks again in advance for everything, fellas!

[markm]

I like the idea of combining buster with steal. "Lets just nip into town to pick that chap's pocket..."

-MarkM-

[Dixie]

@ markm:
Hmm... It wasn't my intent in the least, but the idea has merit. I'll think about it, I might use that somewhere.

----

Ok, apart from that, I coded my units and tested my new abilities. Turns out a lot of them don't work (surprised?), and I don,t really know how to fix that (although I tried, mind you). So! Here goes, if anyone cares to give me a few pointers:


Bulldoze

Problem Fixed!:

Well, epic fail. I don't really know. Am I using the [or] tags wrong? Or is it a more generalised problem with the [terrain] tags? (the wiki wasn't pretty clear on those). I also tried using "new turn" instead of "side turn" in the "name=" line, but to no avail.

So I'll just quote what I wrote yesterday, so you know what it should do and see the code.

That ability is a terrain-altering one for a bulldozer unit. When it ends/starts its turn on a snow/forest/hill hex, it should change it to dirt (flat). All kind of desert terrains should be changed to desert roads, and rocky caves/mushroom grves should be changed to caves. (illuminated rocky caves are changed to illuminated caves. The wiki didn't mention illuminated mushroom groves, and I don't remember them: should I include them?)

So anyway, here's the code. Tell me if there's something wrong, or if there are stuff I could have done better (it gets confusing pretty easily with the layers!...)

Bulldoze ability's code:

Code: Select all

#################################

#define ABILITY_BULLDOZE
	[dummy]
		id=bulldoze
		name= _ "bulldoze"
	    description= _ "Bulldoze: As this unit moves on any kind of hill, forest or snow hex, it will change it into dirt. It will also change the various desert terrains to desert roads, as well as rocky caves and mushroom groves into ordinary caves." 
	[/dummy]

[/abilities]
[event]

	name=side turn
	first_time_only=no

	[filter]
          ability=bulldoze
	[/filter]

	[if]
	  terrain=*^F*
	 [or]
	  terrain=Hh
	 [/or]
	 [or]
	  terrain=Aa
	 [/or]
	 [or]
	  terrain=Re^Gvs
	 [/or]
	 [or]
	  terrain=Gg^Wm
	 [/or]
	    [then]
		[terrain]
		   terrain=Re
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=Dd^Dc
	 [or]
	  terrain=Dd
	 [/or]
	 [or]
	  terrain=Dd^Dr
	 [/or]
	 [or]
	  terrain=Hd
	 [/or]
	 [or]
	  terrain=Ds
	 [/or]
	    [then]
		[terrain]
		   terrain=Rd
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=*^Uf
	 [or]
	  terrain=Uh
	 [/or]
	    [then]
		[terrain]
		   terrain=Uu
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[else]
	 [if]
	  terrain=Uh^li
	    [then]
		[terrain]
		   terrain=Uu^li
		   x,y=$x1,$y1
		[/terrain]
	    [/then]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]

[/event]
[+abilities]

#enddef

#################################

Correct code for Bulldoze:

Code: Select all

#################################

#define ABILITY_BULLDOZE
	[dummy]
		id=bulldoze
		name= _ "bulldoze"
	    description= _ "Bulldoze: As this unit moves on any kind of hill, forest or snow hex, it will change it into dirt. It will also change the various desert terrains to desert roads, as well as rocky caves and mushroom groves into ordinary caves." 
	[/dummy]

[/abilities]
[event]

	name=side turn
	first_time_only=no

	[store_unit]
	[filter]
          side=$side_number 
          ability=bulldoze
	[/filter]
        variable=bulldozers
	kill=no
	[/store_unit]

    {FOREACH bulldozers i}
	[if]
	  [have_location]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	      terrain=*^F*,Hh,Aa,Re^Gvs,Gg^Wm
	  [/have_location]  

	    [then]
		[terrain]
		   terrain=Re
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]

	  [have_location]
	    x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    terrain=Dd^Dc,Dd,Dd^Dr,Hd,Ds
	  [/have_location] 
 
	    [then]
		[terrain]
		   terrain=Rd
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]
	  [have_location]
	    x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    terrain=*^Uf,Uh
	  [/have_location] 

	    [then]
		[terrain]
		   terrain=Uu
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]
	  [have_location]
	    x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    terrain=Uh^li
	  [/have_location] 

	    [then]
		[terrain]
		   terrain=Uu^li
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]

		    [unstore_unit]
                        variable=bulldozers[$i]
                        find_vacant=no
                        text= _ "bulldozed"
                        {COLOR_HARM}
                    [/unstore_unit]

    {NEXT i}
    {CLEAR_VARIABLE bulldozers}



[/event]
[+abilities]

#enddef

#################################

Relentless

Problem Fixed!!!:

Ok, so doesn't work either. I tried with changing CTH to 100% just for the sake of testing, but it didn't work better. So I guess the effect tag can't just be switched that way in the middle of combat. Would there be a way to achieve what I want to, or is it hopeless? Suggestions?

Once again, quote from yesterday:

So this attack is meant for drills. I've changed lindsay40k's original idea a bit. Drill attacks are gonne be pierce, with many weak strikes. It should have normal CTH at first, but as soon as it scores a hit, CTH is changed to 90%. If a ulterior attack misses, it goes back to normal. And it could theorially go back and forth from either 90% or normal% CTH as much as luck would allow it until the attack ends.

Now, I've tried something with the [effect] tag, which is the best option I could think of. It basically adds a 90% CTH special ("surehit") to the attack, and removes it afterwards. My concern, however, is wether you can change CTH in the middle of an attack like that, and wether it'll go back and forth between either mode smoothly.

Code: Select all

########################

#define WEAPON_SPECIAL_RELENTLESS

   [dummy]
      id=relentless
      name= _ "relentless"
      description= _ "Relentless:
As soon as a strike from a relentless attack hits, all the remaining strikes have a 90% chance to hit. If bad luck made an attack miss afterward, the chance to hit percentage would return to normal (until another attack hits). Available both on offense and defense."
   [/dummy]

[/specials]
[/attack]
[event]
    name=attacker_hits
    first_time_only=no
   
    [filter_attack]
        special=relentless
	[not]
	    special=surehit
	[/not]
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x1,$y1
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless
    	  [/filter_attack]
		[set_specials]
		    mode=append
		    special=surehit
		[/set_specials]
    [/effect]

[/event]

[event]
    name=attacker_misses
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x1,$y1
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]


[event]
    name=defender_hits
    first_time_only=no
   
    [filter_attack]
        special=relentless
	[not]
	    special=surehit
	[/not]
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x2,$y2
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless
    	  [/filter_attack]
		[set_specials]
		    mode=append
		    special=surehit
		[/set_specials]
    [/effect]

[/event]

[event]
    name=defender_misses
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	[filter]
            x,y=$x2,$y2
	[/filter]

	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]


[event]
    name=attack_end
    first_time_only=no
   
    [filter_attack]
        special=relentless,surehit
    [/filter_attack]

    [effet]
	apply_to=attack
    	  [filter_attack]
            special=relentless,surehit
    	  [/filter_attack]
		remove_specials=surehit
    [/effect]

[/event]

#enddef

########################

#define WEAPON_SPECIAL_SUREHIT
   [dummy]
      id=surehit
      name= _ "surehit"
      description= _ "Surehit:
90% chance to hit."
   [/dummy]

    [chance_to_hit]
	id=surehit
        value=90
        cumulative=no
    [/chance_to_hit]

#enddef

###########################

[/quote]

Correct code for Relentless:

Code: Select all

########################

# Be careful with that "attack[1]", it means your Relentless weapon must be your unit's second weapon! 
# If you want it to be first, use "attack[0]" instead, or third would be "attack[2]", etc.
# You could also do it with the FOREACH macro and "attack[i]" for every attack.

#define WEAPON_SPECIAL_RELENTLESS

   [dummy]
      id=relentless
      name= _ "relentless"
      description= _ "Relentless:
As soon as a strike from a relentless attack hits, all the remaining strikes have a 100% chance to hit. "
   [/dummy]

[/specials]
[/attack]
    [event]
        name=attacker hits
        first_time_only=no

        [filter_attack]
            special=relentless
        [/filter_attack]


                    [if]
                        [variable]
                            name=unit.attack[1].specials.chance_to_hit.length
                            greater_than=0
                        [/variable]

                        [then]
                            [set_variables]
                                name=unit.attack[1].specials.original_chance_to_hit
                                to_variable=unit.moledrill.specials.chance_to_hit
                            [/set_variables]

                            {CLEAR_VARIABLE unit.attack[1].specials.chance_to_hit}
                        [/then]
                    [/if]

                    [set_variables]
                        name=unit.attack[1].specials.chance_to_hit

                        [value]
                            id=forced_cth
                            value=100
                            cumulative=no
                        [/value]
                    [/set_variables]


                [unstore_unit]
                    variable=unit
                    find_vacant=no
                [/unstore_unit]

                [event]
                    name=attack end
                    delayed_variable_substitution=yes

                        {CLEAR_VARIABLE unit.attack[1].specials.chance_to_hit}

                        [set_variables]
                            name=unit.attack[1].specials.chance_to_hit
                            to_variable=unit.attack[1].specials.original_chance_to_hit
                        [/set_variables]

                        {CLEAR_VARIABLE unit.attack[1].specials.original_chance_to_hit}


                    [unstore_unit]
                        variable=unit
                        find_vacant=no
                    [/unstore_unit]
                [/event]

    [/event]

    [event]
        name=defender hits
        first_time_only=no

        [filter_second_attack]
            special=relentless
        [/filter_second_attack]


                    [if]
                        [variable]
                            name=second_unit.attack[1].specials.chance_to_hit.length
                            greater_than=0
                        [/variable]

                        [then]
                            [set_variables]
                                name=second_unit.attack[1].specials.original_chance_to_hit
                                to_variable=second_unit.attack[1].specials.chance_to_hit
                            [/set_variables]

                            {CLEAR_VARIABLE second_unit.attack[1].specials.chance_to_hit}
                        [/then]
                    [/if]

                    [set_variables]
                        name=second_unit.attack[1].specials.chance_to_hit

                        [value]
                            id=forced_cth
                            value=100
                            cumulative=no
                        [/value]
                    [/set_variables]

                [unstore_unit]
                    variable=second_unit
                    find_vacant=no
                [/unstore_unit]

                [event]
                    name=attack end
                    delayed_variable_substitution=yes

                        {CLEAR_VARIABLE second_unit.attack[1].specials.chance_to_hit}

                        [set_variables]
                            name=second_unit.attack[$i].specials.chance_to_hit
                            to_variable=second_unit.attack[1].specials.original_chance_to_hit
                        [/set_variables]

                        {CLEAR_VARIABLE second_unit.attack[1].specials.original_chance_to_hit}

                    [unstore_unit]
                        variable=second_unit
                        find_vacant=no
                    [/unstore_unit]
                [/event]

    [/event]

[+attack]
[+specials]

#enddef

Fueling

Problem Fixed:

Ah! An ability I really thought would work and didn't post yesterday, dear me! It's supposed to be like feeding, but instead of gaining +1 hp, you gain +1 damage to melee. I'm not sure why it doesn't work... Did I do my [filter_attack] wrong in the [effect] tag? The wiki isn't really clear on that part...

Code: Select all

#############################

# wmllint: unbalanced-on
#define ABILITY_FUELING

    [dummy]
        id=fueling
        name= _ "fueling"
        description=_ "Fueling:
This unit gains 1 damage added to its melee attack whenever it kills a living unit, burning its remains to augment its inherent heat."
    [/dummy]

[/abilities]
[event]
    name=die
    first_time_only=no

    [filter]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
    [/filter]

    [filter_second]
        ability=feeding
    [/filter_second]

    [unstore_unit]
        variable=second_unit
        {COLOR_HEAL}
        text= _ "+1 damage"
        find_vacant=no
    [/unstore_unit]

    [object]
        silent=yes
        duration=forever

        [filter]
            x,y=$x2,$y2
        [/filter]

        [effect]
            apply_to=attack
		[filter_attack]
		    range=melee
		[/filter_attack]
            increase_damage=1
        [/effect]
    [/object]
[/event]
[+abilities]

#enddef
# wmllint: unbalanced-off

################################

Correct code for Fueling:

Code: Select all

# wmllint: unbalanced-on
#define ABILITY_FUELING

    [dummy]
        id=fueling
        name= _ "fueling"
        description=_ "Fueling:
This unit gains 1 damage added to its melee attack whenever it kills a living unit, burning its remains to augment its inherent heat."
    [/dummy]

[/abilities]
[event]
    name=die
    first_time_only=no

    [filter]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
    [/filter]

    [filter_second]
        ability=fueling
    [/filter_second]

    [unstore_unit]
        variable=second_unit
        {COLOR_HEAL}
        text= _ "+1 damage"
        find_vacant=no
    [/unstore_unit]

    [object]
        silent=yes
        duration=forever

        [filter]
            x,y=$x2,$y2
        [/filter]

        [effect]
            apply_to=attack
	    range=melee
            increase_damage=1
        [/effect]
    [/object]
[/event]
[+abilities]

#enddef
# wmllint: unbalanced-off

PS: Silly me, I just found out it was already existing in WML Abilities as "Soul Taker"!

Smog Spill

Problem Fixed:

Another one I thought would work. When the Smog Spilling unit dies, it should poison all adjacent (living) units. I think I must have done something wrong with the [status] tag, because I made an ability which is the same but instead deals 15 damage, and it works! Worst yet, the FOREACH stuff in Smog Spil is surely OK, because it displays "poisonned" in red above the units it should, but doesn't poison them. Once again, wiki is unclear on the [status] tag...

Code: Select all

#################################

#define ABILITY_SMOGSPILL
	[dummy]
		id=smog spill
		name= _ "smog spill"
	    description= _ "Smog Spill: When this unit is destroyed, all the toxic gases it contained are unleashed, poisonning all surrounding living (non poison immune) units in the process." 
	[/dummy]

[/abilities]
[event]
	name=die
	first_time_only=no

    [filter]
        ability=smog spill
    [/filter]

    [store_unit]
        [filter]
            [filter_adjacent]
                x,y=$x1,$y1
            [/filter_adjacent]
		[not]
			[filter_wml]
				[modifications]
					[trait]
						id=mechanical
					[/trait]
				[/modifications]
			[/filter_wml]
		[/not]
        [/filter]
       
        variable=units
	kill=no
    [/store_unit]

    {FOREACH units i}
	[status]
	    poisonned=yes
	[/status]
		    [unstore_unit]
                        variable=units[$i]
                        find_vacant=no
                        text= _ "poisonned"
                        {COLOR_HARM}
                    [/unstore_unit]

    {NEXT i}
    {CLEAR_VARIABLE units}

           [kill]
                x,y=$x1,$y1
           [/kill]   

[/event]
[+abilities]

#enddef

#################################

Correct code for Smog Spill:

Code: Select all

#################################

#define ABILITY_SMOGSPILL
	[dummy]
		id=smog spill
		name= _ "smog spill"
	    description= _ "Smog Spill: When this unit is destroyed, all the toxic gases it contained are unleashed, poisonning all surrounding living (non poison immune) units in the process." 
	[/dummy]

[/abilities]
[event]
	name=die
	first_time_only=no

    [filter]
        ability=smog spill
    [/filter]

    [store_unit]
        [filter]
            [filter_adjacent]
                x,y=$x1,$y1
            [/filter_adjacent]
        [not]
            [filter_wml]
                [status]
                    not_living="yes"
                [/status]
            [/filter_wml]
        [/not]
        [/filter]
       
        variable=units
	kill=no
    [/store_unit]

    {FOREACH units i}
		[set_variable]
			name=units[$i].status.poisoned
			value=yes
		[/set_variable]
		    [unstore_unit]
                        variable=units[$i]
                        find_vacant=no
                        text= _ "poisoned"
                        {COLOR_HARM}
                    [/unstore_unit]

    {NEXT i}
    {CLEAR_VARIABLE units}

           [kill]
                x,y=$x1,$y1
           [/kill]   

[/event]
[+abilities]

#enddef

#################################

Recycle, Extract & Refine

Problem Fixed!:

Last unworking set of abilities (which are variation of the same)! This one baffles me too, because it's basically the same stuff I had done for gold/coal miners and for scavenge/forage, and those worked, but not Recycle, Extract and Refine. Darn! I tried some stuff so it would work only once a turn instead of working ok but displaying the yellow "1"s every now and then ("new turn" instead of "side turn"), but since it didn't work, I reverted to the previous version... which doesn't work anymore. I must have screwed something else, but I can't find it...

Code: Select all

##################################################

#define ABILITY_RECYCLE
     [leadership]
          value=0
          id=recycle
          cumulative=no
          name="recycle"
          description= _ "Recycle:
Collecting scraps materials around its position, this unit is able to produce lower-quality oil, thus helping maintaining the economy. It produces 1 gold per turn."
    [/leadership]

[/abilities]
[event]
	name=new turn
	first_time_only=no
	[store_unit]
		[filter]
                    side=$side_number 
	            ability=recycle
		[/filter]
		variable=recycler
		kill=no
	[/store_unit]

		{FOREACH recycler i}
	
			 [gold]
                            side=$side_number 
                            amount=1
                         [/gold] 
			[unstore_unit]
				variable=recycler[$i]
				text="1"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE recycler}
 [/event]
[+abilities]
#enddef

##################################

#define ABILITY_EXTRACT
     [leadership]
          value=0
          id=forage
          cumulative=no
          name="extract"
          description= _ "Extract:
This unit is equipped to drill holes in the ground and pump up raw oil, thus helping maintaining the economy. It produces 2 gold per turn."
    [/leadership]

[/abilities]
[event]
	name=new turn
	first_time_only=no
	[store_unit]
		[filter]
                    side=$side_number 
	            ability=extract
		[/filter]
		variable=extractor
		kill=no
	[/store_unit]

		{FOREACH extractor i}
	
			 [gold]
                            side=$side_number 
                            amount=2
                         [/gold] 
			[unstore_unit]
				variable=extractor[$i]
				text="2"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE extractor}
 [/event]
[+abilities]
#enddef

##################################

#define ABILITY_REFINE
     [leadership]
          value=0
          id=refine
          cumulative=no
          name="refine"
          description= _ "Refine:
Refining raw oil into better sub-types of fuels and gases, this unit is able to help maintain the economy. It produces 3 gold per turn."
    [/leadership]

[/abilities]
[event]
	name=new turn
	first_time_only=no
	[store_unit]
		[filter]
                    side=$side_number 
	            ability=refine
		[/filter]
		variable=refiner
		kill=no
	[/store_unit]

		{FOREACH refiner i}
	
			 [gold]
                            side=$side_number 
                            amount=3
                         [/gold] 
			[unstore_unit]
				variable=refiner[$i]
				text="3"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE refiner}
 [/event]
[+abilities]
#enddef

##################################

Correct code for Extract, Lv1 through Lv3:

Code: Select all

##################################################

#define ABILITY_EXTRACT_LV1
     [leadership]
          value=0
          id=extract1
          cumulative=no
          name="extract"
          description= _ "Extract:
Extracting oil and minerals from the ground under it's current position, this unit is able to help maintain the economy to some extent. It produces it's level in gold per turn."
    [/leadership]

[/abilities]
[event]
	name=side turn
	first_time_only=no

	[if]
	  [have_unit]
	    side=$side_number
	    ability=extract1
	  [/have_unit]
	[/if]

	[store_unit]
		[filter]
                    side=$side_number 
	            ability=extract1
		[/filter]

		variable=extractors1
		kill=no
	[/store_unit]

		{FOREACH extractors1 i}
	
			 [gold]
                            side=$side_number 
                            amount=1
                         [/gold] 

			[unstore_unit]
				variable=extractors1[$i]
				text="1"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE extractors1}

 [/event]
[+abilities]
#enddef

#define ABILITY_EXTRACT_LV2
     [leadership]
          value=0
          id=extract2
          cumulative=no
          name="extract"
          description= _ "Extract:
Extracting oil and minerals from the ground under it's current position, this unit is able to help maintain the economy to some extent. It produces it's level in gold per turn."
    [/leadership]

[/abilities]
[event]
	name=side turn
	first_time_only=no

	[if]
	  [have_unit]
	    side=$side_number
	    ability=extract2
	  [/have_unit]
	[/if]

	[store_unit]
		[filter]
                    side=$side_number 
	            ability=extract2
		[/filter]

		variable=extractors2
		kill=no
	[/store_unit]

		{FOREACH extractors2 i}
	
			 [gold]
                            side=$side_number 
                            amount=2
                         [/gold] 

			[unstore_unit]
				variable=extractors2[$i]
				text="2"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE extractors2}

 [/event]
[+abilities]
#enddef

#define ABILITY_EXTRACT_LV3
     [leadership]
          value=0
          id=extract3
          cumulative=no
          name="extract"
          description= _ "Extract:
Extracting oil and minerals from the ground under it's current position, this unit is able to help maintain the economy to some extent. It produces it's level in gold per turn."
    [/leadership]

[/abilities]
[event]
	name=side turn
	first_time_only=no

	[if]
	  [have_unit]
	    side=$side_number
	    ability=extract3
	  [/have_unit]
	[/if]

	[store_unit]
		[filter]
                    side=$side_number 
	            ability=extract3
		[/filter]

		variable=extractors3
		kill=no
	[/store_unit]

		{FOREACH extractors3 i}
	
			 [gold]
                            side=$side_number 
                            amount=3
                         [/gold] 

			[unstore_unit]
				variable=extractors3[$i]
				text="3"
			        red,green,blue=255,255,0 
			[/unstore_unit]
				
		{NEXT i}
	
	{CLEAR_VARIABLE extractors3}

 [/event]
[+abilities]
#enddef

Dazzle

Haven't found a way to make that one work either, by the way, people, if you got any ideas.

Now that's the tough one! Honestly, I've looked all over the wiki, but I could find no way to achieve what I want this special to do, and I know of no other era that uses a similar effect. Here is what it should do: when a unit with a dazzling attack scores a hit, the target's CTH are maxed at 50% for the next turn. It disappears by itself one turn later much like slow does. I thought of using the same (possibly dubious) method as relentless, but I could find no way to set a maximum CTH, and I couldn't figure out a way to make it vanish after a turn. Also, I haven't overlooked that last issue since it is not the most essential, but it'd be nice to be able to add "dazzled" to the target's stat, or something like that, much like poison and slow show under a unit's name in the right-handed pannel.

So, any idea how we could go about this ability?

Well anyway, the good news is I have coded a bunch of other stuff which works perfectly, so I AM getting better at this, it's just not perfect yet Thanks for your support and everything, I'll continue searching on my own but any help is really appreciated.

[Dixie]

So, just a "few" words about my recent developments. I actually managed to fix a lot of problems by myself! I now feel a little silly and ashamed for having asked your help previously

Anyway, I stroke the corrected codes in the previous post, and I'll also add the new, correct ones in case any body came over here and needed them. Who knows? Better have it archived somewhere, I guess.

So, I'm still struggling with Bulldoze, but I stopping for tonight. I've tried something else, I thought it would work, but it didn't. Still, I'm fairly confident it can be done, somehow. I'll just post it here if anybody passes by and has any idea or insight to offer on that, but I'll continue working on it some this tomorrow, so I might eventually fix it.

Bulldoze, still not working...:

Code: Select all

#################################

#define ABILITY_BULLDOZE
	[dummy]
		id=bulldoze
		name= _ "Bulldoze"
	    description= _ "Bulldoze: As this unit moves on any kind of hill, forest or snow hex, it will change it into dirt. It will also change the various desert terrains to desert roads, as well as rocky caves and mushroom groves into ordinary caves." 
	[/dummy]

[/abilities]
[event]

	name=side turn
	first_time_only=no

	[filter]
          ability=bulldoze
	[/filter]

	[store_unit]
	[filter]
          ability=bulldoze
	[/filter]

        variable=bulldozers
	kill=no
	[/store_unit]

    {FOREACH bulldozers i}
	[if]
	  [have_location]
	    [filter]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    [/filter]
	    terrain=*^F*,Hh,Aa,Re^Gvs,Gg^Wm
	  [/have_location]  

	    [then]
		[terrain]
		   terrain=Re
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]

	  [have_location]
	    [filter]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    [/filter]
	    terrain=Dd^Dc,Dd,Dd^Dr,Hd,Ds
	  [/have_location] 
 
	    [then]
		[terrain]
		   terrain=Rd
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]
	  [have_location]
	    [filter]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    [/filter]
	    terrain=*^Uf,Uh
	  [/have_location] 

	    [then]
		[terrain]
		   terrain=Uu
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[else]
	 [if]
	  [have_location]
	    [filter]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	    [/filter]
	    terrain=Uh^li
	  [/have_location] 

	    [then]
		[terrain]
		   terrain=Uu^li
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]
	[/else]
	[/if]

		    [unstore_unit]
                        variable=bulldozers[$i]
                        find_vacant=no
                        text= _ "bulldozed"
                        {COLOR_HARM}
                    [/unstore_unit]

    {NEXT i}
    {CLEAR_VARIABLE bulldozers}

[/event]
[+abilities]

#enddef

#################################

I'm also at a total loss with Dazzle. Is there a way to create new statuses? Is there even way to set a maximum cth? I've looked a lot in the wiki and the game's various util files, but found nothing that could really help so far. Well maybe that bit of code I used for relentless but... I'm not too sure it'd really work. Sure, I could set cth to 50%, I could probably even find a way to make the sprite whitish or something and a way to make it vanish after one turn, but I don,t absolutely want cth to be precisely 50%, I want it to be at a maximum of 50%... So, no solution as of yet.

Thanks in advance for anything, guys!

[fog_of_gold]

About dazzle, you'll need filter_base_value:

Code: Select all

    [chance_to_hit]
        value=50
        [filter_base_value]
            greater_than=50
        [/filter_base_value]
    [/chance_to_hit]

And then just include it the same way your did with your other abilities.

BTW, next time it would be nice to mention into your IME topic you asked here since I usually don't look here.

[Dixie]

@ fog_of_gold:

Hmm, good idea, I'll have to try that. And sorry about not mentionning

---

Well, I've been struggling with Bulldoze some more. I tried lots of ways to write this diffrently: I used [store_location] instead of [store_unit], I tried [have_unit] instead of [have_location], tons of different filters and ways to include them, which in the end I figured should all amount to making the ability work, but to no avail. I looked at a lot of sections from the wiki, I looked in terrains-util.cfg (and a lot of other util files, actually), and I found nothing that could help me. I can't believe this seriously can't be scripted.

So anyway, I've narrowed the code for you, it's about 20-30 lines long, so if someone could take a peek at it and tell if there's something that seems wrong... it would be really appreciated. Now of course, you will say stuff like "Hey, there's no [/event] closing tag!" etc., but they're present in my code, I just gave you the critical bit. The rest is copy-paste.

Critical bit of code from Bulldoze:

Code: Select all

[event]

	name=side turn
	first_time_only=no

	[filter]
          side=$side_number 
          ability=bulldoze
	[/filter]

	[store_unit]
	[filter]
          side=$side_number 
          ability=bulldoze
	[/filter]
        variable=bulldozers
	kill=no
	[/store_unit]

    {FOREACH bulldozers i}
	[if]
	  [have_location]
	      x,y=$bulldozers[$i].x,$bulldozers[$i].y
	      terrain=*^F*,Hh,Aa,Re^Gvs,Gg^Wm
	  [/have_location]  

	    [then]
		[terrain]
		   terrain=Re
		   x,y=$bulldozers[$i].x,$bulldozers[$i].y
		[/terrain]
	    [/then]

# The code continues, all tags are eventually closed, it's all just copy paste of the above, but with different terrain codes.

Thanks in advance

[fog_of_gold]

You mustn't use [filter] within side turn. I'm not sure if it makes troubles since unknown/unneeded tags are usually ignored. But this tag isn't always unneeded which make differents. The best idea is, to try it out. Could you make empty messages ([message][/message]) and tell us in which part is called and which not (should be within [event], {FOREACH} and [then] tags)

[Dixie]

Seems like you were right about filters with "side turn". I thought I had done it elsewhere, but in those other events they were like "name=die" or other such thing. As far as I know the wiki didn't mention this issue, however, so I'm not sure I had a way of finding out. In any event, thanks a lot! Bulldoze now works! Yay!

I'll edit the code a few posts above, so the correct one is archived on the forum somewhere. I may be loosing my time doing this, but oh well, too bad.

---

About Dazzle. I've been looking for pieces of WML I'd need to create the whole thing. I was thinking of creating a weapon special (Dazzle) which colors the unit white-blue-ish (with the "CS(r,g,b)" code, in an [effect] tag) and gives an ability (Dazzled) which would reproduce the idea you stated earlier with the [chance_to_hit] tag. So far, all good.

Here's where I'm currently at: I want this to vanish after a turn, much like slow does. Now, I thought of storing "$side_turn" and "$turn_number" in variables to compare it afterwards, but there are two issues, mainly:

1) I can't find if there is a way to easily store a unit to a numbered variable, and having two other variables with the same number storing on what turn and on which side's turn said unit was dazzled, so we know which unit was dazzled when. Problem is, I need multiple variables (hence the number), since there could be literally dozens of dazzled units at once, and I also need a way to check wether a numbered variable is free or not. I was also wondering if I could find a way to do this more or less automatically, maybe with the {FOREACH marco? Can a {FOREACH macro with "i" create assorted variables[$i] (and scan for free ones)?

2) The next step would be creating an event that fires at every "side_turn" to compare the above variables with the current $turn_number and $side_turn. So I would ideally need a {FOREACH macro that scans and compares all the previous variables[$i], and removes the "dazzled" ability and white-blueish hue from the unit which have been dazzled for a whole turn. First, is this possible? Second, where should I put it? Will it launch if I place it in my [era] tag? Or would I need an event in, say, the dazzled ability to fire that sanning event every side_turn? And would that make the game lag horribly at the beginning of every side_turn?

Well, I'm not asking you to write it down for me. I think I'm pretty much able to do the main frame myself, but since it's quite some work, I would have wanted to know if it's possible before I put all the work in it. Or if you have any other ideas to suggest?

Either way, thanks for all you've done already, as well as for your future insight

-----

EDIT, a few hours later:

I will not do it tonight, but I have tought of a way I could make the code work. It would be a whole lot more work, though, but I am fairly certain I can achieve it. So here is:

1) The Dazzle special would be like I said above: change unit hue to white-blue-ish and give the Dazzled ability.

2) Now, I would have to code a whole bunch of different "Dazzled" abilities, say a hundred, to be sure we're never short even if a campaign is made. They are numbered, and each one is assorted with a XDazzled_on_turn and XDazzled_on_side_turn variable (where X is the number matching the Dazzled ability). Each Dazzled ability not only limits CTH like shown above by fog_of_gold, but it also test at each side_turn if XDazzled_on_turn is one less than $turn_number AND X XDazzled_on_side_turn is matching $side_turn. If it does, it removes the ability and the hue, and clears the variables.

3) Now, the variables XDazzled (that's actually the id, the name and description would be the same standard "Dazzled" for every single one) with its two assorted X variables should be given by the Dazzle weapon special. A serie of [if]s would test if a unit with the "1Dazzled" ability exists, if so it test "2Dazzled" and so on, until it finds a free one, applies it and sets the X variables. Hence the importance of having a good amount of Dazzled abilities.

So there, I think that covers it. Lots of code (all the 100 [if]s in the Dazzle weapon special and the 100 Dazzled abilities), but at least I know I can do it, and I think it should work, given that I make no mistake in all those lines. It'll be a lot of copy-paste, so it shouldn,t be so bad. If anyone has a simpler solution code-wise, though, don't hesitate sharing it

[Dixie]

Ok, double post again, people, mea culpa.

Here are the most recent developments regarding my Dazzle weapon special.

I've started coding it the way I described in my last edit, except for one small detail. I was planning to give the unit an ability which controlled [chance_to_hit]. I realised, however, that [chance_to_hit] is a weapon special tag, and not an ability one! So I decided creating a Dazzled weapon special to limit the chance_to_hit. But I still keep the XXDazzled ability for two reasons:

1) It'll have the code to test the variables and remove the effect.
2) I need it to match the numbered variables, and for the Dazzle weapon special to look for which number is free.

So far, so good. I have run in a few problems, some of which I could fix, some I'm still struggling with. So, the event from the Dazzle weapon special launches top notch on offense as well as on defense. I stored the target in the "todazzle" variable. I know my [if] (see code below) works, since the text in [unstore_unit] shows. Absolutely none of the other effects are applied, however: the ability "00dazzled" is not given, the weapon specials are not given, and the Color Shift is not applied.

Is there a specific order I should respect for such codes (my order may seem weird, but since I'll do this code portion a hundred times, I figured I'd put all the values I'd have to modify at the top, so I lose less time searching)? Are my filters incorrect, or is the problem something else? I know for sure it's not the 00dazzled ability that undoes all this too quick, since I tried removing the code portion that undid it and it the effects weren't applied anyway. The one thing I can think of being wrong is the attack name in the effect tag below the {FOREACH macro, but it doesn't explain why the others effect don't trigger. Even if the weapon special wasn't applied, I'd figure the hue and the ability would still show up anyway?

The code portion isn't too long, about 50 lines maybe.

troublesome code in Dazzle weapon special:

Code: Select all

	  [if]
	   [not]
	    [have_unit]
	      ability=00dazzled
	    [/have_unit]
	   [/not]

	  [then]
	    [effect]
	      [filter]
		find_in=todazzle
	      [/filter]
	      apply_to=new_ability
		[abilities]
		  {ABILITY_00DAZZLED}
		[/abilities]
	    [/effect]

	    [set_variable]
	      name=00dazzled_on_turn
	      value=$turn_number
	    [/set_variable]

	    [set_variable]
	      name=00dazzled_on_side_turn
	      value=$side_turn
	    [/set_variable]

	    [effect]
	      [filter]
		find_in=todazzle
	      [/filter]
	      apply_to=image_mod
		replace="CS(150,150,200)"
	    [/effect]

            {FOREACH todazzle.attack i}
		[effect]
	  	  [filter]
		    find_in=todazzle
	  	  [/filter]
		  apply_to=attack
		    name="todazzle.attack[$i]"
		    [set_specials]
			mode=append
			[specials]
			  {WEAPON_SPECIAL_DAZZLED}
			[/specials]
		    [/set_specials]
		[/effect]
	    {NEXT i}

	    [unstore_unit]
		variable=todazzle
		{COLOR_HARM}
		text= _ "dazzled"
		find_vacant=no
	    [/unstore_unit]
	  [/then]

	  [/if]

	{CLEAR_VARIABLE todazzle}

So, thanks for your help, once again

[fog_of_gold]

[effect] is only usable within [advancement] and [object]. You'll need xx.variables of a unit you save the turn number in. It's much easier anyway:

Spoiler:

Code: Select all

[object]
 silent=yes
 [filter]
  x,y=x2,y2
 [/filter]
 [effect]
  apply_to=attack
  remove_specials=dazzeled
 [/effect]
 [effect]
  apply_to=attack
  [set_specials]
   mode=append
   [chance_to_hit]
    #see above
   [/chance_to_hit]
  [/set_specials]
 [/effect]
 [effect]
  [filter]
   x,y=x1,y1
  [/filter]
  apply_to=image_mod
  replace="CS(150,150,200)"
 [/effect]
[/object]
[set_variable]
 name=second_unit.variables.dazzled_turn
 value=$turn_number
[/set_variable]
[unstore_unit]
 variable=second_unit
 text=_ "dazzled"
 {COLOR_HARM}
[/unstore_unit]

You don't need to ask if the unit was dazzled, just remove it and reset it. Also, you don't need to store the dazzled unit and therefore delete the variable. Just use second_unit. You mustn't/needn't repeat the filter within the effect. Just leave it in the object tag. 'find_vacant=no' is default anyway so you don't need it.

[Dixie]

Hmmm... seems a LOT less complicated then I had envisionned Still, a few questions:

- How should I test the turn number so the vanishes? An [event] somewhere, like in the [era] tag? Or should I use a [then] and [removeitem] subtag in that [object]? If so, does the [then] need to be enclosed in a [if]?
- Won't the variables (second_unit.variables.dazzled_turn) be overwritten if more units are dazzled before the effect has ended for that one? Or are they closely associated with the unit? Still, if the verification event is somewhere else, how will the game differenciate between a bunch of "second_unit"s? And if it's not somewhere else, it will only trigger whe the event is launched (ie. when a unit hits another with a Dazzle attack), no? Or is this meant to not actually be in an event?
- Maybe I could just use the "duration=" within the object? Does this support the key "turn" or something like that? It mentions "level", but there's no alternative...
- Also, I'll need some kind of filter to apply this to every attack. I guess I'll stick to my {FOREACH macro, right?

I'm really sorry for all these questions :S The [object] idea is good, but I still have trouble picturing how I'll get this done with about a hundred variables to test the turns. And now I don't know where I'd place my turn testing event anymore . Unless I fusion your [object] idea with my previous one, but it's a load of tedious work...

Anyway, thanks for your support, really!

EDIT:

I decided that even if I was not sure how I'd make the effect vanish yet (I thought maybe of an event in the weapon special), I'd at least try to make the object and let it be applied. I'm currently trying with your [object] tag. Ok, maybe the way I wrote the part about applying the weapon special to the attack is dubious, but I figured the color shift whould at least take place! I,ve tried lots of things: with and without the quotes, with filters in each effect, different ways to write a bunch of stuff... I've not figured what doesn't work in this yet. And I know it's not a faulty [if] or an [event] not launching, since the red "dazzled" text from the [unstore_unit] is shown... This is some epic code, damn!

It's longer that way, but jsut so we are clear on how I did the whole thing, I'm supplying you with my entire code, not just with a fraction I suspect might not work.

Another failed attempt at Dazzle:

Code: Select all

############################

#define WEAPON_SPECIAL_DAZZLE

   [dummy]
      id=dazzle
      name= _ "dazzle"
      description= _ "Dazzle:
A target hit by a dazzling attack will have its maximum attack accuracy set 50% no matter what until the next turn, as if anything it attacked were on at least 50% defense terrain."
   [/dummy]

[/specials]
[/attack]

    [event]
        name=attacker hits
        first_time_only=no

        [filter_attack]
            special=dazzle
        [/filter_attack]

	[store_unit]
	  [filter]
	    x,y=$x2,$y2
	  [/filter]
	variable=todazzle
	kill=no
	[/store_unit]
	[fire_event]
	  name=letsdazzle
	[/fire_event]
    [/event]

    [event]
        name=defender hits
        first_time_only=no

        [filter_second_attack]
            special=dazzle
        [/filter_second_attack]

	[store_unit]
	  [filter]
	    x,y=$x1,$y1
	  [/filter]
	variable=todazzle
	kill=no
	[/store_unit]
	[fire_event]
	  name=letsdazzle
	[/fire_event]
    [/event]

    [event]
	name=letsdazzle
	first_time_only=no

	[if]
	  [have_unit]
	    find_in=todazzle
	    [not]
	      ability=dazzled
	    [/not]
	  [/have_unit]

	[then]
	[object]
	silent=yes
	  [filter]
	    find_in=todazzle
	    [not]
	      ability=dazzled
	    [/not]
	  [/filter]

	    [effect]
	      apply_to=image_mod
		replace="CS(150,150,200)"
	    [/effect]

            {FOREACH todazzle.attack i}
		[effect]
		  apply_to=attack
		    name=attack[$i]
		    remove_specials=dazzled
		[/effect]
		[effect]
		  apply_to=attack
		    name=attack[$i]
		    [set_specials]
			mode=append
			[specials]
			  {WEAPON_SPECIAL_DAZZLED}
			[/specials]
		    [/set_specials]
		[/effect]
	    {NEXT i}
	[/object]

		[set_variable]
		  name=todazzle.variables.dazzled_turn
		  value=$turn_number
		[/set_variable]
		[set_variable]
		  name=todazzle.variables.dazzled_side_turn
		  value=$side_turn
		[/set_variable]

	    [unstore_unit]
		variable=todazzle
		{COLOR_HARM}
		text= _ "dazzled"
		find_vacant=no
	    [/unstore_unit]

	[/then]
	[/if]
	{CLEAR_VARIABLE todazzle}
	[/event]
[+attack]
[+specials]
#enddef

#################################

#define WEAPON_SPECIAL_DAZZLED

    [chance_to_hit]
	id=dazzled
	name= _ "dazzled"
	description= _ "Dazzled:
Still feeling dizzy from a blinding flash of light, this unit's chances to hit will be set to a maximum of 50% until a whole turn has passed. It will then vanish by itself afterwards."

	value=50
	[filter_base_value]
	  greater_than=50
	[/filter_base_value]
    [/chance_to_hit]

#enddef

###################################

[markm]

All the descriptions of slow that I have read all seem to agree that the slowed unit loses the slow effect when it ends a turn.

I have even seen suggestions for more-complex schemes, but your complex scheme maybe indicates part of why such schemes have not been accepted.

Can you live with a dazzle effect that only lasts as long as slow does? Or do you need it to last some arbitrary number of turns?

If you end it at end of the unit's turn no counting of how many turns it has been is needed. Just make removing it be part of turn end for all units all the time. Maybe no need to even check if is there if removing it is faster than checking first that it is present.

-MarkM-

[fog_of_gold]

[...]- How should I test the turn number so the vanishes? An [event] somewhere, like in the [era] tag? Or should I use a [then] and [removeitem] subtag in that [object]? If so, does the [then] need to be enclosed in a [if]?

I'm not sure what you are asking here. I'll answer it the way I understood your question: If you want to remove the effect, use [object], [effect] and remove_specials=dazzled together with apply_to=attack.

- Won't the variables (second_unit.variables.dazzled_turn) be overwritten if more units are dazzled before the effect has ended for that one? Or are they closely associated with the unit?

If you unstore xx and set xx.variables.yy=4, then yy is directly bound to the unit xx. You may clear now xx and with it yy. It's also possible to store the unit in aa and aa.variables.yy will instantly be 4.

Still, if the verification event is somewhere else, how will the game differenciate between a bunch of "second_unit"s?

There are non bunches of second units so the game haven't to differenciate between them.

And if it's not somewhere else, it will only trigger whe the event is launched (ie. when a unit hits another with a Dazzle attack), no? Or is this meant to not actually be in an event?

I'm sure what "it" means, in your first sentence. But hopefully this sentence will answer your question: "second_unit" and other default variables are stored just before they are needed.

- Maybe I could just use the "duration=" within the object? Does this support the key "turn" or something like that? It mentions "level", but there's no alternative...

That's possible in Future.

- Also, I'll need some kind of filter to apply this to every attack. I guess I'll stick to my {FOREACH macro, right?

Nope. Since [effect] is also the filter, you need to put the stuff of the filter here. And if the filterpart is empty, then there's an empty filter and everything (of this unit) will match the filter.

I'm really sorry for all these questions :S

Don't care.

The [object] idea is good, but I still have trouble picturing how I'll get this done with about a hundred variables to test the turns. And now I don't know where I'd place my turn testing event anymore . Unless I fusion your [object] idea with my previous one, but it's a load of tedious work...[...]

You'll just need an object:

Code: Select all

[object]
  silent=yes
  [filter]
    [filter_wml]
      variables.turn_dazzled=$($turn_number-1)
    [/filter_wml]
  [/filter]
  [effect]
    apply_to=just_redo_everything
  [/effect]
[/object]

And I'm not sure how it makes that much work.

I decided that even if I was not sure how I'd make the effect vanish yet (I thought maybe of an event in the weapon special), I'd at least try to make the object and let it be applied. I'm currently trying with your [object] tag. Ok, maybe the way I wrote the part about applying the weapon special to the attack is dubious, but I figured the color shift whould at least take place! I,ve tried lots of things: with and without the quotes, with filters in each effect, different ways to write a bunch of stuff... I've not figured what doesn't work in this yet. And I know it's not a faulty [if] or an [event] not launching, since the red "dazzled" text from the [unstore_unit] is shown... This is some epic code, damn!

It's longer that way, but jsut so we are clear on how I did the whole thing, I'm supplying you with my entire code, not just with a fraction I suspect might not work.

Another failed attempt at Dazzle:

Code: Select all

############################

#define WEAPON_SPECIAL_DAZZLE

   [dummy]
      id=dazzle
      name= _ "dazzle"
      description= _ "Dazzle:
A target hit by a dazzling attack will have its maximum attack accuracy set 50% no matter what until the next turn, as if anything it attacked were on at least 50% defense terrain."
   [/dummy]

[/specials]
[/attack]

    [event]
        name=attacker hits
        first_time_only=no

        [filter_attack]
            special=dazzle
        [/filter_attack]

	[store_unit]
	  [filter]
	    x,y=$x2,$y2
	  [/filter]
	variable=todazzle
	kill=no
	[/store_unit]
	[fire_event]
	  name=letsdazzle
	[/fire_event]
    [/event]

    [event]
        name=defender hits
        first_time_only=no

        [filter_second_attack]
            special=dazzle
        [/filter_second_attack]

	[store_unit]
	  [filter]
	    x,y=$x1,$y1
	  [/filter]
	variable=todazzle
	kill=no
	[/store_unit]
	[fire_event]
	  name=letsdazzle
	[/fire_event]
    [/event]

    [event]
	name=letsdazzle
	first_time_only=no

	[if]
	  [have_unit]
	    find_in=todazzle
	    [not]
	      ability=dazzled
	    [/not]
	  [/have_unit]

	[then]
	[object]
	silent=yes
	  [filter]
	    find_in=todazzle
	    [not]
	      ability=dazzled
	    [/not]
	  [/filter]

	    [effect]
	      apply_to=image_mod
		replace="CS(150,150,200)"
	    [/effect]

            {FOREACH todazzle.attack i}
		[effect]
		  apply_to=attack
		    name=attack[$i]
		    remove_specials=dazzled
		[/effect]
		[effect]
		  apply_to=attack
		    name=attack[$i]
		    [set_specials]
			mode=append
			[specials]
			  {WEAPON_SPECIAL_DAZZLED}
			[/specials]
		    [/set_specials]
		[/effect]
	    {NEXT i}
	[/object]

		[set_variable]
		  name=todazzle.variables.dazzled_turn
		  value=$turn_number
		[/set_variable]
		[set_variable]
		  name=todazzle.variables.dazzled_side_turn
		  value=$side_turn
		[/set_variable]

	    [unstore_unit]
		variable=todazzle
		{COLOR_HARM}
		text= _ "dazzled"
		find_vacant=no
	    [/unstore_unit]

	[/then]
	[/if]
	{CLEAR_VARIABLE todazzle}
	[/event]
[+attack]
[+specials]
#enddef

#################################

#define WEAPON_SPECIAL_DAZZLED

    [chance_to_hit]
	id=dazzled
	name= _ "dazzled"
	description= _ "Dazzled:
Still feeling dizzy from a blinding flash of light, this unit's chances to hit will be set to a maximum of 50% until a whole turn has passed. It will then vanish by itself afterwards."

	value=50
	[filter_base_value]
	  greater_than=50
	[/filter_base_value]
    [/chance_to_hit]

#enddef

###################################

It's better to make a macro instead of an event. It's not just because it's shorter. Also,if you have more than one unit, let's dazzle will be fired more than one time.
Edit:
I founds some of the errors:
1. you may not use {FOREACH} within [object]. It's done automatically anyway.
2. you needn't/mustn't put a special tag within a set_special tag. Just write it in [set_specials]