Random Map Generator Crash

[Mabuse]

Random Map Generator Crash

When i use Random Maps, sometimes it crashes on Maps creation.
It happens with default map generator, on very big maps, especially when setting mountain very high and clicking often on "create new map".

But more often with custom Maps Genrator, as well more likely on big Maps and repeated generation.
Any Idea why that is? I feel like it should not happen.

May PC is pretty solid, so it should not be hardware related like too low on memory or something.
Is it long known and just dealt with?

[dwarftough]

Does it crash the whole game or just shows an error? More information on how you get the result and what you see would be nice

[gnombat]

I tried it myself just moving the sliders for "Width", "Height", "Number of Hills", and "Max Hill Size" all the way to the right, and when I clicked "Close" it crashed immediately.

It didn't display any message, but there is this message in the log:

Code: Select all

error mapgen: No castle location found, for 2 players aborting.

[Mabuse]

Does it crash the whole game or just shows an error? More information on how you get the result and what you see would be nice

crash the whole game to desktop, like it cannot handle too much of height iterations or whatever, causing an overflow

I tried it myself just moving the sliders for "Width", "Height", "Number of Hills", and "Max Hill Size" all the way to the right, and when I clicked "Close" it crashed immediately.

It didn't display any message, but there is this message in the log:

Code: Select all

error mapgen: No castle location found, for 2 players aborting.

the error massage i didnt check so far, but yes, crashes immediatly, sometimes after clicking a bit generating another map.

now i would have thought that this is something well known, as it happened also in 1.16 version (and most likely earlier, but i didnt care too much about random map genration before), i just decided to ask why it is, because it kinda annoys me, to crash to desktop every time (as said especially it happens also with well known random map generators like URM, and even more then). big maps, big mountains seem to crash generator.

and i also once tried generating maps for SXRPG (quite some years ago) but got to a point where it crashed all the time, and i didnt know what the exact reason was, maybe code, maybe generator, so i gave up on this one.

[gnombat]

It seems like this is issue #1415 although that is marked as "Closed".

[Soliton]

Cannot reproduce a crash with the method mentioned by gnombat. I do get the mapgen error in the log but wesnoth does not crash and shows no map instead.

Would be good to get a backtrace from someone that can reproduce the issue.

[gnombat]

Cannot reproduce a crash with the method mentioned by gnombat. I do get the mapgen error in the log but wesnoth does not crash and shows no map instead.

Try this:

Code: Select all

ulimit -s 512

It will almost certainly crash after that.

[Soliton]

Ok, so generate_river_internal recurses a bit too much so you can run out of stack space. Looks like it recurses for every river hex. We should rewrite that to tail call recursion or really no recursion.