[solved] Weapon proxy

[ZombieKnight]

Hi,
I'd like to give a unit new weapon and the documentation says I need a weapon proxy for that.
However, it doesn't tell how to create a new weapon proxy...
So... do you know, how to create a new weapon proxy?

[Celtic_Minstrel]

I'm not sure what you're reading, but this is what the documentation says on the topic:

An attack can be replaced wholesale, or appended by indexing at the list's length and assigning.

That implies you can add a new attack to the end with code like the following:

Code: Select all

unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 }

A weapon proxy refers to the objects in the unit.attacks pseudo-array. You can also make one using wesnoth.units.create_weapon if for some reason you need a weapon proxy that doesn't belong to any unit.

[ZombieKnight]

Thanks a lot!
It wasn't sad clearly how syntax of weapon_proxy looks like when creating.

[white_haired_uncle]

That implies you can add a new attack to the end with code like the following:

Code: Select all

unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 }

Wouldn't that replace the last one? I'd think for lua you'd need #unit.attacks+1

[Celtic_Minstrel]

Good question. I'm not actually sure. The documentation clearly says indexing at the length, but it could be wrong. It makes sense from a Lua standpoint that you'd need to add 1 to append, but it's not a true array so I'd have to check the code (or try it out) to be certain.

[ZombieKnight]

Yup #attacks + 1.
Thanks once again ^^

[ZombieKnight]

... just do I have to set it icon?
it's created just for wesnoth.simulate_combat(attacker,attacking_weapon_index, defender, #defender.attacks)
And it's supposed to be empty (since it doesn't have option for no_retalation)
...
Are those errors ok?
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).
20240529 15:54:02 error filesystem: Illegal path 'icons/profiles/.png' (blacklisted filename).

[Ravana]

I'm not sure what you're reading, but this is what the documentation says on the topic:

An attack can be replaced wholesale, or appended by indexing at the list's length and assigning.

That implies you can add a new attack to the end with code like the following:

Code: Select all

unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 }

A weapon proxy refers to the objects in the unit.attacks pseudo-array. You can also make one using wesnoth.units.create_weapon if for some reason you need a weapon proxy that doesn't belong to any unit.

wesnoth.units.create_weapon is not documented.

I would expect unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 } be error, since it gives table not weapon. While valid use would be unit.attacks[#unit.attacks] = wesnoth.units.create_weapon{ name = 'new attack', range = 'melee', damage = 4, number = 3 }

[ZombieKnight]

I would expect unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 } be error, since it gives table not weapon.

As surprising as it is... it works actually
(I use empty {}, but { name = 'new attack', range = 'melee', damage = 4, number = 3 } works fine)

Code: Select all

defender.attacks[(#defender.attacks + 1)] = {}
local table1, table2, table3, table4 =wesnoth.simulate_combat(attacker,attacking_weapon_index, defender, #defender.attacks)
defender.attacks[#defender.attacks] = nil

[Celtic_Minstrel]

wesnoth.units.create_weapon is not documented.

I noticed that too right after bringing it up.

I would expect unit.attacks[#unit.attacks] = { name = 'new attack', range = 'melee', damage = 4, number = 3 } be error, since it gives table not weapon. While valid use would be unit.attacks[#unit.attacks] = wesnoth.units.create_weapon{ name = 'new attack', range = 'melee', damage = 4, number = 3 }

Hmm, that's a valid expectation, I guess. Both ways work though. I'm not sure if there's any actual difference between them.