ellipse=no

[Helmet]

This code will remove the ellipse...

It works great! I like the id, and how removing the object to make the ellipse come back, but I especially like this part:

Code: Select all

		[filter_location]
			formula=keep
		[/filter_location]

No keeping track of x,y, which is great, because I often move things around on a map.

[Toranks]

This code will remove the ellipse...

It works great! I like the id, and how removing the object to make the ellipse come back, but I especially like this part:

Code: Select all

		[filter_location]
			formula=keep
		[/filter_location]

No keeping track of x,y, which is great, because I often move things around on a map.

You can filter by type of terrain too, In case you only want to remove the ellipse in winter keeps, but not in summer keeps, for example

[Helmet]

You can filter by type of terrain too, In case you only want to remove the ellipse in winter keeps, but not in summer keeps, for example

I tried filtering by type of terrain and it worked. Now the Snowman can have an ellipse in non-frozen enemy keeps, if I want to do that.

Thanks, Toranks.

Code: Select all

    [filter]
		id=MyLeader
		[filter_location]
            		terrain=Kha #   		<--  Snowy Human Castle Keep
			#formula=keep
		[/filter_location]
	[/filter]

[Celtic_Minstrel]

Does terrain=K*a work? If it does, that would match any snowy keep, not just a human one. (Assuming the terrain codes are consistently assigned.) For example, a snowy encampment, or a snowy orcish keep, or a snowy elven keep.

If that doesn't work you would have to list out all the possibilities, like terrain=Kha,Kea,Koa,Kva, etc.

[Atreides]

Does terrain=K*a work? If it does, that would match any snowy keep, not just a human one. (Assuming the terrain codes are consistently assigned.) For example, a snowy encampment, or a snowy orcish keep, or a snowy elven keep.

If that doesn't work you would have to list out all the possibilities, like terrain=Kha,Kea,Koa,Kva, etc.

I've run into this with the Lonely Era!
This was my solution:

Code: Select all

            [filter_location]
                terrain={SNOW_ICE_TERRAIN}
                # terrain=Aa,Aa^*,Ha,Ms,Ms^*,Ai,Rrc^Vhca,Ha^Vhha,K*a,C*a last 2 are wrong, wildcard doesn't work like that
            [/filter_location]

Code: Select all

#define SNOW_ICE_TERRAIN
Rra^*,A*^*,*^Esa,*^Feta,*^Fpa,*^Fda,*^Fma,Ha*^*,Ms*^*,*^Voa,*^Vea,*^Vha,*^Vhca,*^Vhha,*^Vca,*^Vla,*^Vaa,Cea^*,Coa^*,Cha^*,Cva^*,Cfa^*,Kea^*,Koa^*,Kha^*,Kva^*,Kfa^* #enddef

The commented out bit was the original.

[Helmet]

Does terrain=K*a work? If it does, that would match any snowy keep, not just a human one.

Thanks. terrain=K*a does work!

This was my solution...

Nifty solution. Thanks for sharing it!

[Toranks]

This is my version:
terrain=A*,Ms*,Ha*,Cea^*,Coa^*,Cha^*,Cva^*,Cfa^*,Kea^*,Koa^*,Kha^*,Kva^*,Kfa^*,Rra^*,*^Esa,*^Fpa,*^Feta,*^Fda,*^Fma,*^Voa,*^Vea,*^Vha,*^Vhca,*^Vhha,*^Vca,*^Vla,*^Vaa

[Atreides]

Does terrain=K*a work? If it does, that would match any snowy keep, not just a human one.

Thanks. terrain=K*a does work!

It does??? I did this under 1.14 where it definitely did not work. Now I wonder if this was an undocumented change in 1.16.

[Helmet]

It does??? I did this under 1.14 where it definitely did not work. Now I wonder if this was an undocumented change in 1.16.

Maybe check the document for 1.17 -- that's what I'm using.

[Helmet]

[*]I added an ID to your [object] tag so it can be removed later.
[*]Instead of adding an object to put the ellipse back, this version removes the object that made the ellipse go away. using [remove_object]. Since the default state is to have an ellipse (because the unit type definition says so), that'll cause the ellipse to come back.
[/list]

I noticed something unexpected.

When my leader moves out of his keep, he loses his Leadership ability. The ability was given at unit creation within side WML.

Code: Select all

	...
        color=white
        [abilities]
            {ABILITY_LEADERSHIP}
        [/abilities]
        income=-2
        ...

I also noticed that undo stops working when objects are being given or removed.

I read about [allow_undo] in the Wiki. Is there a downside to using [allow_undo] in this situation, to allow the Leader's move on/off his keep to be undone? It seems safe to me, but I thought I should ask. Also, how does one use [allow_undo]?

[Atreides]

It does??? I did this under 1.14 where it definitely did not work. Now I wonder if this was an undocumented change in 1.16.

Maybe check the document for 1.17 -- that's what I'm using.

Ah, that seems to explain it. By coincidence I discovered last night that in 1.16

Code: Select all

terrain=*C*,*K*

is equal to matching ALL terrain.

Looks like an upgrade is coming in 1.18 if the beta version works differently.

[Celtic_Minstrel]

I haven't heard anything about changes to how terrain globs work, but it's possible something was changed that I don't know about, or even "by accident".

When my leader moves out of his keep, he loses his Leadership ability. The ability was given at unit creation within side WML.

Code: Select all

	...
        color=white
        [abilities]
            {ABILITY_LEADERSHIP}
        [/abilities]
        income=-2
        ...

You shouldn't add arbitrary things in unit WML like that, because they will disappear whenever the unit is rebuilt. Adding and removing an object is just one way that could happen – he would have also lost the ability if he simply levelled up (assuming he has an advancement).

(Note: The [side] tag accepts unit WML which will describe the side leader, so even though it's in the [side] tag, that code is still unit WML, not side WML.)

The correct way to add an ability in unit WML is to format it as an object:

Code: Select all

[modifications]
	[object]
		[effect]
			apply_to=new_ability
			{ABILITY_LEADERSHIP}
		[/effect]
	[/object]
[/modifications]

[Helmet]

The correct way to add an ability in unit WML is to...

Thanks for the explanation. I have a tendency to think that if something works, then it must be fine, but recently most of my mistakes have been writing code that seems to work, but actually causes weird problems that are difficult for me to debug.