Wesnoth 1.0.3 ?

[gnombat]

One last quick question. I didn't find any instructions to compile from the gitub repository other than with cmake, which is only usable from 1.6.
I tried these commands found on the internet :

Code: Select all

autoheader && aclocal && libtoolize --ltdl --copy --force && automake --add-missing --copy && autoconf

Instead of that, you should be able to just run

Code: Select all

./autogen.sh

[alberic89]

Thank you.
I have tried to compile the 1.2.8 with your patch, and I have no major error (just warnings).
But, when I have executed the wesnoth executable, I have the error :

Code: Select all

Battle for Wesnoth v1.2.8
Started on Mon Oct 31 18:48:14 2022

started game: 791183469
Checking video mode: 1600x900x16...
16
setting mode to 1600x900x16
locale could not be determined; defaulting to system locale
set locale to 
set locale to 
No [language] block found in english.cfg
could not initialize the language
exiting with code 0

And after accidentally extracting the archive again on the existing files, the game started.
A quick comparison with the game provided by the windows exe tells me that my build is extremely buggy.
I will test with the version of the branch and I tell you again

[gnombat]

Here is a better patch for Wesnoth 1.2. This was not written by me, it comes from a poster at the linuxfr.org. Note that the linuxfr.org forum seems to mangle the white space a bit (converting tabs to spaces) - these are fixed in the attachment. It says it is for 1.2.8 but it also applies cleanly to the latest commit on the 1.2 branch.

wesnoth-1.2-better.patch

(4.62 KiB) Downloaded 94 times

[alberic89]

The patch is corrupted, but if you cut and paste directly into the file the section that doesn't pass correctly, it's fine.
Once the patch is applied and compiled, you get the error at compile time:

Spoiler:

Code: Select all

make[2]: Entering directory '/home/pi/wesnoth-1.2.8/src'
depbase=`echo server/game.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
g++ -DHAVE_CONFIG_H -I. -I..   -I/usr/include/freetype2 -I/usr/include/libpng16 -I ./sdl_ttf -I../intl -I../intl -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -DWESNOTH_PATH=\"/usr/local/share/wesnoth\" -DLOCALEDIR=\"translations\" -DHAS_RELATIVE_LOCALEDIR=1 -DFIFODIR=\"/usr/local/var/run/wesnothd\"  -O2 -W -Wall -ansi  -D_X11    -MT server/game.o -MD -MP -MF $depbase.Tpo -c -o server/game.o server/game.cpp &&\
mv -f $depbase.Tpo $depbase.Po
server/game.cpp: In member function ‘bool game::is_observer(network::connection) const’:
server/game.cpp:53:25: error: no matching function for call to ‘find(std::vector<int>::const_iterator, std::vector<int>::const_iterator, network::connection&)’
   53 |         return std::find(observers_.begin(),observers_.end(),player) != observers_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/12/bits/locale_facets.h:48,
                 from /usr/include/c++/12/bits/basic_ios.h:37,
                 from /usr/include/c++/12/ios:44,
                 from /usr/include/c++/12/istream:38,
                 from /usr/include/c++/12/sstream:38,
                 from server/../util.hpp:18,
                 from server/game.cpp:18:
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:53:25: note:   ‘__gnu_cxx::__normal_iterator<const int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
   53 |         return std::find(observers_.begin(),observers_.end(),player) != observers_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
server/game.cpp: In member function ‘bool game::is_muted_observer(network::connection) const’:
server/game.cpp:58:25: error: no matching function for call to ‘find(std::vector<int>::const_iterator, std::vector<int>::const_iterator, network::connection&)’
   58 |         return std::find(muted_observers_.begin(), muted_observers_.end(), player) != muted_observers_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:58:25: note:   ‘__gnu_cxx::__normal_iterator<const int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
   58 |         return std::find(muted_observers_.begin(), muted_observers_.end(), player) != muted_observers_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
server/game.cpp: In member function ‘bool game::is_player(network::connection) const’:
server/game.cpp:63:25: error: no matching function for call to ‘find(std::vector<int>::const_iterator, std::vector<int>::const_iterator, network::connection&)’
   63 |         return std::find(players_.begin(),players_.end(),player) != players_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:63:25: note:   ‘__gnu_cxx::__normal_iterator<const int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
   63 |         return std::find(players_.begin(),players_.end(),player) != players_.end();
      |                ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
server/game.cpp: In member function ‘void game::add_player(network::connection, bool)’:
server/game.cpp:652:21: error: no matching function for call to ‘find(std::vector<int>::iterator, std::vector<int>::iterator, network::connection&)’
  652 |         if(std::find(users.begin(),users.end(),player) != users.end()) {
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:652:21: note:   ‘__gnu_cxx::__normal_iterator<int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
  652 |         if(std::find(users.begin(),users.end(),player) != users.end()) {
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
server/game.cpp: In member function ‘void game::remove_player(network::connection, bool)’:
server/game.cpp:704:61: error: no matching function for call to ‘find(std::vector<int>::iterator, std::vector<int>::iterator, network::connection&)’
  704 |                 const user_vector::iterator itor = std::find(players_.begin(),players_.end(),player);
      |                                                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:704:61: note:   ‘__gnu_cxx::__normal_iterator<int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
  704 |                 const user_vector::iterator itor = std::find(players_.begin(),players_.end(),player);
      |                                                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
server/game.cpp:711:61: error: no matching function for call to ‘find(std::vector<int>::iterator, std::vector<int>::iterator, network::connection&)’
  711 |                 const user_vector::iterator itor = std::find(observers_.begin(),observers_.end(),player);
      |                                                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  434 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/12/bits/streambuf_iterator.h:434:5: note:   template argument deduction/substitution failed:
server/game.cpp:711:61: note:   ‘__gnu_cxx::__normal_iterator<int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
  711 |                 const user_vector::iterator itor = std::find(observers_.begin(),observers_.end(),player);
      |                                                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1428: server/game.o] Error 1
make[2]: Leaving directory '/home/pi/wesnoth-1.2.8/src'
make[1]: *** [Makefile:536: all-recursive] Error 1
make[1]: Leaving directory '/home/pi/wesnoth-1.2.8'
make: *** [Makefile:442: all] Error 2

or in asciinema for colors : https://asciinema.org/a/534202

[gnombat]

Did you run ./configure --enable-server? It looks like it's trying to compile the server.

[alberic89]

yes, I have enabled a lot of options. With no option, the game compile and run, but it is very bugged. Resolve all warning can maybe resolve the bugs.

[alberic89]

I finally succeeded in compiling thanks to the patch below, the game runs on arm32 with graphical interface. The only major problem I found is the lack of translation, see the compilation log: https://asciinema.org/a/537084?t=23&autoplay=0
I put the patch here and add it to the source code with a PR.
If someone has an idea to solve the problem of translations, don't hesitate.

[gnombat]

If you are running the program from the installation directory, it looks like you have to specify the path on the command line in order to get the translations. For example, instead of this ...

Code: Select all

./src/wesnoth

... run this:

Code: Select all

./src/wesnoth .

Presumably, installing the program with make install would work too, but I did not try that.

[alberic89]

Yes, use make install work, I have tried.
The patch was merged, you can download and compile now from the 1.2 branch.

[lea]

Given that's now 16 years ago, I doubt anyone remembers the answer to that. The full history with tags is available via the public git repo however.

There isn't actually a tag for version 1.0.3, though.

... ... ...

AFAIK there is no changelog for version 1.0.3 either, at least could not find it in changelog.md file on wesnoth's github (https://github.com/wesnoth/wesnoth/blob ... angelog.md)

same for version 1.0.3a which also contains two extra campaigns that seem to be unique to this version
EDIT: these two campaigns apparently were available on add-ons server for wesnoth 1.x

here's my attempt to ask about it: changelogs for Wesnoth 1.0.3 and 1.0.3a?