[firststrike] special with apply_to=opponent crashes Wesnoth 1.16.x

[lea]

if unit with "last strike" ([firststrike] special with apply_to=opponent, on any of its attacks) is targeted by other unit for attack then Wesnoth hangs or (according to BlakerBR) crashes to desktop without writing anything to .log file

reproduces on clean install Wesnoth 1.16.2 and 1.16.0

example of workaround attached
EDIT: see newfrenchy83's suggestion below for more straightforward workaround

[newfrenchy83]

have you addes active_on=offense for fix that?

[newfrenchy83]

hah, in 1.16, it's not firstrike with apply_to=opponent who is used but another code pulled to opponent.

[newfrenchy83]

bugs reorted in https://github.com/wesnoth/wesnoth/issues/6575.

[lea]

have you addes active_on=offense for fix that?

this workaround seems to work as well and is a lot less complicated, thanks for suggestion

[newfrenchy83]

have you addes active_on=offense for fix that?

this workaround seems to work as well and is a lot less complicated, thanks for suggestion

But it's half resove the issue, this because i had pul this https://github.com/wesnoth/wesnoth/pull ... -918286954 PR for fix bug

[lea]

But it's half resove the issue, this because i had pul this https://github.com/wesnoth/wesnoth/pull ... -918286954 PR for fix bug

is it going to be included in upcoming wesnoth 1.16.3?

[newfrenchy83]

But it's half resove the issue, this because i had pul this https://github.com/wesnoth/wesnoth/pull ... -918286954 PR for fix bug

is it going to be included in upcoming wesnoth 1.16.3?

i don't know, but i want other thing, if two user of laststrike fight themselves, who give firststrike, the attacker or the defender?

[lea]

i don't know, but i want other thing, if two user of laststrike fight themselves, who give firststrike, the attacker or the defender?

indeed, have to filter it out like this:

Code: Select all

        [filter_opponent]
            [filter_weapon]
                [not]
                    special=delayed
                [/not]
            [/filter_weapon]
        [/filter_opponent]

[newfrenchy83]

craches fixed for 1.16.3 version

[lea]

craches fixed for 1.16.3 version

when will it be released?
https://www.wesnoth.org/ still offers 1.16.2 for download

[newfrenchy83]

i don't know

[Lord-Knightmare]

craches fixed for 1.16.3 version

when will it be released?
https://www.wesnoth.org/ still offers 1.16.2 for download

Not sure. Maybe 17/04/22.

[octalot]

1.16.3 is scheduled for release on 8th May, and 1.17.3 is scheduled for release tonight.