Problem with custom recruiting

[Xardas666]

Hello. I have created macro for custom recruiting pattern. It should work that I'm recruiting 3xlvl1, 2xlvl2, 1xlvl3 units. It's broken. For example when I recruit 3 lvl1 paladins and then recruit any other unit the paladins disappear from recruit list. Can anyone tell me how to fix it please?

Spoiler:

Code: Select all

#textdomain wesnoth-wesgothic

#define RECRUIT_PAIR UNIT_ONE UNIT_TWO NUMBER
    [event]
        name=recruit
        first_time_only=no
        [filter]
            type={UNIT_ONE}
        [/filter]
        [set_variable]
            name={UNIT_ONE}_recruited_$side_number
            add=1
        [/set_variable]
        [if]
            [variable]
                name={UNIT_ONE}_recruited_$side_number
                equals={NUMBER}
            [/variable]
            [then]
                [set_variable]
                    name={UNIT_ONE}_recruited_$side_number
                    value=0
                [/set_variable]
                [disallow_recruit]
                    type={UNIT_ONE}
                    side=$side_number
                [/disallow_recruit]
                [disallow_extra_recruit]
                    extra_recruit={UNIT_ONE}
                    side=$side_number
                [/disallow_extra_recruit]
                [set_extra_recruit]
                    extra_recruit={UNIT_TWO}
                    side=$side_number
                [/set_extra_recruit]
            [/then]
        [/if]
    [/event]
#enddef

#define ZG_WCII

{RECRUIT_PAIR myr_l1_city_guard_sword myr_l2_city_guard_sword 3}
{RECRUIT_PAIR myr_l2_city_guard_sword myr_l3_city_guard_sword 2}
{RECRUIT_PAIR myr_l3_city_guard_sword myr_l1_city_guard_sword 1}

{RECRUIT_PAIR myr_l1_city_guard_crossbow myr_l2_city_guard_crossbow 3}
{RECRUIT_PAIR myr_l2_city_guard_crossbow myr_l3_city_guard_crossbow 2}
{RECRUIT_PAIR myr_l3_city_guard_crossbow myr_l1_city_guard_crossbow 1}

{RECRUIT_PAIR myr_l1_paladin myr_l2_paladin 3}
{RECRUIT_PAIR myr_l2_paladin myr_l3_paladin 2}
{RECRUIT_PAIR myr_l3_paladin myr_l1_paladin 1}

{RECRUIT_PAIR myr_l1_fire_mage myr_l2_fire_mage 3}
{RECRUIT_PAIR myr_l2_fire_mage myr_l3_fire_mage 2}
{RECRUIT_PAIR myr_l3_fire_mage myr_l1_fire_mage 1}

{RECRUIT_PAIR myr_l1_soldier myr_l2_soldier 3}
{RECRUIT_PAIR myr_l2_soldier myr_l3_soldier 2}
{RECRUIT_PAIR myr_l3_soldier myr_l1_soldier 1}

{RECRUIT_PAIR myr_l1_scout myr_l2_scout 3}
{RECRUIT_PAIR myr_l2_scout myr_l3_scout 2}
{RECRUIT_PAIR myr_l3_scout myr_l1_scout 1}

{RECRUIT_PAIR myr_l0_citizen myr_l0_farmer 3}
{RECRUIT_PAIR myr_l0_farmer myr_l0_novice 2}
{RECRUIT_PAIR myr_l0_novice myr_l0_citizen 1}

{RECRUIT_PAIR ara_l1_runner ara_l2_runner 3}
{RECRUIT_PAIR ara_l2_runner ara_l3_runner 2}
{RECRUIT_PAIR ara_l3_runner ara_l1_runner 1}

{RECRUIT_PAIR ara_l1_seeker ara_l2_seeker 3}
{RECRUIT_PAIR ara_l2_seeker ara_l3_seeker 2}
{RECRUIT_PAIR ara_l3_seeker ara_l1_seeker 1}

{RECRUIT_PAIR ara_l1_fencer ara_l2_fencer 3}
{RECRUIT_PAIR ara_l2_fencer ara_l3_fencer 2}
{RECRUIT_PAIR ara_l3_fencer ara_l1_fencer 1}

{RECRUIT_PAIR ara_l1_mercenary ara_l2_mercenary 3}
{RECRUIT_PAIR ara_l2_mercenary ara_l3_mercenary 2}
{RECRUIT_PAIR ara_l3_mercenary ara_l1_mercenary 1}

{RECRUIT_PAIR ara_l1_merchant ara_l2_merchant 3}
{RECRUIT_PAIR ara_l2_merchant ara_l3_merchant 2}
{RECRUIT_PAIR ara_l3_merchant ara_l1_merchant 1}

{RECRUIT_PAIR ara_l1_killer ara_l2_killer 3}
{RECRUIT_PAIR ara_l2_killer ara_l3_killer 2}
{RECRUIT_PAIR ara_l3_killer ara_l1_killer 1}

{RECRUIT_PAIR ara_l0_sailor ara_l0_merchant 3}
{RECRUIT_PAIR ara_l0_merchant ara_l0_guide 2}
{RECRUIT_PAIR ara_l0_guide ara_l0_sailor 1}

#enddef

[vghetto]

Replace [set_extra_recruit] with [allow_extra_recruit]. See if that helps.

[Lord-Knightmare]

According to your posted code, I think that's exactly what will happen. You recruited 3 level 1s and after that the recruit disappears from the list. You did not add any code at all to restore the recruitlist after the number {NUMBER} have been met. As in no [allow_recruit] code is present here.

[Xardas666]

Replace [set_extra_recruit] with [allow_extra_recruit]. See if that helps.

Yes. It's working now. Thanks!