Soulless custom advancement not working 1.19

[WarDead0]

System: Windows 10

Spoiler:

Edition Windows 10 Pro
Version 22H2
Installed on ‎9/‎11/‎2022
OS Build 19045.6466

Wesnoth 1.19.25 en-AU (system default)

Spoiler:

The Battle for Wesnoth version 1.19.25 x86_64
Running on Microsoft Windows 10 22H2 (10.0.19045) x86_64
Distribution channel: itch

Game paths
==========

Data dir: C:\Program Files\Battle for Wesnoth 1.19 beta
User data dir: C:\Users\USER\Documents\My Games\Wesnoth1.19
Saves dir: C:\Users\USER\Documents\My Games\Wesnoth1.19\sync\saves
Add-ons dir: C:\Users\USER\Documents\My Games\Wesnoth1.19\data\add-ons
Cache dir: C:\Users\USER\Documents\My Games\Wesnoth1.19\cache
Logs dir: C:\Users\USER\Documents\My Games\Wesnoth1.19\logs

Libraries
=========

Boost: 1.91
Lua: 5.4.7
OpenSSL/libcrypto: 3.6.0b-dev (runtime 3.6.0b-dev)
libcurl: 8.20.0 (runtime 8.20.0)
Cairo: 1.18.4 (runtime 1.18.4)
Pango: 1.56.4 (runtime 1.56.4)
SDL: 3.4.8 (runtime 3.4.
SDL_image: 3.4.4 (runtime 3.4.4)
SDL_mixer: 3.2.2 (runtime 3.2.2)

Features
========

Lua console completion: yes
Win32 notifications back end: yes

Current video settings
======================

SDL video drivers: [windows] offscreen dummy
Window size: 1920x1001
Game canvas size: 1920x1001
Final render target size: 1920x1001
Render refresh rate: 60
Screen refresh rate: 60
Content scaling: 1.25
Pixel density: 1
Calculated display scaling: 1.25
Renderer: direct3d11
VSync: off

Current audio settings
======================

SDL audio drivers: [wasapi] directsound disk
Number of channels: 2
Output rate: 44100 Hz
Sample format: signed 32 bit floating point little-endian
Sample size: 4096 bytes

Installed add-ons
=================

Dwarf_Dwarfson_Dwarvenminer: 0.7.0
Era_of_Magic: 4.8.3
Era_of_Magic_Resources: 3.1.2
Legend_of_the_Invincibles_beta: 3.2.8.37g4dc897c
Test: Unknown
The_Bees_Journey: 1.99.2 (Beta 2)
Trader: 1.16.35.4

Providing a modified advancement type for Soulless does not work (just gives default +3hp advancement).

Code: Select all

	[modify_unit_type]
		type="Soulless"
		set_advances_to="Monstrosity,Bone Shooter,Revenant,Necrophage"
		set_experience=90
	[/modify_unit_type]

I have included a test project to demonstrate this. This advancement is used by the popular addon LotI. Other custom advancement lines do not seem to be affected. The help shows changes for 1.19.5 so perhaps this has something to do with the new [variation] changes? I have tried it without the custom unit "Monstrosity" or inserting the 5 line [modify_unit_type] directly in the _main.cfg file.

[WarDead0]

It works if it's in the scenario cfg but not in _main.cfg (like it used to)

[gnombat]

It works if it's in the scenario cfg but not in _main.cfg (like it used to)

It's supposed to be inside one of the tags listed here:

Several toplevel tags are used to define an "add-on module":

• [era] - A multiplayer era
• [campaign] - A campaign, either single-player or multiplayer
• [scenario] - A campaign scenario
• [multiplayer] - A multiplayer scenario
• [test] - A test or demo scenario
• [modification] - A modification that can be selected in the campaign or multiplayer menu
• [resource] - A resource that can be requested by any other add-on module

[WarDead0]

Ok, there was a bug in my demo project, it included the {./extra_advancements.cfg} but then didn't reference the {LOTI_EXTRA_ADVANCEMENT_LINES} defined therein. If I use that it works (where {LOTI_EXTRA_ADVANCEMENT_LINES} is referenced inside [campaign]) like it does for the LotI campaigns.

...so back to LotI as to why it didn't work there (but used to)... (and only for Soulless)...

[WarDead0]

I've updated my demo so that the enemy recruits bats and, guess what, they fail!

If you recruit a Soulless you get a "normal" one and it has the updated advancements but if you plague-kill a bat and advance it to Soulless it does not. The save file here has a recruited Soulless on a village with the advancements available but the bat-based Soulless doesn't. So it doesn't appear to be applied to a [Variation]? The changes for 1.19.5 shows a new [variation] attribute but it does not stipulate it is compulsory so implies that if you supply it that it will only apply to the variations and otherwise it will apply to all variations? In that case it may not be working as intended.

EDIT: I plague-killed a Ruffian and it's (base) Soulless has the advancements available.

[WarDead0]

I have made a bug report on github for this now...
https://github.com/wesnoth/wesnoth/issues/11478

[newfrenchy83]

I have made a bug report on github for this now...
https://github.com/wesnoth/wesnoth/issues/11478

fixed for wesnoth 1.19.27