Creating unit on walkable hexes [Solved]

[ChaosRider]

As in title Im trying to write a code to spawn unit on walkable hex (as long as they are available on map without any other units on it) but it sometimes create it on the wall. I have written all impossible hexes in the list in the code yet it doesnt work as should.

Spoiler:

Code: Select all

	{VARIABLE temp_i 1}
	{VARIABLE temp_k 1}
	[while]
		[variable]
			name=temp_i
			less_than_equal_to=$temp_choose_amount_of_lower_levels
		[/variable]
		[and]
			[variable]
				name=temp_k
				less_than_equal_to=100
			[/variable]
		[/and]
		[do]
			[if]
				[variable]
					name=new_unit_type_to_create
					not_equals=$null
				[/variable]
				[then]	
					[store_map_dimensions]
						variable=temp_map_max
					[/store_map_dimensions]
					{VARIABLE temp_g $temp_map_max.width}
					[if]
						[variable]
							name=temp_map_max.height
							greater_than=$temp_g
						[/variable]
						[then]
							{VARIABLE temp_g $temp_map_max.height}
						[/then]
					[/if]
					{CLEAR_VARIABLE temp_map_max}
					{VARIABLE temp_j 2}
					[while]
						[variable]
							name=temp_j
							less_than_equal_to=$temp_g
						[/variable]
						[and]
							[variable]
								name=temp_out
								equals=$null
							[/variable]
						[/and]
						[do]
							[store_locations]
								x,y=$unit.x,$unit.y
								radius=$temp_j
								[filter_radius]
									[not]
										terrain=Wog,Wo,Wot,Qxu,Qxe,Qxua,Ql,Qlf,Mv,Mm^Xm,Md^Xm,Ms^Xm,Mdd^Xm,Xu,Xuc,Xue,Xur,Xuf,Xos,Xom,Xoi,Xoc,Xoa,Xot,Xof,Xor,Xv,*^Xo,*^Qov,Wog^*,Wo^*,Wot^*,Qxu^*,Qxe^*,Qxua^*,Ql^*,Qlf^*,Mv^*,Xu^*,Xuc^*,Xue^*,Xur^*,Xuf^*,Xos^*,Xom^*,Xoi^*,Xoc^*,Xoa^*,Xot^*,Xof^*,*^V*,*^Do*
									[/not]
								[/filter_radius]
								variable=loc_store
							[/store_locations]
							{VARIABLE temp_h 0}
							[while]
								[variable]
									name=temp_out
									equals=$null
								[/variable]
								[and]
									[variable]
										name=temp_h
										less_than_equal_to=$loc_store.length
									[/variable]
								[/and]
								[do]
									{VARIABLE temp_loc_max $loc_store.length}
									{CLEAR_VARIABLE temp_loc_max}
									{VARIABLE temp_new_x $loc_store[$temp_h].x}
									{VARIABLE temp_new_y $loc_store[$temp_h].y}
									[if]
										[not]
											[have_unit]
												x,y=$temp_new_x,$temp_new_y
											[/have_unit]
										[/not]
										[and]
											[have_location]
												x,y=$temp_new_x,$temp_new_y
												radius=1
												[not]
													terrain=Wog,Wo,Wot,Qxu,Qxe,Qxua,Ql,Qlf,Mv,Mm^Xm,Md^Xm,Ms^Xm,Mdd^Xm,Xu,Xuc,Xue,Xur,Xuf,Xos,Xom,Xoi,Xoc,Xoa,Xot,Xof,Xor,Xv,*^Xo,*^Qov,Wog^*,Wo^*,Wot^*,Qxu^*,Qxe^*,Qxua^*,Ql^*,Qlf^*,Mv^*,Xu^*,Xuc^*,Xue^*,Xur^*,Xuf^*,Xos^*,Xom^*,Xoi^*,Xoc^*,Xoa^*,Xot^*,Xof^*,*^V*,*^Do*
												[/not]
											[/have_location]
										[/and]
										[then]
											{VARIABLE temp_out "on"}
											
											{UNIT $unit.side $new_unit_type_to_create $temp_new_x $temp_new_y ()}
											
											{VARIABLE_OP temp_i add 1}
										[/then]
										[else]
											{VARIABLE_OP temp_h add 1}
										[/else]
									[/if]
								[/do]
							[/while]
							{CLEAR_VARIABLE temp_new_x,temp_new_y,temp_h}
										
							{VARIABLE_OP temp_j add 1}
						[/do]
					[/while]
					{CLEAR_VARIABLE temp_g,temp_out}
				[/then]
			[/if]
			{VARIABLE_OP temp_k add 1}
		[/do]
	[/while]
					
	{CLEAR_VARIABLE temp_i}
	
	{CLEAR_VARIABLE new_unit_type_to_create}

Do you see any wrong lines/bugs?

You could add to Wesnoth next version option to spawn units only on hexes where unit to spawn terrain defense is greater than 0%.

[Ravana]

It is some random mess of code. Just use passable=yes and dont give unit defense where they cant move.

[ChaosRider]

It is some random mess of code. Just use passable=yes and dont give unit defense where they cant move.

One line was required to do what I wanted to. Thx.