Modified Wolrd Conquest - bugs fixing - Wesnoth 1.18

[ChaosRider]

Hello there. At the beginning I would like to say that MWC was working fine in Wesnoth 1.10 but on version 1.18 of Wesnoth it has some bugs.
I put some effort in to it and I found code part that makes error info. I don't see anything wrong with code so maybe someone else will find the reason of the error info.

It screems Lua error but everything is written in WML.

Spoiler:

Code: Select all

			[message]
				message=_"Test 5.9"
			[/message]
	{FOREACH_FROM player 1 I}
		[if]
			[have_unit]
				side=$I
				canrecruit=yes
			[/have_unit]
			[then]
				# each player gets a random second helper from one of their associated factions
				{VARIABLE_OP rand rand 0..1}
				{VARIABLE_OP bonus rand 0..9}
				{VARIABLE hero_type $group[$player[$I].ally[$rand]].recruit[$bonus].type}
				[fire_event]
					name=modified world conquest hero
					[primary_unit]
						x,y=$player[$I].leader.x,$player[$I].leader.y
					[/primary_unit]
				[/fire_event]

				# bonus heroes for weaker factions
				[insert_tag]
					name=command
					variable=group[$player[$I].group].bonus_hero
				[/insert_tag]
			[/then]
		[/if]
	{NEXT I}
			[message]
				message=_"Test 5.10"
			[/message]

Code of event modified world conquest hero:

Spoiler:

Code: Select all

#define MODIFIED_WORLD_CONQUEST_CREATE_HERO
[event]
	name=modified world conquest hero
	first_time_only=no

	# check to see which traits this unit type is eligible for
	{VARIABLE bonus_trait 0}
	{FOREACH_FROM trait_assignment 1 trait_index}
		[if]
			[variable]
				name=trait_assignment[$trait_index].types
				contains=$hero_type
			[/variable]
			[then]
				{VARIABLE bonus_trait $trait_index}
			[/then]
		[/if]	
	{NEXT trait_index}
			
	[unit]
		side=$unit.side
		type=$hero_type
		x,y=$unit.x,$unit.y
		generate_name=yes
		overlays="misc/loyal-icon.png"
		role=hero
                
		[modifications]
			{MODIFIED_WORLD_CONQUEST_TRAIT_HEROIC}
			[insert_tag]
				name=trait
				variable=trait[$bonus_trait]
			[/insert_tag]
			[object]
				{MODIFIED_WORLD_CONQUEST_EXPERIENCE_PENALTY}
			[/object]
		[/modifications]
	[/unit]

	{CLEAR_VARIABLE hero_trait}
	{CLEAR_VARIABLE bonus_trait}
[/event]
#enddef

Code for MODIFIED_WORLD_CONQUEST_TRAIT_HEROIC

Spoiler:

Code: Select all

#define MODIFIED_WORLD_CONQUEST_TRAIT_HEROIC
[trait]
	id=heroic
	male_name= _ "heroic"
	female_name= _ "female^heroic"
	[effect]
		apply_to=loyal
	[/effect]
	[effect]
		apply_to=attack
		range=melee
		increase_damage=1
	[/effect]
	[effect]
		apply_to=attack
		range=ranged
		increase_damage=1
	[/effect]
	[effect]
		apply_to=hitpoints
		increase_total=8
	[/effect]
	[effect]
		apply_to=hitpoints
		times=per level
		increase_total=3
	[/effect]
	[effect]
		apply_to=movement
		increase=1
	[/effect]
	[effect]
		apply_to=max_experience
		increase=-20%
	[/effect]
[/trait]
#enddef

Code for MODIFIED_WORLD_CONQUEST_EXPERIENCE_PENALTY

Spoiler:

Code: Select all

#define MODIFIED_WORLD_CONQUEST_EXPERIENCE_PENALTY
duration=forever
[effect]
	apply_to=max_experience
	increase=50%
[/effect]
#enddef

[Ravana]

So dont create units without type.

[ChaosRider]

So dont create units without type.

In Wesnoth 1.10 units were created well. Something in code that was working fine in earlier version now its not working on Wesnoth 1.18.

[ChaosRider]

So I just added rand variable that picks of MWC units on 0-1 lvl if variable hero type is empty.

Spoiler:

Code: Select all

#textdomain wesnoth-ModifiedWorldConquest
#define MODIFIED_WORLD_CONQUEST_CREATE_HERO
[event]
	name=modified world conquest hero
	first_time_only=no

	# check to see which traits this unit type is eligible for
	{VARIABLE bonus_trait 0}
	{FOREACH_FROM trait_assignment 1 trait_index}
		[if]
			[variable]
				name=trait_assignment[$trait_index].types
				contains=$hero_type
			[/variable]
			[then]
				{VARIABLE bonus_trait $trait_index}
			[/then]
		[/if]	
	{NEXT trait_index}
			
	[if]
		[variable]
			name=hero_type
			equals=$null
		[/variable]
		[then]
			[set_variable]
				name=hero_type
				rand="Mwc_Rancher","Mwc_Peasant","Mwc_Nobleman","Mwc_Squire Heavy Infantryman","Mwc_Initiate","Mwc_Merman Citizen","Mwc_GiantRat","Mwc_Mudcrawler","Mwc_Young Orc","Mwc_Premature Troll Whelp","Mwc_Young Orcish Shooter","Mwc_Naga Scout","Mwc_Goblin Spearman","Mwc_Young Scorpion","Mwc_Elvish Civilian","Mwc_Elvish Courier","Mwc_Sapling","Mwc_Merman Recluse","Mwc_Walking Skeleton","Mwc_Walking Corpse","Mwc_Ethereal Spirit","Mwc_Vampire Bat","Mwc_Floating_Eye","Mwc_Minor Ghoul","Mwc_Young Vampire Beast","Mwc_Dwarvish Miner","Mwc_Young Gryphon","Mwc_Robber","Mwc_Ruffian","Mwc_Woodsman","Mwc_Drake Whelp Fly","Mwc_Drake Whelp","Mwc_Saurian Scout","Mwc_Spout","Mwc_Fire Wisp","Mwc_Dimensional Gate","Mwc_Rolling Snow","Mwc_Sun Shielder Helper","Mwc_Young Magician","Mwc_Devling Sneak","Mwc_Devling Nailers","Mwc_Devling Cursers","Mwc_Demon Cursed","Mwc_Whelp Imp","Mwc_Chaos Cultist","Mwc_Baby_Cyclops","Mwc_Goblin Slave","Mwc_Shoat","Mwc_Whelp Hydra","Mwc_Cavalryman","Mwc_Horseman","Mwc_Spearman","Mwc_Fencer","Mwc_Sergeant","Mwc_Heavy Infantryman","Mwc_Bowman","Mwc_Mage","Mwc_Merman Fighter","Mwc_Merman Child King","Mwc_GiantRatDuo","Mwc_Giant Mudcrawler","Mwc_Orcish Grunt","Mwc_Orcish Leader","Mwc_Southern Orc","Mwc_Troll Whelp","Mwc_Wolf Rider","Mwc_Orcish Archer","Mwc_Orcish Assassin","Mwc_Naga Fighter","Mwc_Naga Hunter","Mwc_Goblin Impaler","Mwc_Goblin Rouser","Mwc_Young Ogre","Mwc_Scorpion","Mwc_Elvish Fighter","Mwc_Elvish Archer","Mwc_Elvish Shaman","Mwc_Elvish Scout","Mwc_Exiled Alchemist","Mwc_Wose","Mwc_Big Plant","Mwc_Mermaid Initiate","Mwc_Merman Hunter","Mwc_Wolf","Mwc_Skeleton","Mwc_Skeleton Archer","Mwc_Soulless","Mwc_Ghost","Mwc_Blood Bat","Mwc_Big_Eye","Mwc_Dark Adept","Mwc_Ghoul","Mwc_Vampire Beast","Mwc_Dwarvish Guardsman","Mwc_Dwarvish Fighter","Mwc_Dwarvish Ulfserker","Mwc_Dwarvish Thunderer","Mwc_Dwarvish Scout","Mwc_Dwarvish Witness","Mwc_Dwarvish Gyrocopter","Mwc_Gryphon Rider","Mwc_Thief","Mwc_Poacher","Mwc_Footpad","Mwc_Thug","Mwc_Rogue Mage","Mwc_Drake Burner","Mwc_Drake Clasher","Mwc_Drake Glider","Mwc_Drake Fighter","Mwc_Protective Dragon Turtle","Mwc_Hunting Dragon Turtle","Mwc_Foraging Dragon Crab","Mwc_Young Speeder","Mwc_Saurian Skirmisher","Mwc_Saurian Recruit","Mwc_Saurian Augur","Mwc_Tentacle of the Deep","Mwc_Giant Myriapod","Mwc_White Warrior","Mwc_Slicer","Mwc_Novice Summoner","Mwc_Elementalist","Mwc_Carpet Rider","Mwc_Battle Mage","Mwc_Sky_Kingdom_Subversivemage","Mwc_Camel Rider","Mwc_Sun Shielder","Mwc_Tidal","Mwc_Rhami","Mwc_Magic Golem","Mwc_Little_Golem","Mwc_Jinn","Mwc_Elemental Fire","Mwc_Elemental_Earth","Mwc_Elemental_Air","Mwc_Greater Dimensional Gate","Mwc_Animated Snow","Mwc_Devling Spikers","Mwc_Overgrown Devling","Mwc_Devling Lurker","Mwc_Devling Flappers","Mwc_Devling Blasphemists","Mwc_Demon Sniper","Mwc_Demon Leech Rider","Mwc_Demon Initiate","Mwc_Demon Imp","Mwc_Demon Heterodox","Mwc_Demon Damned","Mwc_Minor Imp","Mwc_Demon Cursed","Mwc_Chaos Hound","Mwc_Chaos Gunner","Mwc_Invoker","Mwc_Invader","Mwc_Headhunter","Mwc_Novice Barbarian Shaman","Mwc_Young Hydra","Mwc_Tusker","Mwc_Young Shessinsaan","Mwc_Young_Cyclops","Mwc_Goblin_Archer","Mwc_Goblin_Hunter","Mwc_Goblin Axeman","Mwc_Shamanistic_Adept","Mwc_Salamander","Mwc_Toad","Mwc_Wyvern","Mwc_Wyvern_Rider","Mwc_Barbarian_Berserker","Mwc_Orcish_Fighter"
			[/set_variable]
		[/then]
	[/if]

	[unit]
		side=$unit.side
		type=$hero_type
		x,y=$unit.x,$unit.y
		generate_name=yes
		overlays="misc/loyal-icon.png"
		role=hero
                
		[modifications]
			{MODIFIED_WORLD_CONQUEST_TRAIT_HEROIC}
			[insert_tag]
				name=trait
				variable=trait[$bonus_trait]
			[/insert_tag]
			[object]
				{MODIFIED_WORLD_CONQUEST_EXPERIENCE_PENALTY}
			[/object]
		[/modifications]
	[/unit]

	{CLEAR_VARIABLE hero_trait}
	{CLEAR_VARIABLE bonus_trait}
[/event]
#enddef

But its not over of bugs. Right now there is no error of empty unit type.

Picking items doesnt work (which was working in Wesnoth 1.10). Below you have link to addon download for those who want to look in to it.

Modified World Conquest:

Spoiler:

https://files.wesnoth.org/addons/1.18/M ... st.tar.bz2

Modified World Conquest part 2 (units images):

Spoiler:

https://files.wesnoth.org/addons/1.18/M ... t2.tar.bz2

[Ravana]

If 1.10 allowed creating units without type then that was bug.

[ChaosRider]

If 1.10 allowed creating units without type then that was bug.

Sometimes in World Conquest and Modified World Conquest you had at the scenario beginning 2 or 3 heroes (in Wesnoth 1.10). I think it was just going on without sending back info about empty unit type. I added part of code to choose randomly unit type when hero type variable is empty.

Another bug is with picking items (which you can choose as a bonus after recruiting first unit) by unit.