[message] second_image issue

Having trouble with the game? Report issues and get help here. Read this first!

Moderator: Forum Moderators

Forum rules
Before reporting issues in this section, you must read the following topic:
Post Reply
User avatar
Spannerbag
Posts: 598
Joined: December 18th, 2016, 6:14 pm
Location: Yes

[message] second_image issue

Post by Spannerbag »

I'm migrating a part written campaign from 1.16.10 to 1.17.24 and have come across something I'd like to know if it's just me missing something or a genuine issue?
I spotted the behaviour when testing on v1.17 and can replicate part of the issue on v1.16.
However the weird thing is that I'm sure it used to work properly in v1.16 before I installed v1.17 (which is installed in a separate directory)?

The issue is that when a [message] has a second_image the left hand image (usually the speaker's profile) is lost.

Here's my test code if anyone wants to see if they can replicate the behaviour:

Code: Select all

  [event]
    name=side 1 turn 1
    {UNIT 1 Mage 2 2 (id="Testunit"
      name=_"Testunit"
      random_traits=yes
      random_gender=yes
      animate=no)}
    [message]
      speaker=Testunit
      message=_"Unit ""Testunit"" created. Next: image_pos=right."
    [/message]
    [message]
      speaker=Testunit
      message=_"Image_pos=right. Next: alternative image to show it works OK."
      image_pos=right
      mirror=yes
    [/message]
    [message]
      speaker=Testunit
      message=_"Using image=terrain/portals/door-wooden-long-n.png. Next: use alternative image as second image."
      image="terrain/portals/door-wooden-long-n.png"
    [/message]
    [message]
      speaker=Testunit
      message=_"Using image=terrain/portals/door-wooden-long-n.png as second image. Next: same but with unit profile explicitly stated."
      second_image="terrain/portals/door-wooden-long-n.png"
      second_mirror=yes
    [/message]
    [store_unit]
      [filter]
        id=Testunit
      [/filter]
      variable=tu_store
    [/store_unit]
    [message]
      speaker=Testunit
      message=_"Finally, as previous but explicitly state unit profile (image=tu_store.profile=$tu_store.profile)..."
      image="$tu_store.profile"
      second_image="terrain/portals/door-wooden-long-n.png"
      second_mirror=yes
    [/message]
    {CLEAR_VARIABLE tu_store}
[/event]
Here are screen grabs for the last 2 messages for v1.16.10 (note that the second_image is displayed).

Using image=terrain/portals/door-wooden-long-n.png as second image. Next: same but with unit profile explicitly stated.
v16_1_of_2.png
Finally, as previous but explicitly state unit profile (image=tu_store.profile=$tu_store.profile)...
v16_2_of_2.png

For v1.17.24 the second image is absent.
Using image=terrain/portals/door-wooden-long-n.png as second image. Next: same but with unit profile explicitly stated.
v17_1_of_2.png
Finally, as previous but explicitly state unit profile (image=tu_store.profile=$tu_store.profile)...
v17_2_of_2.png
However in both cases the speaker's profile is absent and as I said, I'm sure it worked on v1.16 previously.
Neither version's logs have any errors or warning or indeed anything out of the ordinary at all.
So, am I doing something stupid or can anyone else replicate this?

Cheers!
-- Spannerbag
SP Campaigns: After EI (v1.14) Leafsea Burning (v1.18, v1.16)
I suspect the universe is simpler than we think and stranger than we can know.
Also, I fear that beyond a certain point more intelligence does not necessarily benefit a species...
User avatar
Pentarctagon
Project Manager
Posts: 5619
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: [message] second_image issue

Post by Pentarctagon »

If it showed up on 1.16 and doesn't show up on 1.17, that'd be a bug.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
User avatar
Spannerbag
Posts: 598
Joined: December 18th, 2016, 6:14 pm
Location: Yes

Re: [message] second_image issue

Post by Spannerbag »

Pentarctagon wrote: January 18th, 2024, 11:50 pm If it showed up on 1.16 and doesn't show up on 1.17, that'd be a bug.
Just to clarify, I'm seeing issues in both versions:
  • V1.16: [message] with second_image does not display speaker's profile (image default value).
  • V1.17: as above but second_image also not displayed.
In both cases the speaker's image is not displayed when second_image is specified.
However I asked if anyone else could replicate this because I'm sure it used to work fine in (maybe earlier versions of) 1.16?
FWIW I have both versions installed on the same computer.

Apologies if my first post wasn't clear.

Cheers!
-- Spannerbag
SP Campaigns: After EI (v1.14) Leafsea Burning (v1.18, v1.16)
I suspect the universe is simpler than we think and stranger than we can know.
Also, I fear that beyond a certain point more intelligence does not necessarily benefit a species...
User avatar
Lexa04
Translator
Posts: 29
Joined: July 9th, 2018, 4:10 pm
Location: Ukraine
Contact:

Re: [message] second_image issue

Post by Lexa04 »

Has anyone found a solution? I have the same issue that second_image is not displayed, but on version 1.18.2
Maintainer of Ukrainian translation and founder of Ukrainian Irdya Project
User avatar
Ravana
Forum Moderator
Posts: 3117
Joined: January 29th, 2012, 12:49 am
Location: Estonia
Contact:

Re: [message] second_image issue

Post by Ravana »

It is not supported after 1.17.7
User avatar
Lexa04
Translator
Posts: 29
Joined: July 9th, 2018, 4:10 pm
Location: Ukraine
Contact:

Re: [message] second_image issue

Post by Lexa04 »

Oh no, that's terrible. So now there is no way we can have 2 images in [message]?
Maintainer of Ukrainian translation and founder of Ukrainian Irdya Project
User avatar
Spannerbag
Posts: 598
Joined: December 18th, 2016, 6:14 pm
Location: Yes

Re: [message] second_image issue

Post by Spannerbag »

Lexa04 wrote: July 9th, 2024, 8:37 pm Oh no, that's terrible. So now there is no way we can have 2 images in [message]?
Not that I can see from the wiki.

Might be a way using lua to build a custom [message] equivalent - but haven't got the time to experiment right now.

Cheers,
-- Spannerbag
SP Campaigns: After EI (v1.14) Leafsea Burning (v1.18, v1.16)
I suspect the universe is simpler than we think and stranger than we can know.
Also, I fear that beyond a certain point more intelligence does not necessarily benefit a species...
Post Reply