Reflection Modification

General feedback and discussion of the game.

Moderator: Forum Moderators

Post Reply
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Reflection Modification

Post by Atreides »

No thread so I post here.

Nifty stuff, even the trees have reflections!

Some tiny quibbles: Would have been cool if the reflections vanish at night. Star and moonlight reflections? Well maybe. Wesnoth doesn't account for the phases of the moon. Well there's an idea for another addon : ) The other thing is that it is noticeably slowing the animations, something I've not seen in Wesn up until now. Wondering if it could be related to the log error showing id=reflection twice (main has it all loaded in multiplayer ifdef as well as loaded again...)
User avatar
pipapopinguin
Posts: 35
Joined: November 3rd, 2019, 10:36 am

Re: Reflection Modification

Post by pipapopinguin »

Hi there,

I already had plans for such updates, I even want to give water in "underground" time of day some crystals shining at rare occasions. Not only that, but I thought about "clearing" the waves of the water-tiles, so that it would look more HD-ish, only plans though.
Author of Corpse Mod 2, Breeze-Mod,Reflections and don't click here.
User avatar
Toranks
Translator
Posts: 168
Joined: October 21st, 2022, 8:59 pm
Location: Sevilla
Contact:

Re: Reflection Modification

Post by Toranks »

There is a bug on Reflection that affects multiplayer and prevent some other mods to be activated because the duplication. Remove redundant ifdef:

Code: Select all

## #ifdef MULTIPLAYER
## {~add-ons/Reflection/reflection.cfg}
## {~add-ons/Reflection/images}
## {~add-ons/Reflection/images/terrain}
## #endif
{~add-ons/Reflection/reflection.cfg}
{~add-ons/Reflection/images}
{~add-ons/Reflection/images/terrain}
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Re: Reflection Modification

Post by Atreides »

I did that in my copy already. It (the mod) runs faster now.
User avatar
Toranks
Translator
Posts: 168
Joined: October 21st, 2022, 8:59 pm
Location: Sevilla
Contact:

Re: Reflection Modification

Post by Toranks »

I can't explain the cause, but some units have reflections, others not. Some units with reflections has his animations bugged when moving. Here is a video:

https://youtu.be/nxcwNPRkp_A
User avatar
pipapopinguin
Posts: 35
Joined: November 3rd, 2019, 10:36 am

Re: Reflection Modification

Post by pipapopinguin »

Toranks wrote: January 2nd, 2023, 8:49 am I can't explain the cause, but some units have reflections, others not. Some units with reflections has his animations bugged when moving. Here is a video:

https://youtu.be/nxcwNPRkp_A
Thank you, the video was very helpful.
The problem was related to how objects are deleted, when an object has an effect with apply_to=status, this effect will not be removed by removing that object, it seems like. I have corrected this with an apply_to=status and then remove.
Author of Corpse Mod 2, Breeze-Mod,Reflections and don't click here.
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Re: Reflection Modification

Post by Atreides »

Me again. I really like this mod and have it on all the time. The new starry night reflections are awesome BTW.

I did find 2 little somethings that seems to not work 100% though.

A) I believe gryphons were meant to not reflect because they fly so high?

I looked in the code and this part might be the culprit:

Code: Select all

        #add non-reflective as an status to your unit, to make it not able to reflect itself (for example a costom "vampire" unit)
        [filter]
            [not]
                status=non_reflective
                [or]
                    race=gryphon
                [/or]
            [/not]
            [and]
                [not]
                    status=has_reflected
                [/not]
            [/and]
        [/filter]
The original had

Code: Select all

[and]
around the gryphon. I think that would also have made add-on vampires with the custom status reflect anyways as well.

B) Custom units with existing

Code: Select all

[standing_anim]
that is missing a

Code: Select all

image=
key vanish when trying to reflect. Log says it can't find image "200".
Attachments
de.po
A German translation, place in Reflection directory under translations directory.
(762 Bytes) Downloaded 83 times
User avatar
pipapopinguin
Posts: 35
Joined: November 3rd, 2019, 10:36 am

Re: Reflection Modification

Post by pipapopinguin »

Thanks for the feedback. I already read your stuff some time ago, but I've only got around fixing the things now. Im not sure if I debugged the thing about units with missing "image=", because I've only tested it with the "fogclearer" unit, though I don't think it is a huge problem. I originally only wanted to add reflections to terrain, which also took the most amount of work, as I tried to undertsand how, for example, castles are even generated. The thing I added last was units reflecting themselves, which actually was the esiest part to code. Right now, I think I'll try to see how I can implement the changes to elevation, coming in the next version.
Author of Corpse Mod 2, Breeze-Mod,Reflections and don't click here.
User avatar
egallager
Posts: 596
Joined: November 19th, 2020, 7:27 pm
Location: Concord, New Hampshire
Contact:

Re: Reflection Modification

Post by egallager »

I get the following warning in my terminal output from this add-on when running Wesnoth:

Code: Select all

20230314 15:52:47 warning preprocessor: Redefining macro VILLAGE_PROBABILITY without explicit #undef at ~add-ons/Reflection/reflection.cfg:532
    included from ~add-ons/Reflection/_main.cfg:10
previously defined at core/terrain-graphics/new-macros.cfg:3851
    included from core/_main.cfg:15
    included from _main.cfg:18
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Re: Reflection Modification

Post by Atreides »

Still loving this mod.

Spotted an oddity I'd like to share. Not a bug I think just something unexpected, let's have a look at this screen cap:
orb-refl.jpg
Note how the reflection obscures (is above) the orb.
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Re: Reflection Modification

Post by Atreides »

The latest version of the addon is filling the log with huge numbers of warnings:

20240310 19:42:29 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:29 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:30 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:30 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:30 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:30 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.
20240310 19:42:30 warning scripting/lua: Cannot resolve variable 'new_reflection_animations[].offset' for reading.

(just a sample, there's 5,000 of them)

It is "only" a warning but with this many it may be slowing the addon down.

P.S. Got some seriously bad news. The mod is bogging down the game esp. with AI sides. Ran with and without and the AI side took 1 min/turn without and 30 min/turn with.
User avatar
pipapopinguin
Posts: 35
Joined: November 3rd, 2019, 10:36 am

Re: Reflection Modification

Post by pipapopinguin »

I know about the warnings. My computer has +32GB RAM and for me the AI turns are instant (with random map; one AI vs 1 player). There were some wierd bugs related to unit facing and the way reflection would be handeled and I fixed it. I have uploaded reflections onto the new wesnoth version's servers.
The mod now seems to work as intended as of right now.
Author of Corpse Mod 2, Breeze-Mod,Reflections and don't click here.
User avatar
ZombieKnight
Posts: 311
Joined: June 27th, 2022, 2:26 pm
Location: Czech Republic

Re: Reflection Modification

Post by ZombieKnight »

I like your add-on a lot!
Just two ideas:
1. could unit reflection be there even when it's idle animation plays? maybe even when fighting ^^? (haven't looked into the code, so idk if would be currently possible)
2. Maybe add bridges reflections? :D, that would be nice!
Screenshot_20240708_203919.png
Screenshot_20240708_203919.png (50.56 KiB) Viewed 346 times
>,<
I had saurian in profile before, but I've merged my discord profile with forum one...
Working on campaign Bandits from Brown Hills
User avatar
ZombieKnight
Posts: 311
Joined: June 27th, 2022, 2:26 pm
Location: Czech Republic

Re: Reflection Modification

Post by ZombieKnight »

I love this <3 :
Screenshot_20240708_204656.png
Screenshot_20240708_204946.png
Screenshot_20240708_204946.png (21.36 KiB) Viewed 338 times
...

Can you repair this:
Screenshot_20240708_204607.png
Screenshot_20240708_204607.png (244.97 KiB) Viewed 338 times
I'd like to use your add-on in my, if I can (if the zombie problem solves) ^^
If I can?
I had saurian in profile before, but I've merged my discord profile with forum one...
Working on campaign Bandits from Brown Hills
User avatar
Atreides
Posts: 1104
Joined: March 30th, 2019, 10:38 pm
Location: On the 2nd story of the centre village of Merwuerdigliebe turning the lights on and off

Re: Reflection Modification

Post by Atreides »

ZombieKnight wrote: July 8th, 2024, 6:40 pm
I like your add-on a lot!
Just two ideas:
1. could unit reflection be there even when it's idle animation plays? maybe even when fighting ^^? (haven't looked into the code, so idk if would be currently possible)
2. Maybe add bridges reflections? :D, that would be nice!

Screenshot_20240708_203919.png>,<
I do too. As for the idle it _used_ to do that, not sure if it was stopped for some technical reason perhaps. But I remember seeing drake reflections flapping their wings. : )
Post Reply