Delayed Shroud Updates - Simple GUI ON/OFF indicator

Brainstorm ideas of possible additions to the game. Read this before posting!

Moderator: Forum Moderators

Forum rules
Before posting a new idea, you must read the following:
Post Reply
User avatar
neki
Posts: 266
Joined: April 5th, 2009, 4:56 pm
Location: Your nightmares

Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by neki »

I lost a game in 4 turns, because my hotkey for Delayed Shroud Updates did not register (the replay of the 4 turn game is attached).

I think there should be an icon in the top menu bar that goes ON/OFF, red/green to indicate the current status of Delayed Shroud Updates.

Or if it would be too difficult to make such an indicator, please at least change the cursor model when Delayed Shroud Updates is on.

Please do not tell me "Use planning mode", as this post has absolutely nothing to do with planning mode, as also the title mentions, this post is exclusively about Delayed Shroud Updates.

I can fork, make the code modification myself and raise a pull request, but could you please tell me who would be willing to approve such pull request?

Thanks,

neki
Attachments
20200715234328_neki_vs_LeadFox_wesnoth-ladder.gz
(22.34 KiB) Downloaded 57 times
User avatar
Pentarctagon
Project Manager
Posts: 4516
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by Pentarctagon »

UI-related changes need to be approved by vultraz, as per here.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
User avatar
beetlenaut
Developer
Posts: 2493
Joined: December 8th, 2007, 3:21 am
Location: Washington State
Contact:

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by beetlenaut »

If the preference did not reset every time you loaded or started a game, that would solve the problem as well. If you always leave it on, then you would know it was on. That's probably the way most people first expect it to work (I did), and it wouldn't require a UI change.
Campaigns: Dead Water,
The Founding of Borstep,
Secrets of the Ancients,
and WML Guide
User avatar
neki
Posts: 266
Joined: April 5th, 2009, 4:56 pm
Location: Your nightmares

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by neki »

One needs to switch between Delayed Shroud Updates ON and OFF several times during a game.

I also sent a PM to Vultraz and currently waiting for his reply.
User avatar
neki
Posts: 266
Joined: April 5th, 2009, 4:56 pm
Location: Your nightmares

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by neki »

Vultraz has not replied to me yet on the forums, which is fair enough, people are busy with real life and it seems Wesnoth is struggling with the dev numbers anyway.

All I need is minor mentoring for setting up my local Wesnoth UI dev environment. I can make a pull request and a dev (Vultraz or somebody else who has merge access) can review it and I can change it accordingly => you get one more volunteer to help out with the coding stuff.

Is there any developer who would be willing and have time to help me set up my local environment and make this tiny UI modification?

I would be willing to help out in return with other coding tasks the dev feels like delegating and only reviewing before merge.

Thank you,

neki
User avatar
Pentarctagon
Project Manager
Posts: 4516
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by Pentarctagon »

Instructions for setting up your local environment can be found here.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
User avatar
Pentarctagon
Project Manager
Posts: 4516
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by Pentarctagon »

Also, out of curiosity, what's the issue with using planning mode?
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
User avatar
neki
Posts: 266
Joined: April 5th, 2009, 4:56 pm
Location: Your nightmares

Re: Delayed Shroud Updates - Simple GUI ON/OFF indicator

Post by neki »

Thanks for the instructions. I will give them a try. Planning mode has too much eye candy. The whole screen becomes red and causes one to lose focus of her army and the overall battle situation. Plus, there is no integration with U for undo. I know planning mode offers more in terms of planning options, but sometimes less is more. Last but not least, delay shroud updates is for legendary players, whereas planning mode is for mere mortals :D.
Post Reply