Antar, Son of Rheor [Development Thread]

Discussion and development of scenarios and campaigns for the game.

Moderator: Forum Moderators

Post Reply
dark_Crag
Posts: 40
Joined: December 30th, 2012, 7:31 pm
Location: Czech Republic

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by dark_Crag »

Adamant14 wrote:Thank you for the detailed report.
I tried many times to reproduce the error, but the error did not appear.
I tried different versions of my campaign, no such error message. :hmm:

Did the error appear more than one time, or did you quit after the first try?
Can you please try again an tell me what happens?
Same behaviour, the reproduction should be easy as I described above
Adamant14 wrote: The autosave that you attached shows no error, you better post a replay.
Thank you, and sorry for the trouble.
The replay doesn't help because it didn't catch mentioned behaviour.

I reproduced it many times and I discovered that this errors is caused by any unit. So what I done:
- right click on any unit and choose "unit description"
- close description
- left click on unit
- error appears

I suppose that problem is here (red line):
Battle for Weshnoth\userdata\data\add-ons\Antar\units\

id=Antar_Fencer
name= _ "Antar - Fencer"
Currently playing: Legend of the Invincibles
Already finished on BfW 1.11.X: Heir to the Throne, A Tale of Two Brothers, Rebellion in the North
dark_Crag
Posts: 40
Joined: December 30th, 2012, 7:31 pm
Location: Czech Republic

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by dark_Crag »

New bugs:

BfW version/Language:
1.11.1/Eng

1) Warning in stderr.txt
Description:
warning unit: Unknown attribute 'find_vacant' discarded.
warning unit: Unknown attribute 'find_vacant' discarded.

Reproduction scenario: (reproduced)
- Take village on position (2,24)
- Some new units (2) join on you side
- error appears

Attachment
ASoR-Attack_Of_The_Undead-Auto-Save4.gz


2) Warning in stderr.txt
Description:
warning unit: Unknown attribute 'find_vacant' discarded.
warning unit: Unknown attribute 'find_vacant' discarded.
warning unit: Unknown attribute 'find_vacant' discarded.

Reproduction scenario: (reproduced)
I suppose that this error appeared after:
- Enemy takes village on position (16,21)
- Some new units (3) join on enemy side
- error appears (these errors appear for each new village taken by enemy)

Attachment
ASoR-Attack_Of_The_Undead-Auto-Save4.gz


3) Error in stderr.txt
Description:
error display: could not open image 'units/humand/vagrant-defend.png'

Reproduction scenario: (not reproduced)
This error appeared during turn 8

Attachment
ASoR-Attack_Of_The_Undead-Auto-Save8.gz


4) Error in stderr.txt
Description:
error ai/actions: Return value of AI ACTION was not checked. This may cause bugs!

Reproduction scenario: (not reproduced)
This error appeared four times during playing of "Attack_Of_The_Undead" mission but I was not able to identify the trigger of this

Attachment
n/a


5) Audio error in stderr.txt
Description:
error audio: could not find track 'tribal_war_song.ogg'
error audio: cannot open track 'tribal_war_song.ogg'; disabled in this playlist.

Reproduction scenario: (reproduced)
- kill the enemy leader
- finis dialogue with friend incoming rider
- errors appeared during story between scenarios

Attachment
ASoR-Attack_Of_The_Undead-Auto-Save26.gz


6) Error in stderr.txt
Description:
error engine: A [recall] tag with the following content failed:
fire_event = yes
x = 4
y = 37
[filter_wml]
upkeep = loyal
[/filter_wml]

Reproduction scenario: (reproduced)
- skip dialogue between scenarios
- the error appered at the beginning of the first turn of "Lord_Veogwyn" mission

Attachment
ASoR-Attack_Of_The_Undead-Auto-Save26.gz
Attachments
ASoR-Attack_Of_The_Undead-Auto-Save26.gz
(96.99 KiB) Downloaded 231 times
ASoR-Attack_Of_The_Undead-Auto-Save8.gz
(152.91 KiB) Downloaded 225 times
ASoR-Attack_Of_The_Undead-Auto-Save4.gz
(113.59 KiB) Downloaded 266 times
Currently playing: Legend of the Invincibles
Already finished on BfW 1.11.X: Heir to the Throne, A Tale of Two Brothers, Rebellion in the North
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

Thank you for your feedback, and thanks for given my campaign a second chance.

About error 1 & 2:
No big thing. I just deleted the discarded line. :)
The error message will no longer appear in the stderr text.
I noticed this a long time ago, but for some reason I never fixed it. :P

About error 3:
This error is caused by a simple typo.
I wrote 'humand' instead of 'humans' in the path to the defence image.
Thanks for notify me. :)

About error 4:
I have currently no idea what may cause this error,
but I will check it.

About error 5:
Seems I once deleted this song by mistake.
I added it again to the folder 'songs'.
Thank you for the report.

About error 6:
This error is caused by a WML leftover.
In former versions of this scenario, there were three loyal Peasants to find.
Now there are only two Peasants that joins your party.
In the second scenario the engine tries to recall (all) three loyal Peasants, but there are only two of them. (if they survived the first scenario)
I will change this in the .cfg file.
Thank you.
Thanks for the autosaves, very interesting, especially the third.
The second sadly seems not to work.

Hope you enjoy the campaign so far. :)
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
dark_Crag
Posts: 40
Joined: December 30th, 2012, 7:31 pm
Location: Czech Republic

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by dark_Crag »

Adamant14 wrote:
Hope you enjoy the campaign so far. :)
Yes so far :-D ......seriously it is nice campaign :)

1) Error in stderr.txt
Description:
error display: could not open image 'units/human-peasants/female+senior-village-elder.png'

Reproduction scenario: (reproduced)
Same bug (typo) as in previous post (point 3)

Attachment
n/a


2) Dialogue is not performed properly
Description:
The finish dialogue is not proper at the end of "Lord_Veogwyn" mission. The "Lord_Veogwyn" says nothing only Antar's dialogue part is replayed.
This error message "warning engine: cannot show message" in the stderr.txt is associated with this bug.

Reproduction scenario: (reproduced)
- Kill the enemy leader
- check dialogue

Attachment
ASoR-Lord_Veogwyn-Auto-Save23.gz


3) Error in stderr.txt
Description:
error engine: A [recall] tag with the following content failed:
id = Gelphrad
x = 37
y = 24

Reproduction scenario: (reproduced)
- Skip dialogue
- Check stderr.txt

Attachment
ASoR-Lord_Othar.gz


4) Error in stderr.txt
Description:
Detected an image with bad dimensions: terrain/../terrain/ruined_chateau.png: 96x96
It will not be masked, please use: 72x72

Reproduction scenario: (reproduced)
- Skip dialogue
- Check stderr.txt

Attachment
ASoR-Lord_Othar.gz


5) Error in stderr.txt
Description:
warning engine: variable_info: invalid WML array index, spawn_places[16].x
warning engine: variable_info: invalid WML array index, spawn_places[16].y
warning engine: variable_info: invalid WML array index, spawn_places[16].x
warning engine: variable_info: invalid WML array index, spawn_places[16].y

Reproduction scenario: (reproduced)
- kill enemy leader
- Skip dialogue
- Check stderr.txt

Attachment
ASoR-Lord_Othar-Auto-Save22.gz


6) Note for "Through_The_Goblin_Hills" mission
I suppose that all non-recalled units will be lost as well as the units which don't reach signpost. So it would be nice to have a castle (somewhere) in "Through_The_Goblin_Hills" mission
Attachments
ASoR-Lord_Othar-Auto-Save22.gz
(72.51 KiB) Downloaded 222 times
ASoR-Lord_Othar.gz
(11.17 KiB) Downloaded 185 times
ASoR-Lord_Veogwyn-Auto-Save23.gz
(100.68 KiB) Downloaded 210 times
Currently playing: Legend of the Invincibles
Already finished on BfW 1.11.X: Heir to the Throne, A Tale of Two Brothers, Rebellion in the North
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

Error number 1:
Fixed. Thank you.


Error number 2:
:doh: Stupid mistake. :augh:
I changed Lord Veogwyns ID, and missed to change the speakers ID's too.
And because I always skipped those part of the scenario while play-testing, I didn't noticed the missing messages.
I am really grateful for this report.
Fixed. Thank you very much. :D


Error number 3:
Since I use a macro to recall all main heroes, the recall tag to recall Gelphrad is redundant.
Fixed. Thank you.


Error number 4:
Here I use a custom house image.
And the images size is bigger than Wesnoths standard.
I don't want to shrink the image, so this error message will be displayed furthermore. :P


Error number 5:
I'm have no idea how to fix this.
The error is caused by the code I use to create Goblins on random hexes.
But I don't know what exactly causes this error.
I will set this on my todo list. (a very long list) :augh:


6) About the 'note for "Through_The_Goblin_Hills" mission':
No, the player keeps his units on the recall list.
I think It would be a bad idea to delete the recall list at this point.
That would surly annoy the player.
Only the units on the map can be lost.
So a castle is not necessary.
A castle would not fit to the idea of this scenario. :)
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
dark_Crag
Posts: 40
Joined: December 30th, 2012, 7:31 pm
Location: Czech Republic

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by dark_Crag »

1) Message should not be shown
Description:
See attached picture, some message is displayed

Reproduction scenario: (reproduced)
Kill the enemy leader on position (35,24)

Attachment
Displayed_message.png

2) Warning in stdrerr.txt
Description:
warning engine: repeated [endlevel] execution, ignoring

Reproduction scenario: (reproduced)
-Kill the Yetti

Attachment
ASoR-The_Elvish_Outpost-Auto-Save24.gz


3) Auto-save file has not proper name
Description:
The "ASoR-_.gz" was created instead of "ASoR-Dwarven_Pass_.gz"

Reproduction scenario: (reproduced)
- Kill the Yetti
- skip dialogue
- check the saved file

Attachment
ASoR-The_Elvish_Outpost-Auto-Save24.gz


4) Warning in stderr.txt
Description:
warning engine: variable_info: retrieving member of non-existent WML container, firedead.side

Reproduction scenario: (reproduced)
I suppose that this warning appears when the unit is killed by fire

Attachment
ASoR-Revenge-Auto-Save12.gz


5) Warning in stderr.txt
Description:
warning engine: cannot show message

Reproduction scenario: (reproduced)
- Try to kill the enemy leader
- check stderr.txt

Attachment
ASoR-Revenge-Auto-Save19.gz


6) Warning in stderr.txt
Description:
Continuing in game (after previous error) causes these warnings:
20130120 20:52:26 warning engine: Could not find move_unit_fake route from 14,14 to 8,16: ignoring complexities
20130120 20:52:27 warning engine: Could not find move_unit_fake route from 13,15 to 8,16: ignoring complexities
20130120 20:52:36 warning engine: Could not find move_unit_fake route from 18,24 to 21,22: ignoring complexities
20130120 20:52:48 warning unit: Unknown attribute 'recruitment_ignore_bad_combat' discarded.
20130120 20:52:48 warning unit: Unknown attribute 'recruitment_pattern' discarded.
20130120 20:52:48 warning unit: Unknown attribute 'recruitment_ignore_bad_combat' discarded.
20130120 20:52:48 warning unit: Unknown attribute 'recruitment_pattern' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:58 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.
20130120 20:52:59 warning unit: Unknown attribute 'remove_unit_overlay' discarded.

Reproduction scenario: (reproduced)
- Try to kill the enemy leader
- check stderr.txt

Attachment
ASoR-Revenge-Auto-Save19.gz
Attachments
ASoR-Revenge-Auto-Save19.gz
(172.47 KiB) Downloaded 263 times
ASoR-Revenge-Auto-Save12.gz
(176.46 KiB) Downloaded 218 times
ASoR-The_Elvish_Outpost-Auto-Save24.gz
(110.45 KiB) Downloaded 253 times
Displayed_message.png
Currently playing: Legend of the Invincibles
Already finished on BfW 1.11.X: Heir to the Throne, A Tale of Two Brothers, Rebellion in the North
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

1) Message should not be shown
In some scenarios you can capture the war-chest of the defeated enemy leader.
In earlier versions of my campaign, the unit who killed the enemy leader said a sentence about the gained war-chest.
But most of the time was the number of gold is a odd number, and the spoken sentence was something like "Oh, I found a warchest with 148 gold in it!" or
" Oh I found a warchest with 29 gold in it!"
And that is pretty weird.
The unit can't know the exactly number of coins, or count so fast while fighting hordes of enemies.
So I decided that the unit should say nothing about the chest.
I think it is better to display the number of gold the way you see on the attached image.

Seems I have to explain this feature somehow to the player.
Any proposals?

2) Warning in stdrerr.txt / repeated [endlevel] execution, ignoring
Fixed, thank you.

3) Auto-save file has not proper name
This is caused because BfW 1.11.1 is still a development version.
And because of this some things don't work as intended,
and because of this I was forced to use a workaround here.
And that is the reason why there is a unnamed save (ASoR-_.gz).
I'm pretty sure the "ASoR-Dwarven_Pass_.gz"-save is also there.

5) Warning in stderr.txt / cannot show message
:oops: I did not noticed the missing message myself. :?
Fixed, thank you. :)

Error number 4) and 6) I have to check.
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
dark_Crag
Posts: 40
Joined: December 30th, 2012, 7:31 pm
Location: Czech Republic

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by dark_Crag »

Adamant14 wrote:1) Message should not be shown
In some scenarios you can capture the war-chest of the defeated enemy leader.
In earlier versions of my campaign, the unit who killed the enemy leader said a sentence about the gained war-chest.
But most of the time was the number of gold is a odd number, and the spoken sentence was something like "Oh, I found a warchest with 148 gold in it!" or
" Oh I found a warchest with 29 gold in it!"
And that is pretty weird.
The unit can't know the exactly number of coins, or count so fast while fighting hordes of enemies.
So I decided that the unit should say nothing about the chest.
I think it is better to display the number of gold the way you see on the attached image.

Seems I have to explain this feature somehow to the player.
Any proposals?
The problem is that this message is not cleared (at the end of the turn or let's say after 20 seconds or something like that). I mean that the message is displayed until you finish mission or load any game. I guess that this is bug in game not in your add-ons. However from my point of view it is sufficient if the unit say something like "I just found some money...."


1) Antar is lvl 1
Description:
At the beginning of "ASoR-The_Dwarves" mission is now Antar lvl 1

Reproduction scenario: (reproduced)
- Skip dialogue
- Check Antar

Attachment
ASoR-The_Dwarves.gz
Attachments
ASoR-The_Dwarves.gz
(19.46 KiB) Downloaded 210 times
Currently playing: Legend of the Invincibles
Already finished on BfW 1.11.X: Heir to the Throne, A Tale of Two Brothers, Rebellion in the North
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

dark_Crag wrote:However from my point of view it is sufficient if the unit say something like "I just found some money...."
I once used similar messages, but I was not satisfied with them.
The message about the gold came often very inappropriate and untimely. And often it does not fit with the following messages, e.g. talking in the victory event.
So I decided to try it this way, but you are right. The message sticks too long on the screen.
I have to find an other way to tell the player how much gold he has looted.
Because that is what I want, I want to tell the player the exact number of gold he has gained. :)
If a unit on the map tells the exact number, then this will sound very weird.

dark_Crag wrote:1) Antar is lvl 1
Description:
At the beginning of "ASoR-The_Dwarves" mission is now Antar lvl 1
:augh: :doh: :x :doh: :augh:
Seems my campaign wont work with BfW version 1.11.0 and 1.11.1
My campaign works perfect with BfW 1.10, so I guess it is a issue with the game core itself.
Other campaign designers has similar problems. (e.g. The Library of Kratemaqht by cephalo)
Even mainline campaigns have this trouble (e.g. Legend of Wesmere)
I am very sorry about that, but there is nothing I can do, except waiting for the new BfW version 1.11.2
And I really hope the problem is solved then.
Remember, 1.11 is the development version!
I would suggest to play my campaign with BfW version 1.10, thats the stable version.
I added this proposal to the last update on the 1.11 server, so anyone should notice that.
Thank you for your feedback.
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
User avatar
AxalaraFlame
Posts: 690
Joined: December 4th, 2011, 1:07 pm
Location: Pasadina, Caltech

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by AxalaraFlame »

Hello bro. I am suppose to update my ASoR recently and finish some battle tests. Can you briefly introduce some new changes you've made in the newly updated versions? That would be appreciated :)
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

Your wish is my command :)
Changelog:
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
Gitanomad_X
Posts: 14
Joined: March 30th, 2011, 4:55 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Gitanomad_X »

Hello Adamant,

Any chance of any new scenarios in the near future???

Thanks!
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

There are some scenarios in development/testing state, but non of them is ready for publishing. :)
Of course I try to finish the campaign, but currently I neither have the time nor the inspiration that is prerequisite to make big progress.
I don't want to upload some unbalanced or boring scenarios. :)
Right now I have more fun in playing other peoples campaigns, than in developing mine. :whistle:
I beg your pardon, and hope you will understand.
But I am still here, and I still work on Antar, Son of Rheor. :)
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
Magigi12
Posts: 7
Joined: April 27th, 2013, 11:37 am

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Magigi12 »

Hi Adamant, I have a problem in the map "flight tunnel", as soon as I get to the waypoint and the village appears around me I get this error:

Error while playing the game: game_error: invalid side(4) found in unit description

Dugi posted a workaround on the original thread, but I thought I would let you know anyways.

Very nice campaign by the way!
Last edited by 8680 on April 27th, 2013, 7:46 pm, edited 1 time in total.
Reason: Added hyperlink to “original thread”, for future reference.
User avatar
Adamant14
Posts: 934
Joined: April 24th, 2010, 1:14 pm

Re: Antar, Son of Rheor [Singleplayer Campaign Feedback Thr

Post by Adamant14 »

@Magigi12
Thank you for the report, although I noticed this issue already by my self.
Dugi is right in both cases.
1. Yes, Flight Tunnel is temporary the last available scenario.
2. Yes the issue is caused by the stored Dwarf side.
If you are interested in technical details, see this thread for details: "Error while playing the game: game_error: invalid side(4) found in unit definition"
This problem appearers only in the 1.11 development versions, the stable 1.10 versions runs without any problems.

I will upload a version that should work without this error message tonight.
But for new scenarios you have to be patient.

Edit: Done, a fixed version is on the server.
Author of Antar, Son of Rheor ( SP Campaign) | Development Thread + Feedback Thread + Replays of ASoR
Post Reply