Legend of the Invincibles
Moderator: Forum Moderators
Re: Legend of the Invincibles
no, even in the rather unlikeley case that another 1.12 version comes out, it mostlikeley won't fix this one since it directly effect the gamestate and we aren't sure whether it will casue OOS when different versions play together.Dugi wrote:This is exactly the root of the problem. Will there be some later 1.12 version that would fix it? IMO, it's quite a huge bug.
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
Re: Legend of the Invincibles
i think this was reported before, but now i have encountered it too:
the gauntlet Touch of Death reduces the number of attacks by 4, but if it is equipped on a unit with less than 4 attacks (so, almost every unit) the number of attacks becomes infinite.
here's a save file. the item is equipped to the elvish shaman.
something made the game freeze during the AI turn, it may be related to the Touch of Death...
the gauntlet Touch of Death reduces the number of attacks by 4, but if it is equipped on a unit with less than 4 attacks (so, almost every unit) the number of attacks becomes infinite.
here's a save file. the item is equipped to the elvish shaman.
something made the game freeze during the AI turn, it may be related to the Touch of Death...
may the source be with you
=(^.^)= nyan~
=(^.^)= nyan~
Re: Legend of the Invincibles
In theory, what unit would want to use Touch of Death? Typically I'm ecstatic to add a single attack, so the idea of subtracting 4 attacks seems inconceivable.
Re: Legend of the Invincibles
I think, since Touch of Death gives 16 more damage to compensate the decreased 4 attack, it's good for units that will give a final blow to an enemy. The decreased attack can be countered by using an item with anger special attack. So, for example an unit with 6 attacks that wears Touch of Death and Anger will have 4 attacks left, not too bad, right?
Re: Legend of the Invincibles
What about making the fix singleplayer-only?gfgtdf wrote:no, even in the rather unlikeley case that another 1.12 version comes out, it mostlikeley won't fix this one since it directly effect the gamestate and we aren't sure whether it will casue OOS when different versions play together.
I have fixed that one already in the github version.firefox wrote:i think this was reported before, but now i have encountered it too:
Re: Legend of the Invincibles
Dugi, why are some weapon specials coded as [damage] (explosive and its variants) and some as [dummy] (hose, storm, others)?
- Celtic_Minstrel
- Developer
- Posts: 2222
- Joined: August 3rd, 2012, 11:26 pm
- Location: Canada
- Contact:
Re: Legend of the Invincibles
I'd question the merit of ever using dummy - any made-up tag will have the same effect and may make it easier if you need to manipulate the abilities from code.
Re: Legend of the Invincibles
For example with this:Lordlevis wrote:How do you make a custom plague attack? I've tried many things but it never works, so how do you do it?
Code: Select all
{WEAPON_SPECIAL_PLAGUE}
[+plague]
type=Fire Dragon # Or whatever type you want to create
[/plague]
For no reason.dabber wrote:Dugi, why are some weapon specials coded as [damage] (explosive and its variants) and some as [dummy] (hose, storm, others)?
When any made-up tag works, why not dummy then? It works thanks to the weapon special's id, not thanks to the tag name.Celtic_Minstrel wrote:I'd question the merit of ever using dummy - any made-up tag will have the same effect and may make it easier if you need to manipulate the abilities from code.
Re: Legend of the Invincibles
If the name of the tag doesn't matter, in concept, what does that tag mean or do?For no reason.dabber wrote:Dugi, why are some weapon specials coded as [damage] (explosive and its variants) and some as [dummy] (hose, storm, others)?When any made-up tag works, why not dummy then? It works thanks to the weapon special's id, not thanks to the tag name.Celtic_Minstrel wrote:I'd question the merit of ever using dummy - any made-up tag will have the same effect and may make it easier if you need to manipulate the abilities from code.
Now they are coded, for example, like this:
Code: Select all
[damage]
id=explosive
name= _ "explosive"
description= _ "blah blah blah"
[/damage]
Code: Select all
[explosive]
name= _ "explosive"
description= _ "blah blah blah"
[/explosive]
Re: Legend of the Invincibles
Its still questionable since people might rely (having their campaign balanced based) on the old beahviour.Dugi wrote:What about making the fix singleplayer-only?
I think one of the main reason why people se [dummy] is that mainline feeding used it and uiirc there is alsoa wiki page reccomneind it.Celtic_Minstrel wrote:I'd question the merit of ever using dummy - any made-up tag will have the same effect and may make it easier if you need to manipulate the abilities from code.
There is a lua functionDugi wrote: When any made-up tag works, why not dummy then? It works thanks to the weapon special's id, not thanks to the tag name.
wesnoth.unit_ability
to check whether a unit is under the effect of an ability, it requires the abilities tagname. Afaik this is the main reason why i'd reccomend using a custom tagname.Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
- Celtic_Minstrel
- Developer
- Posts: 2222
- Joined: August 3rd, 2012, 11:26 pm
- Location: Canada
- Contact:
Re: Legend of the Invincibles
While it's true that that macro exists, I wouldn't say it's necessarily less complicated. In particular, you might want a custom description for your custom plague ability, in which case the +tag syntax may be more appropriate.James_The_Invisible wrote:While this works, it is unnecessary complicated. There is macro WEAPON_SPECIAL_PLAGUE_TYPE in core which has TYPE parameter.
Some tag names imply special effects that are coded into the game engine. Any other tag is just taken as an ability to display to the user with no gameplay effect; generally, you would then implement the desired effect using events.dabber wrote: If the name of the tag doesn't matter, in concept, what does that tag mean or do?
Re: Legend of the Invincibles
WML's event filter can identify units using the ability ids they have, it's far harder for anything else the ability has:dabber wrote:But could they be coded like this?
Code: Select all
[event]
name=last breath
[filter_second]
ability=killhunger
[/filter_second]
#...
[/event]
Then it has quite an inconsistency with the filter tag.gfgtdf wrote:There is a lua function wesnoth.unit_ability to check whether a unit is under the effect of an ability, it requires the abilities tagname. Afaik this is the main reason why i'd reccomend using a custom tagname.
Anyway, I usually prefer unified tag names in WML because it's hard to iterate through tags with different names in WML. And in LotI, it's used and more tag names would complicate it.
Re: Legend of the Invincibles
Hi i got Version 1.13.4 of the game and 3.1.21c of the addon.
During 1 scenario of second chapter when i equip some items ( for example dark gloves of destruction ) with Lethalia she "die" and i lose. I cant store them (when i choose the option, nothing happen).
When i lvl up during AI turn i dont get any benefits (or cant choose which one) and she get animation showing she is double time lvl-ing.
Anyone knew how to fix it?:x
During 1 scenario of second chapter when i equip some items ( for example dark gloves of destruction ) with Lethalia she "die" and i lose. I cant store them (when i choose the option, nothing happen).
When i lvl up during AI turn i dont get any benefits (or cant choose which one) and she get animation showing she is double time lvl-ing.
Anyone knew how to fix it?:x
Re: Legend of the Invincibles
Yes but note that they also check different things, the ability filter afaik only check whther the unit has an ability with that id at all (whether [unit][abilities] has a child tag with that id), while that lua function checks whether the unitis currently affected by that ability: it will not only check unit filters in that ability, it will also check whether an adjacent unit has that ability with [affect_adjacent]Dugi wrote:Then it has quite an inconsistency with the filter tag.
Anyway, I usually prefer unified tag names in WML because it's hard to iterate through tags with different names in WML. And in LotI, it's used and more tag names would complicate it.
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
Re: Legend of the Invincibles
Beelzebub is not dropping a nice gem for me, and I don't see anything about a special gem drop in utils.cfg from github. Yet that quote is from November?Dugi wrote:Okay, now he's guaranteed to drop a high gem (emerald or higher, significantly improved probabilities, the chance to get a black pearl from him is 11%).
Last edited by dabber on March 7th, 2017, 6:54 pm, edited 1 time in total.