Build from source, Windows 7 issue

[Antro]

Hi gents.
I have succesfully compiled our beloved game from source with no issue on my windows 7, 32 bit, old but still valid development environment, but this latest release has some scons cache issue.So, in a fresh mingw32 term I started from scratch:

Code: Select all

macchinista@HTPC MINGW32 ~
$ pacman -Syuu
:: Synchronizing package databases...
 mingw32 is up to date
 mingw64 is up to date
 msys is up to date
:: Starting core system upgrade...
 there is nothing to do
:: Starting full system upgrade...
 there is nothing to do
 
macchinista@HTPC MINGW32 ~
$ git clone https://github.com/wesnoth/wesnoth.git wesnoth
Cloning into 'wesnoth'...
remote: Enumerating objects: 1099389, done.
remote: Total 1099389 (delta 0), reused 0 (delta 0), pack-reused 1099389
Receiving objects: 100% (1099389/1099389), 2.67 GiB | 9.36 MiB/s, done.
Resolving deltas: 100% (856330/856330), done.
Updating files: 100% (20944/20944), done.

macchinista@HTPC MINGW32 ~
$ cd wesnoth

macchinista@HTPC MINGW32 ~/wesnoth
$ git branch
* master

macchinista@HTPC MINGW32 ~/wesnoth
$ scons --config=force arch=native sdldir=/mingw32/\include/\SDL2 boostdir=/mingw32/\include/\boost boostlibdir=/mingw32/\bin boost_suffix=-mt notifications=false
scons: Reading SConscript files ...
Building Wesnoth version 1.15.2+dev
Mkdir("build")
---[checking prerequisites]---
Checking for C library m... yes
Checking for C function round()... yes
Checking whether C++ compiler works (g++ version >= 4.8 required)... yes
Checking for Boost iostreams library version >= 1.56.0... yes
Checking for gzip support in Boost Iostreams... yes
Checking for bzip2 support in Boost Iostreams... yes
Checking for Boost random library version >= 1.56.0... yes
Checking for Boost smart_ptr library... yes
Checking for Boost system library... yes
Checking for Boost asio library... yes
Checking for Boost thread library... yes
Checking for Boost locale library... yes
Checking for Boost filesystem library... yes
INFO: Base prerequisites are met
Checking for available Boost Locale backends... winapi,std
Checking whether compiler has built-in -D_FORTIFY_SOURCE... no
Checking for C library libcrypto... yes
Checking for Simple DirectMedia Layer library version >= 2.0.4... yes
Checking for SDL2_ttf library... yes
Checking for SDL2_mixer library... yes
Checking for SDL2_image library... yes
Checking for C library vorbisfile... yes
Checking for Ogg Vorbis support in SDL... yes
Checking for PNG support in SDL... yes
Checking for JPG support in SDL... yes
Checking for Cairo... (cached) yes
Checking for Pango with cairo backend... (cached) yes
Checking for fontconfig... (cached) yes
Checking for Boost program_options library version >= 1.56.0... yes
Checking for Boost regex library... yes
Checking for fribidi >= 0.10.9... (cached) yes
Checking for C library history... yes
Checking for Boost unit_test_framework library... yes
  If any config checks fail, look in build/config.log for details
  If a check fails spuriously due to caching, use --config=force to force its rerun
---[applying configuration]---
scons: done reading SConscript files.
scons: Building targets ...
/mingw32/bin/msgfmt --check-domain --statistics -o translations/af/LC_MESSAGES/wesnoth-ai.mo po/wesnoth-ai/af.po
1 translated message, 378 untranslated messages.
:
[snipped]
:
/mingw32/bin/msgfmt --check-domain --statistics -o translations/zh_TW/LC_MESSAGES/wesnoth.mo po/wesnoth/zh_TW.po
1215 translated messages, 45 fuzzy translations, 19 untranslated messages.
scons: Configure: creating build/config.h
g++ -o build/release/wesnoth.o -c -Werror=non-virtual-dtor -std=c++14 -Wold-style-cast -Wall -Wextra -mms-bitfields -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wtrampolines -mthreads -O3 -march=native -include boost-patched/bind/arg.hpp -Dmain=SDL_main -DHAVE_CONFIG_H -D_WIN32_WINNT=0x0601 -Ibuild -Isrc -isystem /mingw32/include/boost -isystem build/release/C:/msys32/mingw32/include/SDL2 -isystem src/C:/msys32/mingw32/include/SDL2 -isystem build/release/C:/msys32/mingw32/include/cairo -isystem src/C:/msys32/mingw32/include/cairo -isystem build/release/C:/msys32/mingw32/include -isystem src/C:/msys32/mingw32/include -isystem build/release/C:/msys32/mingw32/lib/libffi-3.2.1/include -isystem src/C:/msys32/mingw32/lib/libffi-3.2.1/include -isystem build/release/C:/msys32/mingw32/include/pixman-1 -isystem src/C:/msys32/mingw32/include/pixman-1 -isystem build/release/C:/msys32/mingw32/include/freetype2 -isystem src/C:/msys32/mingw32/include/freetype2 -isystem build/release/C:/msys32/mingw32/include/harfbuzz -isystem src/C:/msys32/mingw32/include/harfbuzz -isystem build/release/C:/msys32/mingw32/include/glib-2.0 -isystem src/C:/msys32/mingw32/include/glib-2.0 -isystem build/release/C:/msys32/mingw32/lib/glib-2.0/include -isystem src/C:/msys32/mingw32/lib/glib-2.0/include -isystem build/release/C:/msys32/mingw32/include/libpng16 -isystem src/C:/msys32/mingw32/include/libpng16 -isystem build/release/C:/msys32/mingw32/include/pango-1.0 -isystem src/C:/msys32/mingw32/include/pango-1.0 -isystem build/release/C:/msys32/mingw32/include/fribidi -isystem src/C:/msys32/mingw32/include/fribidi src/wesnoth.cpp
In file included from src/gui/core/widget_definition.hpp:19,
                 from src/gui/core/static_registry.hpp:17,
                 from src/gui/dialogs/modal_dialog.hpp:18,
                 from src/gui/dialogs/end_credits.hpp:16,
                 from src/wesnoth.cpp:32:
src/font/text.hpp:22:10: fatal error: pango/pango.h: No such file or directory
   22 | #include <pango/pango.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
scons: *** [build/release/wesnoth.o] Error 1
scons: building terminated because of errors.

macchinista@HTPC MINGW32 ~/wesnoth

Even if compliation fails on pango header, my guess is that scons is not getting the correct parameters, because even with a --config=force in place, scons still user cached Cairo, Pango, fontconfig and fribidi

Checking for JPG support in SDL... yes
Checking for Cairo... (cached) yes
Checking for Pango with cairo backend... (cached) yes
Checking for fontconfig... (cached) yes
Checking for Boost program_options library version >= 1.56.0... yes
Checking for Boost regex library... yes
Checking for fribidi >= 0.10.9... (cached) yes
Checking for C library history... yes

This extract from config.log confirm that cache is still in place

build/sconf_temp/conftest_26.c:4:28: warning: unused parameter 'argv' [-Wunused-parameter]
4 | int main(int argc, char **argv)
| ~~~~~~~^~~~
gcc -o build/sconf_temp/conftest_26.exe -static-libgcc -static-libstdc++ -mwindows build/sconf_temp/conftest_26.o -L/mingw32/bin -LC:/msys32/mingw32/lib -lboo
st_filesystem-mt -lboost_locale-mt -lboost_thread-mt -lboost_system-mt -lboost_random-mt -lboost_iostreams-mt -lm -lws2_32 -lcrypto -lmingw32 -lSDL2main -lSDL
2 -lSDL2_ttf -lSDL2_mixer -lSDL2_image -lvorbisfile
build/sconf_temp/conftest_26.exe > build/sconf_temp/conftest_26.exe.out
scons: Configure: yes

scons: Configure: Checking for Cairo...
scons: Configure: (cached) yes

scons: Configure: Checking for Pango with cairo backend...
scons: Configure: (cached) yes

scons: Configure: Checking for fontconfig...
Found 'fontconfig' with pkg-config.
scons: Configure: (cached) yes

scons: Configure: Checking for Boost program_options library version >= 1.56.0...
build/sconf_temp/conftest_27.cpp <-
|
| #include <boost/program_options.hpp>
|
|#include <boost/version.hpp>
|#if BOOST_VERSION < 105600
|#error Boost version is too old!

Is --config=force not forcing pkg-config to be executed ?

[octalot]

Do you have multiple versions of Boost installed, and could the older version end up in the include path before the newer version?

[gnombat]

$ scons --config=force arch=native sdldir=/mingw32/\include/\SDL2 boostdir=/mingw32/\include/\boost boostlibdir=/mingw32/\bin boost_suffix=-mt notifications=false

What happens if you build without --config=force?

(I suspect that --config=force may be buggy/broken running on Windows/MSYS.)

[Antro]

Do you have multiple versions of Boost installed, and could the older version end up in the include path before the newer version?

Nop... only one boost installed
macchinista@HTPC MINGW32 ~
$ pacman -Ss boost
mingw32/mingw-w64-i686-boost 1.72.0-1 [installed]
Free peer-reviewed portable C++ source libraries (mingw-w64)
mingw64/mingw-w64-x86_64-boost 1.72.0-1
Free peer-reviewed portable C++ source libraries (mingw-w64)

[Antro]

What happens if you build without --config=force?

without --config=force, all checking are cached, as expected;

Code: Select all

macchinista@HTPC MINGW32 ~/wesnoth
$ scons arch=native sdldir=/mingw32/\include/\SDL2 boostdir=/mingw32/\include/\boost boostlibdir=/mingw32/\bin boost_suffix=-mt notifications=false
scons: Reading SConscript files ...
Saved options: default_targets = 'wesnoth,wesnothd', arch = 'native', notifications = False, sdldir = '/mingw32/include/SDL2', boostdir = '/mingw32/include/boost', boostlibdir = '/mingw32/bin', boost_suffix = '-mt'
Building Wesnoth version 1.15.2+dev
---[checking prerequisites]---
Checking for C library m... (cached) yes
Checking for C function round()... (cached) yes
Checking whether C++ compiler works (g++ version >= 4.8 required)... (cached) yes
Checking for Boost iostreams library version >= 1.56.0... (cached) yes
Checking for gzip support in Boost Iostreams... (cached) yes
Checking for bzip2 support in Boost Iostreams... (cached) yes
Checking for Boost random library version >= 1.56.0... (cached) yes
Checking for Boost smart_ptr library... (cached) yes
Checking for Boost system library... (cached) yes
Checking for Boost asio library... (cached) yes
Checking for Boost thread library... (cached) yes
Checking for Boost locale library... (cached) yes
Checking for Boost filesystem library... (cached) yes
INFO: Base prerequisites are met
Checking for available Boost Locale backends... (cached) winapi,std
Checking whether compiler has built-in -D_FORTIFY_SOURCE... (cached) no
Checking for C library libcrypto... (cached) yes
Checking for Simple DirectMedia Layer library version >= 2.0.4... (cached) yes
Checking for SDL2_ttf library... (cached) yes
Checking for SDL2_mixer library... (cached) yes
Checking for SDL2_image library... (cached) yes
Checking for C library vorbisfile... (cached) yes
Checking for Ogg Vorbis support in SDL... (cached) yes
Checking for PNG support in SDL... (cached) yes
Checking for JPG support in SDL... (cached) yes
Checking for Cairo... (cached) yes
Checking for Pango with cairo backend... (cached) yes
Checking for fontconfig... (cached) yes
Checking for Boost program_options library version >= 1.56.0... (cached) yes
Checking for Boost regex library... (cached) yes
Checking for fribidi >= 0.10.9... (cached) yes
Checking for C library history... (cached) yes
Checking for Boost unit_test_framework library... (cached) yes
  If any config checks fail, look in build/config.log for details
  If a check fails spuriously due to caching, use --config=force to force its rerun
---[applying configuration]---
scons: done reading SConscript files.
scons: Building targets ...

g++ doesn't argue about pango header
and showed only some warnings ( see below)

Code: Select all

/mingw32/bin/msgfmt --check-domain --statistics -o translations/af/LC_MESSAGES/wesnoth-ai.mo po/wesnoth-ai/af.po
1 translated message, 378 untranslated messages.
:
[snipped]
:
/mingw32/bin/msgfmt --check-domain --statistics -o translations/zh_TW/LC_MESSAGES/wesnoth.mo po/wesnoth/zh_TW.po
1215 translated messages, 45 fuzzy translations, 19 untranslated messages.
scons: Configure: creating build/config.h
g++ -o build/release/wesnoth.o -c -Werror=non-virtual-dtor -std=c++14 -Wold-style-cast -Wall -Wextra -mms-bitfields -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wtrampolines -mthreads -O3 -march=native -include boost-patched/bind/arg.hpp -Dmain=SDL_main -DHAVE_FRIBIDI -DHAVE_HISTORY -DHAVE_CONFIG_H -D_WIN32_WINNT=0x0601 -Ibuild -Isrc -isystem /mingw32/include/boost -isystem /mingw32/include/SDL2 -isystem /mingw32/include/cairo -isystem /mingw32/lib/libffi-3.2.1/include -isystem /mingw32/include/pixman-1 -isystem /mingw32/include/freetype2 -isystem /mingw32/include/harfbuzz -isystem /mingw32/include/glib-2.0 -isystem /mingw32/lib/glib-2.0/include -isystem /mingw32/include/libpng16 -isystem /mingw32/include/pango-1.0 -isystem /mingw32/include/fribidi src/wesnoth.cpp
g++ -o build/release/about.o -c -Werror=non-virtual-dtor -std=c++14 -Wold-style-cast -Wall -Wextra -mms-bitfields -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wtrampolines -mthreads -O3 -march=native -include boost-patched/bind/arg.hpp -Dmain=SDL_main -DHAVE_FRIBIDI -DHAVE_HISTORY -DHAVE_CONFIG_H -D_WIN32_WINNT=0x0601 -Ibuild -Isrc -isystem /mingw32/include/boost -isystem /mingw32/include/SDL2 -isystem /mingw32/include/cairo -isystem /mingw32/lib/libffi-3.2.1/include -isystem /mingw32/include/pixman-1 -isystem /mingw32/include/freetype2 -isystem /mingw32/include/harfbuzz -isystem /mingw32/include/glib-2.0 -isystem /mingw32/lib/glib-2.0/include -isystem /mingw32/include/libpng16 -isystem /mingw32/include/pango-1.0 -isystem /mingw32/include/fribidi src/about.cpp
:
[snipped]
:
g++ -o build/release/desktop/version.o -c -Werror=non-virtual-dtor -std=c++14 -Wold-style-cast -Wall -Wextra -mms-bitfields -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wtrampolines -mthreads -O3 -march=native -include boost-patched/bind/arg.hpp -Dmain=SDL_main -DHAVE_FRIBIDI -DHAVE_HISTORY -DHAVE_CONFIG_H -D_WIN32_WINNT=0x0601 -Ibuild -Isrc -isystem /mingw32/include/boost -isystem /mingw32/include/SDL2 -isystem /mingw32/include/cairo -isystem /mingw32/lib/libffi-3.2.1/include -isystem /mingw32/include/pixman-1 -isystem /mingw32/include/freetype2 -isystem /mingw32/include/harfbuzz -isystem /mingw32/include/glib-2.0 -isystem /mingw32/lib/glib-2.0/include -isystem /mingw32/include/libpng16 -isystem /mingw32/include/pango-1.0 -isystem /mingw32/include/fribidi src/desktop/version.cpp
src/desktop/version.cpp: In function 'std::string desktop::os_version()':
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::dwMajorVersion' [-Wmissing-field-initializers]
  197 |  OSVERSIONINFOEX v { sizeof(OSVERSIONINFOEX) };
      |                                              ^
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::dwMinorVersion' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::dwBuildNumber' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::dwPlatformId' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::szCSDVersion' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::wServicePackMajor' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::wServicePackMinor' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::wSuiteMask' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::wProductType' [-Wmissing-field-initializers]
src/desktop/version.cpp:197:46: warning: missing initializer for member '_OSVERSIONINFOEXW::wReserved' [-Wmissing-field-initializers]
src/desktop/version.cpp:267:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
  267 |    } // else fallback to default
      |    ^
src/desktop/version.cpp:268:3: note: here
  268 |   default:
      |   ^~~~~~~

Same behaviour on a different PC with Windows10 and mingw64 environment installed: --config=force with the same behaviour and failure, clean compile and install without the flag

(I suspect that --config=force may be buggy/broken running on Windows/MSYS.)

IMHO, it is definitively the --config-force option that is broken. Checking the build/config.log file generated with -config=force in place
it can be noticed that Cairo, pango, fontconfig and fribidi are "cached" even if the config is forced... As far as I know, these packages are configured via pkg-config: could be the "config=force" that is not "propagated" to pkg-config query ?
P.S: log extract below come from w64 envronment, w32 is the same with /mingw32 path and appropriate flags...

Code: Select all

gcc -o build/sconf_temp/conftest_26.exe -static-libgcc -static-libstdc++ -mwindows build/sconf_temp/conftest_26.o -L/mingw64/bin -LC:/msys64/mingw64/lib -lboost_filesystem-mt -lboost_locale-mt -lboost_thread-mt -lboost_system-mt -lboost_random-mt -lboost_iostreams-mt -lm -lws2_32 -lcrypto -lmingw32 -lSDL2main -lSDL2 -lSDL2_ttf -lSDL2_mixer -lSDL2_image -lvorbisfile
build/sconf_temp/conftest_26.exe > build/sconf_temp/conftest_26.exe.out
scons: Configure: yes

scons: Configure: Checking for Cairo... 
scons: Configure: (cached) yes

scons: Configure: Checking for Pango with cairo backend... 
scons: Configure: (cached) yes

scons: Configure: Checking for fontconfig... 
Found 'fontconfig' with pkg-config.
scons: Configure: (cached) yes

scons: Configure: Checking for Boost program_options library version >= 1.56.0... 
build/sconf_temp/conftest_27.cpp <-
  |
  |        #include <boost/program_options.hpp>
  |        
  |#include <boost/version.hpp>
  |#if BOOST_VERSION < 105600
  |#error Boost version is too old!
  |#endif
  |
  |        // Workaround for sdl #defining main breaking non sdl programs
  |        #ifdef main
  |        #undef main
  |        #endif
  |        int main()
  |        {
  |            return 0;
  |        }
  |        
  |
g++ -o build/sconf_temp/conftest_27.o -c -Werror=non-virtual-dtor -std=c++14 -Wall -Wextra -mms-bitfields -Dmain=SDL_main -isystem /mingw64/include/boost -isystem C:/msys64/mingw64/include/SDL2 -isystem C:/msys64/mingw64/include/cairo -isystem C:/msys64/mingw64/include -isystem C:/msys64/mingw64/lib/libffi-3.2.1/include -isystem C:/msys64/mingw64/include/pixman-1 -isystem C:/msys64/mingw64/include/freetype2 -isystem C:/msys64/mingw64/include/harfbuzz -isystem C:/msys64/mingw64/include/glib-2.0 -isystem C:/msys64/mingw64/lib/glib-2.0/include -isystem C:/msys64/mingw64/include/libpng16 -isystem C:/msys64/mingw64/include/pango-1.0 -isystem C:/msys64/mingw64/include/fribidi build/sconf_temp/conftest_27.cpp
g++ -o build/sconf_temp/conftest_27.exe -static-libgcc -static-libstdc++ -mwindows build/sconf_temp/conftest_27.o -L/mingw64/bin -LC:/msys64/mingw64/lib -lboost_program_options-mt -lboost_filesystem-mt -lboost_locale-mt -lboost_thread-mt -lboost_system-mt -lboost_random-mt -lboost_iostreams-mt -lm -lws2_32 -lcrypto -lmingw32 -lSDL2main -lSDL2 -lSDL2_ttf -lSDL2_mixer -lSDL2_image -lvorbisfile -lpangocairo-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lcairo -lfontconfig -lfreetype
scons: Configure: yes

scons: Configure: Checking for Boost regex library... 
build/sconf_temp/conftest_28.cpp <-
  |
  |        #include <boost/regex/config.hpp>
  |        
  |
  |        // Workaround for sdl #defining main breaking non sdl programs
  |        #ifdef main
  |        #undef main
  |        #endif
  |        int main()
  |        {
  |            return 0;
  |        }
  |        
  |
g++ -o build/sconf_temp/conftest_28.o -c -Werror=non-virtual-dtor -std=c++14 -Wall -Wextra -mms-bitfields -Dmain=SDL_main -isystem /mingw64/include/boost -isystem C:/msys64/mingw64/include/SDL2 -isystem C:/msys64/mingw64/include/cairo -isystem C:/msys64/mingw64/include -isystem C:/msys64/mingw64/lib/libffi-3.2.1/include -isystem C:/msys64/mingw64/include/pixman-1 -isystem C:/msys64/mingw64/include/freetype2 -isystem C:/msys64/mingw64/include/harfbuzz -isystem C:/msys64/mingw64/include/glib-2.0 -isystem C:/msys64/mingw64/lib/glib-2.0/include -isystem C:/msys64/mingw64/include/libpng16 -isystem C:/msys64/mingw64/include/pango-1.0 -isystem C:/msys64/mingw64/include/fribidi build/sconf_temp/conftest_28.cpp
g++ -o build/sconf_temp/conftest_28.exe -static-libgcc -static-libstdc++ -mwindows build/sconf_temp/conftest_28.o -L/mingw64/bin -LC:/msys64/mingw64/lib -lboost_regex-mt -lboost_program_options-mt -lboost_filesystem-mt -lboost_locale-mt -lboost_thread-mt -lboost_system-mt -lboost_random-mt -lboost_iostreams-mt -lm -lws2_32 -lcrypto -lmingw32 -lSDL2main -lSDL2 -lSDL2_ttf -lSDL2_mixer -lSDL2_image -lvorbisfile -lpangocairo-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lcairo -lfontconfig -lfreetype
scons: Configure: yes

scons: Configure: Checking for fribidi >= 0.10.9... 
Found 'fribidi >= 0.10.9' with pkg-config.
scons: Configure: (cached) yes

scons: Configure: Checking for C library history... 
build/sconf_temp/conftest_29.c <-

[loonycyborg]

Currently --config=force is broken on all platforms, delete build/ directory to get a clean build instead. It's lot faster anyway.