"No Ally Mirror" and "Shuffle Sides"

Having trouble with the game? Report issues and get help here. Read this first!

Moderators: Forum Moderators, Developers

Forum rules
Before reporting issues in this section, you must read the following topic:
Post Reply
Kelubar
Posts: 1
Joined: December 1st, 2018, 6:57 pm
Location: Russia

"No Ally Mirror" and "Shuffle Sides"

Post by Kelubar » December 10th, 2018, 1:06 pm

Hello. I've just found out that when you enable both "No Ally Mirror" and "Shuffle Sides" for a multiplayer game, "No Ally Mirror" gets calculated first and only after that the sides get shuffled. As a result, with these both on, two allies may still end up playing the same faction. Maybe something can be done about this?
Wenoth version: 1.14.5 on 32-bit Linux.

josteph
Developer
Posts: 236
Joined: August 19th, 2017, 6:58 pm

Re: "No Ally Mirror" and "Shuffle Sides"

Post by josteph » December 11th, 2018, 4:23 pm

The code is here:

https://github.com/wesnoth/wesnoth/blob ... #L427-L428

That comment says that if there could be errors if Shuffle Sides was resolved before No Ally Mirror, but doesn't say what those errors are.

The comment was added in this commit:

https://github.com/wesnoth/wesnoth/comm ... b00bb65615

Does anyone know what the referenced "bug 2961" or issues 18599 and 18600 are?

Post Reply