Battery indicator messed-up

Having trouble with the game? Report issues and get help here. Read this first!

Moderators: Forum Moderators, Developers

Forum rules
Before reporting issues in this section, you must read the following topic:
Post Reply
Yomar
Posts: 256
Joined: October 27th, 2011, 5:14 am
Contact:

Battery indicator messed-up

Post by Yomar » November 24th, 2018, 1:43 pm

Since no one reported it yet (I think, cause searching the forum don't gave me results), I noticed that the indicator on top of the screen that shows the remaining battery power is always mangled, I cant read the numbers, this happens on various configurations, with Win10.

enclave
Posts: 910
Joined: December 15th, 2007, 8:52 am

Re: Battery indicator messed-up

Post by enclave » November 24th, 2018, 2:32 pm

As for me I tried to use 1.14.5 default theme and I don't see battery indicator at all (I'm not on laptop, maybe that's why). Some people told that they don't see observers anymore.
But since I use classic pre1.12 theme the battery indicator is completely messed up there, it sits on the clock, you cant see clock, etc.. no even point to explain in details, short description could be "total mess" and it shows me battery on my NON-laptop PC.. guess how much I care about my battery charge..
So I went back to 1.14.4 until I find time to go and manually fix the classic theme for 1.14.5 (copy paste just made wesnoth crash, so I have to go edit it carefuly)

josteph
Developer
Posts: 165
Joined: August 19th, 2017, 6:58 pm

Re: Battery indicator messed-up

Post by josteph » November 25th, 2018, 8:02 am

enclave, the crash when you edited the theme might be because of https://github.com/wesnoth/wesnoth/issues/3582. On a desktop PC on 1.14.5 you have to have [battery] in the theme if you have the countdown/clock. This is already fixed for 1.14.6.

As to the rest, yes, I see the problem with latest 1.14:
Screenshot_2018-11-25_08-01-29.png
Screenshot_2018-11-25_08-01-29.png (9.35 KiB) Viewed 533 times
Looks like a bug.

enclave
Posts: 910
Joined: December 15th, 2007, 8:52 am

Re: Battery indicator messed-up

Post by enclave » November 25th, 2018, 2:17 pm

josteph wrote:
November 25th, 2018, 8:02 am
On a desktop PC on 1.14.5 you have to have [battery] in the theme if you have the countdown/clock. This is already fixed for 1.14.6.
Thank you josteph, I will skip 1.14.5 then and go for 1.14.6 when it's out. Will save me time editing things.

jyrkive
Developer
Posts: 35
Joined: July 7th, 2016, 6:20 pm
Location: Helsinki, Finland

Re: Battery indicator messed-up

Post by jyrkive » November 26th, 2018, 7:24 am

Hi, I'm the secondary author of the battery indicator.

I haven't seen this problem myself. My own PC is a desktop PC, but when I edit the game code (C++ code, to be specific) to force the battery indicator to be displayed, it looks just fine. (Well, the change it displays is 255 %, which is an error value [as expected for a desktop PC that doesn't even have a battery], but other than that it's okay.)

I'm afraid there isn't really anything I can do about a bug I can't reproduce...
josteph wrote:
November 25th, 2018, 8:02 am
enclave, the crash when you edited the theme might be because of https://github.com/wesnoth/wesnoth/issues/3582. On a desktop PC on 1.14.5 you have to have [battery] in the theme if you have the countdown/clock. This is already fixed for 1.14.6.
It's #3599, not #3582. 3599 has been fixed for 1.14.6, but the fix for 3582 is exclusive to the master branch (upcoming 1.15 series).

jyrkive
Developer
Posts: 35
Joined: July 7th, 2016, 6:20 pm
Location: Helsinki, Finland

Re: Battery indicator messed-up

Post by jyrkive » November 26th, 2018, 8:04 am

Update: josteph clarified in Discord that the issue only affects the classic theme. That one I haven't tested, so the bug may be easily reproducible and fixable.

jyrkive
Developer
Posts: 35
Joined: July 7th, 2016, 6:20 pm
Location: Helsinki, Finland

Re: Battery indicator messed-up

Post by jyrkive » November 26th, 2018, 6:21 pm

Fixed in commit f78887fb. The fixes will be in 1.14.6.

Post Reply