Please, prevent macros from messing up textdomain

Having trouble with the game? Report issues and get help here. Read this first!

Moderators: Forum Moderators, Developers

Forum rules
Before reporting issues in this section, you must read the following topic:
User avatar
iceiceice
Developer
Posts: 1056
Joined: August 23rd, 2013, 2:10 am

Re: Please, prevent macros from messing up textdomain

Post by iceiceice » November 16th, 2014, 4:54 am

Dugi: Another possibility is that it works fine in game but it's broken when you save and reload the game. It's a bit harder for me to imagine how that could happen in the code but it's easier to see how it wouldn't have been spotted.

User avatar
Dugi
Posts: 4925
Joined: July 22nd, 2010, 10:29 am
Location: Carpathian Mountains
Contact:

Re: Please, prevent macros from messing up textdomain

Post by Dugi » November 16th, 2014, 11:40 am

It's not caused by reloading, because the dialogue is in the start scenario event that you will not see after reloading. It was spotted there by a translator, I just dug the problem from the save file when I was investigating it.

User avatar
shadowm
Site Administrator
Posts: 6579
Joined: November 14th, 2006, 5:54 pm
Location: Chile
Contact:

Re: Please, prevent macros from messing up textdomain

Post by shadowm » November 17th, 2014, 8:52 am

Dugi wrote:I was told that somebody (maybe zookeeper, I wasn't told this exactly in that PM) is looking at it already, but I have no more information how is that going. I will ask him when I'll be on IRC (I am currently quite submerged in some physics research).
I don’t really think anybody was looking into this, and the implementation details of WML aren’t zookeeper’s domain. I am on the case now, though, with bug #22962 [Gna.org] filed and including a proper isolated test case for everyone’s convenience.
Author of the unofficial UtBS sequels Invasion from the Unknown and After the Storm.

User avatar
Dugi
Posts: 4925
Joined: July 22nd, 2010, 10:29 am
Location: Carpathian Mountains
Contact:

Re: Please, prevent macros from messing up textdomain

Post by Dugi » November 17th, 2014, 11:03 am

Thank you.

User avatar
shadowm
Site Administrator
Posts: 6579
Joined: November 14th, 2006, 5:54 pm
Location: Chile
Contact:

Re: Please, prevent macros from messing up textdomain

Post by shadowm » November 18th, 2014, 8:26 am

And fixed (in master and 1.12).

Expect to see the fix in version 1.12.1, assuming I didn’t fail to account for some weird corner case — some testing in the meantime would be highly appreciated.
Author of the unofficial UtBS sequels Invasion from the Unknown and After the Storm.

User avatar
Dugi
Posts: 4925
Joined: July 22nd, 2010, 10:29 am
Location: Carpathian Mountains
Contact:

Re: Please, prevent macros from messing up textdomain

Post by Dugi » November 18th, 2014, 9:09 am

Good job. Thanks.

kiss
Posts: 124
Joined: July 9th, 2014, 5:50 pm

Re: Please, prevent macros from messing up textdomain

Post by kiss » November 22nd, 2014, 6:42 pm

default_language_1.12.png
default_language_1.12.png (84.18 KiB) Viewed 2520 times
To be sure, does this also fix that?

User avatar
shadowm
Site Administrator
Posts: 6579
Joined: November 14th, 2006, 5:54 pm
Location: Chile
Contact:

Re: Please, prevent macros from messing up textdomain

Post by shadowm » November 22nd, 2014, 9:58 pm

No, that’s a separate issue that gfgtdf fixed not long after 1.11.19 was released (bug #22928 [Gna.org]).
Author of the unofficial UtBS sequels Invasion from the Unknown and After the Storm.

Post Reply