lua_function in Location Filter

[gfgtdf]

in StandartUnitFilters i can use the lua_function attribute, is there a way to do the same in a LocationFilter?

[Anonymissimus]

Try [filter_location][filter]lua_function=; I think it requires a unit to be at the location though. But other than that, you could put whatever conditions into that function.

[gfgtdf]

but there is normaly no unit on that hex.

[Anonymissimus]

Well, then: no.
And btw, good job with that boost bug workaround.

[iceiceice]

Maybe you can e.g. temporarily place a fog clearer there and remove after?

[gfgtdf]

@Anonymissimus
have you tested it? the last version should not create bugged gz files at all.

@iceiceice:
no that was supposed to be a filter for a right click menu items, so i dont knever know when it will happen.


maybe i can create somthing like a terrain overlay terrain wich defines wether there can can be klicked or not. Or i make pull request it shouldnt be too hard to add, or i do other things first and then think about it again, if i still think i need this.

[Anonymissimus]

have you tested it? the last version should not create bugged gz files at all.

Not only are the crashes gone. Since MSVC debugger can use the wml cache now, relaunching into the test scenario takes roughly a whole minute less than before now. So, very useful at a very low cost code-wise. Excellent. (Kind of a typical wesnoth bug, some bug which is also a bug on Linux but just not as noticable and unfixed due to lack of windows devs.)

Maybe you can e.g. temporarily place a fog clearer there and remove after?

How could one place a unit from within a location/unit/whatever filter ? lua_function= could do it yes but .
So, one would need two loops, one before and one after the filter call, to place a unit on all hexes and remove them afterwards. I don't suppose that's a good idea on anything but small maps.

[Elvish_Hunter]

Maybe you can e.g. temporarily place a fog clearer there and remove after?

@iceiceice:
no that was supposed to be a filter for a right click menu items, so i dont knever know when it will happen.

Why don't you try describing us what kind of filter do you need? It may even turn out that you won't need lua_function at all.

How could one place a unit from within a location/unit/whatever filter ? lua_function= could do it yes but .

In fact, lua_function= 's purpose is to take a unit and pass it as an argument to a function. Here there is an old example that I made:

Code: Select all

             function is_enemy( unit )
                if wesnoth.is_enemy( 1, unit.side ) then
                   return true
                end
             end

Code: Select all

            [if]
                [have_unit]
                    lua_function=is_enemy
                    [filter_vision]
                        visible=yes
                        viewing_side=1
                    [/filter_vision]
                [/have_unit]

Ideally, it should be a really short function, like lambdas in Python, and its only purpose should be to check if a unit meets certain criteria or not. Using a compare function to do other stuff but comparing seems like a recipe for disaster to me.