ChaosRider’s WML questions

[iceiceice]

Hmm... if you look at my "Creep War Draft Mode" scenario, I use this change the side of the guard to whoever's turn it is to choose their hero so that they can recruit their choice. See for example here: https://github.com/cbeck88/WesnothCapta ... e.cfg#L343

Maybe you can compare to figure out what's going wrong?

[ChaosRider]

I made code which is working but not in 100%, its store units, and after changing unit side this code is stopped (so if our unit is near 6 enemy units on 0 lvl (which all in our turn start should be joined to our side) then only one have changed side). Looks like modify_side is killing my code, anyone know why ?

Spoiler:

Code: Select all

#define ABILITY_IRON_RULER
    [dummy]
        id=iron_ruler
        name= _ "iron ruler"
        female_name= _ "female^iron ruler"
        description=_ "Iron Ruler:
This unit has a scary leadership skills so that easy to convince the weaker enemies to betray their rulers (it works for each adjected enemy units at turn start). 100% for 0 lvls, 20% for 1 lvl, 5% for 2 lvl, 1% for 3 lvl, 0,1% for 4 lvl, 0,01% for 5th lvl enemies (in each turn start of this unit side!!!)."
    [/dummy]
[/abilities]
[event]
    id=stealing_enemies
    name=side turn
    first_time_only=no
	[store_unit]
		[filter]
			[filter_adjacent]
				#adjacent=n,ne,se,s,sw,nw
				ability=iron_ruler
				is_enemy=yes
				#side=$side_number
			[/filter_adjacent]
		[/filter]
		kill=no
		variable=stealed_enemies
	[/store_unit]
	{FOREACH stealed_enemies a}
		[set_variable]
			name=checked_level
			value=$stealed_enemies[$a].level
		[/set_variable]
		[switch]
			variable=checked_level
			[case]
				value=0
				[modify_unit]
					[filter]
						x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
					[/filter]
					side=$side_number
				[/modify_unit]
			[/case]
			[case]
				value=1
				[set_variable]
					name=random_iron_value
					rand=1..5
				[/set_variable]
				[if]
					[variable]
						name=random_iron_value
						equals=1
					[/variable]
					[then]
						[modify_unit]
							[filter]
								x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
							[/filter]
							side=$side_number
						[/modify_unit]
					[/then]
				[/if]
			[/case]
			[case]
				value=2
				[set_variable]
					name=random_iron_value
					rand=1..20
				[/set_variable]
				[if]
					[variable]
						name=random_iron_value
						equals=1
					[/variable]
					[then]
						[modify_unit]
							[filter]
								x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
							[/filter]
							side=$side_number
						[/modify_unit]
					[/then]
				[/if]
			[/case]
			[case]
				value=3
				[set_variable]
					name=random_iron_value
					rand=1..100
				[/set_variable]
				[if]
					[variable]
						name=random_iron_value
						equals=1
					[/variable]
					[then]
						[modify_unit]
							[filter]
								x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
							[/filter]
							side=$side_number
						[/modify_unit]
					[/then]
				[/if]
			[/case]
			[case]
				value=4
				[set_variable]
					name=random_iron_value
					rand=1..1000
				[/set_variable]
				[if]
					[variable]
						name=random_iron_value
						equals=1
					[/variable]
					[then]
						[modify_unit]
							[filter]
								x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
							[/filter]
							side=$side_number
						[/modify_unit]
					[/then]
				[/if]
			[/case]
			[case]
				value=5
				[set_variable]
					name=random_iron_value
					rand=1..10000
				[/set_variable]
				[if]
					[variable]
						name=random_iron_value
						equals=1
					[/variable]
					[then]
						[modify_unit]
							[filter]
								x,y=$stealed_enemies[$a].x,$stealed_enemies[$a].y
							[/filter]
							side=$side_number
						[/modify_unit]
					[/then]
				[/if]
			[/case]
		[/switch]
		{CLEAR_VARIABLE stealed_enemies,checked_level,random_iron_value}
	{NEXT a}
[/event]
[+abilities]
#enddef

Edit:
Ok, way to fix this bug was to change one of the last lines with other one ("clear" with "next a"):
http://forums.wesnoth.org/viewtopic.php ... 89#p567089

[ChaosRider]

So im trying now to stop spawned near ai leader his recruits in turn when they are spawned, but code dont works... these new ai creeps got royal trait ... and i want stop them only once.

Spoiler:

Code: Select all

#define STOPPING_AI_NEW_UNITS
	[event]
		name=side turn
		first_time_only=no
		[store_unit]
			[filter]
				side=$side_number
				[filter_wml]
					[modifications]
						[trait]
							id=loyal
						[/trait]
					[/modifications]
				[/filter_wml]
				[and]
					[not]
						side=1,2,3
					[/not]
				[/and]
				[and]
					[not]
						[filter_wml]
							[variables]
								already_once_stopped=yes
							[/variables]
						[/filter_wml]
					[/not]
				[/and]
			[/filter]
			variable=units_who_must_be_stopped
		[/store_unit]
		{FOREACH units_who_must_be_stopped i}
			{VARIABLE units_who_must_be_stopped[$i].attacks_left 0}
			{VARIABLE units_who_must_be_stopped[$i].moves 0}
			{MODIFY_UNIT id=$units_who_must_be_stopped[$i].id variables.already_once_stopped yes}
		{NEXT i}
		{CLEAR_VARIABLE units_who_must_be_stopped}
	[/event]
#enddef

edit:
units_who_must_be_stopped[$i].moves dont work, but units_who_must_be_stopped[$i].max_moves (but then unit have 1/1 moves (not 0), why .moves dont work?)

edit2:
i checked addons from 1.10 wesnoth and most codes in which are changed .moves are filtred on unit x,y (which my code higher dont do, so i thought maybe in this was my problem reason, after add filter with x,y game is blocked like in not ending loop (and i dont know why):

Spoiler:

Code: Select all

#define STOPPING_AI_NEW_UNITS
		[store_unit]
			[filter]
				side=$side_number
				[filter_wml]
					[modifications]
						[trait]
							id=loyal
						[/trait]
					[/modifications]
				[/filter_wml]
				[and]
					[not]
						side=1,2,3
					[/not]
				[/and]
				[and]
					[not]
						[filter_wml]
							[variables]
								already_once_stopped=yes
							[/variables]
						[/filter_wml]
					[/not]
				[/and]
			[/filter]
			variable=unitstostop
		[/store_unit]
		{FOREACH unitstostop x}
			[store_unit]
				[filter]
					x,y=$unitstostop[$x].x,$unitstostop[$x].y
				[/filter]
				variable=stophim
			[/store_unit]
			[set_variable]
				name=stophim.attacks_left
				value=0
			[/set_variable]
			[set_variable]
				name=stophim.moves
				value=0
			[/set_variable]
			{MODIFY_UNIT id=$unitstostop[$x].id variables.already_once_stopped yes}
		{NEXT i}
		{CLEAR_VARIABLE unitstostop,stophim}
#enddef

[Dugi]

Your problem is by the end of the code. You're mixing direct modifications with modify_unit macro, and you aren't unstoring it. If the rest of the code is correct, it should be correct if you replace this:

Code: Select all

      {FOREACH units_who_must_be_stopped i}
         {VARIABLE units_who_must_be_stopped[$i].attacks_left 0}
         {VARIABLE units_who_must_be_stopped[$i].moves 0}
         {MODIFY_UNIT id=$units_who_must_be_stopped[$i].id variables.already_once_stopped yes}
      {NEXT i}

by this:

Code: Select all

      {FOREACH units_who_must_be_stopped i}
         {VARIABLE units_who_must_be_stopped[$i].attacks_left 0}
         {VARIABLE units_who_must_be_stopped[$i].moves 0}
         {VARIABLE units_who_must_be_stopped[$i].already_once_stopped yes}
      {NEXT i}
      [unstore_unit]
          variable=units_who_must_be_stopped[$i]
          find_vacant=no
      [/unstore_unit]

[ChaosRider]

Once i was learning about drawing, someone told me that its good to make some break for 15 or more minuts to see later easier parts of sketch which should be change. About not ending loop just check "Next" in second posted by me code... Its really wierd that i didnt see it earlier...
edit:
.moves still dont work... Its like it wasnt read by game... but .max_moves works, i can decrease this unit movement to 1/1 by sub in effect... but still this unit is able to move...

[trewe]

.moves does work, but pointless as they are reset immediately after.

change the event name in the original code to 'turn refresh'.

[ChaosRider]

Where its reset? And its not works cause i can see, if it works then stored unit could had 0 left moves after this code.
Now it looks like that:

Spoiler:

Code: Select all

#define STOPPING_AI_NEW_UNITS
		[store_unit]
			[filter]
				side=$side_number
				[filter_wml]
					[modifications]
						[trait]
							id=loyal
						[/trait]
					[/modifications]
				[/filter_wml]
				[and]
					[not]
						side=1,2,3
					[/not]
				[/and]
				[and]
					[not]
						[filter_wml]
							[variables]
								already_once_stopped=yes
							[/variables]
						[/filter_wml]
					[/not]
				[/and]
			[/filter]
			variable=unitstostop
		[/store_unit]
		{FOREACH unitstostop x}
			{VARIABLE unitstostop[$x].attacks_left 0}
			{VARIABLE unitstostop[$x].moves 0}
			{VARIABLE unitstostop[$x].already_once_stopped yes}
			[unstore_unit]
				variable=unitstostop[$x]
				find_vacant=no
			[/unstore_unit]
		{NEXT x}
		{CLEAR_VARIABLE unitstostop}
#enddef

Code is used just after creating new unit for ai side near his leader, in event with name=side turn.

[Astoria]

I think placing it in a side turn refresh should work.

[ChaosRider]

Still not, its just like game didnt read it, in my last code i had stored unit, everything was working (effect/".max_moves"/kill and many other) on this unit besides ".moves" which i dont get why. Code to create units near ai are used sometimes more than once (1 lvl units once per 2 turns/2 lvl once per 5 turn/ 3 lvl per 10 turn/ 4 lvl per 20 turn so i need to at this code end give them variable to later dont stop them). Each spawned unit (by my code, not recruited) near ai leader can be stopped only once, after spawning it. Code below dont works with & without blocked parts :].

Spoiler:

Code: Select all

#define STOPPING_AI_NEW_UNITS
	[event]
		name=side turn refresh
		[modify_unit]
			[filter]
				side=$side_number
				[not]
					side=1,2,3
				[/not]
				[filter_wml]
					[modifications]
						[trait]
							id=loyal
						[/trait]
					[/modifications]
				[/filter_wml]
				#[and]
				#	[not]
				#		[filter_wml]
				#			[variables]
				#				already_once_stopped=yes
				#			[/variables]
				#		[/filter_wml]
				#	[/not]
				#[/and]
			[/filter]
			moves=0
			attacks_left=0	
			#[variables]
			#	name=$this_unit.already_once_stopped
			#	value=yes
			#[/variables]
		[/modify_unit]
	[/event]
#enddef

Edit: I found a way how to deal with it, ofcourse its not fix my problem with not working .moves but still i reach my point, i spawn petrify units near ai leader and at player turn start i unpetrify them...
Units code:

Spoiler:

Code: Select all

#define PLACEENEMIE UNITID SIDE
[unit]
	type={UNITID}
	#x={X}
	#y={Y}
	placement=leader
	side={SIDE}
	generate_name=yes
	random_traits=no
	random_gender=yes
	canrecruit=no
	[status]
		petrified=yes
	[/status]
	[modifications]
        {TRAIT_LOYAL}
		{TRAIT_INTELLIGENT}
		[object]
		[/object]
	[/modifications]
[/unit]
#enddef

Unpetrify code:

Spoiler:

Code: Select all

#define UNSTOPPING_AI_NEW_UNITS
	[event]
		name=side 1 turn
		first_time_only=no
		[store_unit]
			[filter]
				side=4,5,6,7,8,9
				[filter_wml]
					[modifications]
						[trait]
							id=loyal
						[/trait]
					[/modifications]	
					[status]
						petrified=yes
					[/status]
				[/filter_wml]
				[and]
					[not]
						side=1,2,3
					[/not]
				[/and]
				[and]
					[not]
						[filter_wml]
							[variables]
								already_once_unstopped=yes
							[/variables]
						[/filter_wml]
					[/not]
				[/and]
			[/filter]
			variable=unitstounstop
		[/store_unit]
		{FOREACH unitstounstop a}
			{VARIABLE unitstounstop[$a].status.petrified no}
			{VARIABLE unitstounstop[$a].already_once_unstopped yes}
			[unstore_unit]
				variable=unitstounstop[$a]
				find_vacant=no
			[/unstore_unit]
			{CLEAR_VARIABLE unitstounstop}
		{NEXT a}
	[/event]
#enddef

[ChaosRider]

Now i have to ask about something else, event for weapon special named/called "Growing fury", its work well when we know what type of units will have it (as for cyclops) but what when we wish to give it in item, for any other unit? Then ofcourse we change filter type for attack special filter. After such a change everything works fine, but at attack end (in battle between two units) our unit have decreased attack dmg (its lower than it was before attacking, sometimes 0, sometimes just decreased by 3 (as in event, each not missed attack increase dmg by 3 points)). Below is code for interested one:

Spoiler:

Code: Select all

	[event]
		name=attack
		first_time_only=no
		[filter_attack]
			special=growingfury
		[/filter_attack]
		[store_unit]
			[filter]
				x,y=$x1,$y1
			[/filter]
			variable=dmgfuryunits
		[/store_unit]
	[/event]
    [event]
        name=attacker_hits
        first_time_only=no
		[filter_attack]
			special=growingfury
		[/filter_attack]
        [set_variable]
            name=unit.attack[0].damage
            add=3
        [/set_variable]
        [unstore_unit]
            variable=unit
        [/unstore_unit]
    [/event]
	[event]
        name=attack end
		first_time_only=no
		[filter_attack]
			special=growingfury
		[/filter_attack]
		[set_variable]
            name=unit.attack[0].damage
			value=$dmgfuryunits.attack[0].damage
        [/set_variable]
        [unstore_unit]
            variable=unit
        [/unstore_unit]
    [/event]
	[event]
        name=die
		first_time_only=no
		[filter_attack]
			special=growingfury
		[/filter_attack]
		[set_variable]
            name=unit.attack[0].damage
			value=$dmgfuryunits.attack[0].damage
        [/set_variable]
        [unstore_unit]
            variable=unit
        [/unstore_unit]
    [/event]
	[event]
		name=attack
		first_time_only=no
		[filter_attack]
			special=growingfury
		[/filter_attack]
		[store_unit]
			[filter]
				x,y=$x2,$y2
			[/filter]
			variable=dmgfuryunits2
		[/store_unit]
	[/event]
    [event]
        name=defender_hits
        first_time_only=no
		[filter_second_attack]
			special=growingfury
		[/filter_second_attack]
        [set_variable]
            name=second_unit.attack[0].damage
            add=3
        [/set_variable]
        [unstore_unit]
            variable=second_unit
        [/unstore_unit]
    [/event]
	[event]
        name=attack end
		first_time_only=no
		[filter_second_attack]
			special=growingfury
		[/filter_second_attack]
		[set_variable]
            name=second_unit.attack[0].damage
			value=$dmgfuryunits2.attack[0].damage
        [/set_variable]
        [unstore_unit]
            variable=second_unit
        [/unstore_unit]
    [/event]
	[event]
        name=die
		first_time_only=no
		[filter_second_attack]
			special=growingfury
		[/filter_second_attack]
		[set_variable]
            name=second_unit.attack[0].damage
			value=$dmgfuryunits2.attack[0].damage
        [/set_variable]
        [unstore_unit]
            variable=second_unit
        [/unstore_unit]
    [/event]

Edit:
Bug already found & fixed, it was not changed filter_attack for filter_second_attack in 5th event :]... (first 4 are for attacking unit, next 4 are for defending one). Also while looking for this bug i found other one, unit get doubled dmg, it was thx not added ids to events...

Spoiler:

Code: Select all

       [event]
          name=attack
		  id=mwcgrowingfurya
          first_time_only=no
          [filter_attack]
             special=growingfury
          [/filter_attack]
          [store_unit]
             [filter]
                x,y=$x1,$y1
             [/filter]
             variable=dmgfuryunits
          [/store_unit] 
		{FOREACH dmgfuryunits.attack a}
          [set_variable]
                name=unitdamage_$a
				value=$dmgfuryunits.attack[$a].damage
            [/set_variable]
		{NEXT a}
       [/event]
        [event]
            name=attacker_hits
			id=mwcgrowingfuryb
            first_time_only=no
          [filter_attack]
             special=growingfury
          [/filter_attack]
		{FOREACH dmgfuryunits.attack a}
            [set_variable]
                name=unit.attack[$a].damage
                add=3
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=unit
            [/unstore_unit]
        [/event]
       [event]
            name=attack end
			id=mwcgrowingfuryc
          first_time_only=no
          [filter_attack]
             special=growingfury
          [/filter_attack]
		{FOREACH dmgfuryunits.attack a}
          #[set_variable]
          #      name=unit.attack[$a].damage
          #   value=$dmgfuryunits.attack[$a].damage
          #  [/set_variable]
          [set_variable]
                name=unit.attack[$a].damage
				value=$unitdamage_$a
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=unit
            [/unstore_unit]
        [/event]
       [event]
            name=die
			id=mwcgrowingfuryd
          first_time_only=no
          [filter_attack]
             special=growingfury
          [/filter_attack]
		{FOREACH dmgfuryunits.attack a}
          #[set_variable]
          #      name=unit.attack[$a].damage
          #   value=$dmgfuryunits.attack[$a].damage
          #  [/set_variable]
          [set_variable]
                name=unit.attack[$a].damage
				value=$unitdamage_$a
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=unit
            [/unstore_unit]
        [/event]
       [event]
          name=attack
			id=mwcgrowingfurye
          first_time_only=no
          [filter_second_attack]
             special=growingfury
          [/filter_second_attack]
          [store_unit]
             [filter]
                x,y=$x2,$y2
             [/filter]
             variable=dmgfuryunits2
          [/store_unit]
		{FOREACH dmgfuryunits2.attack a}
          [set_variable]
                name=unitdamage2_$a
				value=$dmgfuryunits2.attack[$a].damage
            [/set_variable]
		{NEXT a}
       [/event]
        [event]
            name=defender_hits
			id=mwcgrowingfuryf
            first_time_only=no
          [filter_second_attack]
             special=growingfury
          [/filter_second_attack]
		{FOREACH dmgfuryunits2.attack a}
            [set_variable]
                name=second_unit.attack[$a].damage
                add=3
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=second_unit
            [/unstore_unit]
        [/event]
       [event]
            name=attack end
			id=mwcgrowingfuryg
          first_time_only=no
          [filter_second_attack]
             special=growingfury
          [/filter_second_attack]
		{FOREACH dmgfuryunits2.attack a}
          #[set_variable]
          #      name=second_unit.attack[$a].damage
          #   value=$dmgfuryunits2.attack[$a].damage
          #  [/set_variable]
          [set_variable]
                name=second_unit.attack[$a].damage
				value=$unitdamage2_$a
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=second_unit
            [/unstore_unit]
        [/event]
       [event]
            name=die
			id=mwcgrowingfuryh
          first_time_only=no
          [filter_second_attack]
             special=growingfury
          [/filter_second_attack]
		{FOREACH dmgfuryunits2.attack a}
          #[set_variable]
          #      name=second_unit.attack[$a].damage
          #   value=$dmgfuryunits2.attack[$a].damage
          #  [/set_variable]
          [set_variable]
                name=second_unit.attack[$a].damage
				value=$unitdamage2_$a
            [/set_variable]
		{NEXT a}
            [unstore_unit]
                variable=second_unit
            [/unstore_unit]
        [/event]