External links to GitHub

Discussion of all aspects of the website, wiki, and forums, including support requests and new ideas.

Moderators: Forum Moderators, Developers

Post Reply
User avatar
sub2pewds
Posts: 41
Joined: February 21st, 2019, 7:50 am

External links to GitHub

Post by sub2pewds » August 21st, 2019, 3:44 am

At the moment, with some exceptions (such as http://sourceforge.net/projects/wesnoth/), all external links on the wiki have a CSS effect applied, such that they contain extra content. I would like to make the following external link prefix an exception too:

https://github.com/wesnoth/wesnoth/

In order to achieve this, this CSS file needs to be edited by someone with the appropriate permissions. Where the code is currently:

Code: Select all

#content a.external[href^="https://sourceforge.net/projects/wesnoth/"]:after{display:none !important}
I believe that the code must be be edited to look like this:

Code: Select all

#content a.external[href^="https://sourceforge.net/projects/wesnoth/"]:after,#content a.external[href^="https://github.com/wesnoth/wesnoth/"]:before,#content a.external[href^="https://github.com/wesnoth/wesnoth/"]:after{display:none !important}
I am not an expert at CSS, so apologies if I have made a mistake. Could someone please do this for me? :)

User avatar
Pentarctagon
Forum Administrator
Posts: 4093
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: External links to GitHub

Post by Pentarctagon » August 21st, 2019, 3:56 am

You could also try submitting a PR to make the change here.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

User avatar
sub2pewds
Posts: 41
Joined: February 21st, 2019, 7:50 am

Re: External links to GitHub

Post by sub2pewds » August 21st, 2019, 4:22 am

Ah, thanks. That was my first time doing a PR. It can be found here: https://github.com/wesnoth/wesmere/pull/15
My reasons are that I would like for citations to point to the original GitHub files, rather than to be plain text. This is ugly without the requested modification.

Post Reply