Wesnoth Music Player (Old)

Discussion of all aspects of multiplayer development: unit balancing, map development, server development, and so forth.

Moderators: Forum Moderators, Developers

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » September 4th, 2010, 3:22 am

sounds good, though 'map renewal' probably isn't the most common way to phrase it.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

itota
Posts: 68
Joined: April 3rd, 2010, 5:27 am

Re: Pent's ports and add-ons

Post by itota » September 4th, 2010, 5:15 am

Pentarctagon wrote:sounds good, though 'map renewal' probably isn't the most common way to phrase it.
hm, how does this sound then?

Code: Select all

Created by Nosmos
Map Revised by grrr
Enemy Labels by itota
Maintainer : Pentarctagon

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » September 4th, 2010, 6:37 am

I think I'm just going to go with grrr as Previous Maintainer, since maintaining an add-on isn't just map revisions it is also WML updates/fixes.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

itota
Posts: 68
Joined: April 3rd, 2010, 5:27 am

Re: Pent's ports and add-ons

Post by itota » September 4th, 2010, 11:46 am

Pentarctagon wrote:I think I'm just going to go with grrr as Previous Maintainer, since maintaining an add-on isn't just map revisions it is also WML updates/fixes.
ok, i will have to agree with u anyway because u r the maintainer who was asked by grrr to be the next maintainer (right?).
but please dont forget. many people love Nosmos' Survival Pack and know the grrr's contribution. he was not just a maintainer for me at least.

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » September 4th, 2010, 5:38 pm

Actually what happened was that I updated my own Nosmos Survival Pack for 1.8 and was hosting games of it online and it was not updated a while after 1.8 came out, so someone (I forget who) suggested that I contact grrr to see if he would be alright with me uploading it to the server. I asked, he said sure, so I started maintaining it. I also PMed him the pbl file, so he can start maintaining/editing/whatever it again whenever he wants.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Pent's ports and add-ons

Post by Anonymissimus » September 30th, 2010, 7:04 pm

Hi,

since you mentioned you never got wmllint to work, I've run wmllint and wmlscope for you.
Attachments
wmllint_wmlscope.txt
(94.32 KiB) Downloaded 198 times
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » September 30th, 2010, 8:12 pm

cool, thanks :)
one question though, what does 'attempt to close empty scope' mean?
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Pent's ports and add-ons

Post by Anonymissimus » September 30th, 2010, 9:12 pm

Probably nothing you need to be concerned about; that message comes e.g. when you have a
#define MACRO
#enddef
- that is, a macro without any code in it defined somewhere...
Not all stuff reported by these tools should be "messured in gold" so to say. It's however easier to keep track of things by removing all messages...
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » September 30th, 2010, 11:54 pm

huh, wierd. I have no empty macros :hmm:
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » April 13th, 2011, 12:42 am

some significant updates, so i figured i'd bump this.

1. The userDefineLang file has been updated for 1.9.5.
2. I have uploaded West's Chronicles I and II to the 1.8 and 1.9 add-on servers.
3. I have made a new add-on called Music, see the OP for details.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

User avatar
Sapient
Inactive Developer
Posts: 4452
Joined: November 26th, 2005, 7:41 am
Contact:

Re: Pent's ports and add-ons

Post by Sapient » April 16th, 2011, 12:23 am

No, an attempt to close an empty scope means that your #enddef tried to close the current directive's scope (such the #define directive), but it was unable to because there wasn't such a #define or it had already been closed.

In any case it gives you a filename, directive name, and line number, so it should be easy enough to find. This error message actually originates with wmliterator component and thus if it is a false error message then that is a bug that needs to be fixed.
http://www.wesnoth.org/wiki/User:Sapient... "Looks like your skills saved us again. Uh, well at least, they saved Soarin's apple pie."

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Pent's ports and add-ons

Post by Anonymissimus » April 16th, 2011, 2:18 pm

Sapient wrote:No, an attempt to close an empty scope means that your #enddef tried to close the current directive's scope (such the #define directive), but it was unable to because there wasn't such a #define or it had already been closed.
This is apparently what's supposed to happen but it doesn't. This

Code: Select all

# 	#define MACRO
# 	#enddef
causes:
"C:\WesnothTrunk\userdata\data\add-ons\The_Earths_Gut\scenarios\test.cfg", line 286: attempt to close empty scope at #enddef line 286
"C:\WesnothTrunk\userdata\data\add-ons\The_Earths_Gut\scenarios\test.cfg", line 288: attempt to close empty scope at [/scenario] line 288
Afaik esr knows about it and did postpone it (IIRC till 1.9 ;)).
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Sapient
Inactive Developer
Posts: 4452
Joined: November 26th, 2005, 7:41 am
Contact:

Re: Pent's ports and add-ons

Post by Sapient » April 16th, 2011, 3:19 pm

Right... #enddef doesn't have to be at the beginning of the line to be recognized as a directive. However, I forgot about the case of ##enddef which would be treated as a comment regardless. Thanks.
http://www.wesnoth.org/wiki/User:Sapient... "Looks like your skills saved us again. Uh, well at least, they saved Soarin's apple pie."

User avatar
Pentarctagon
Forum Administrator
Posts: 3569
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Pent's ports and add-ons

Post by Pentarctagon » April 16th, 2011, 9:03 pm

actually, the empty scope errors seem to be caused when i have an #ifhave inside of an #ifdef or #define
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Kernigh
Posts: 107
Joined: February 13th, 2007, 10:21 pm
Location: United States
Contact:

Re: Pent's ports and add-ons

Post by Kernigh » May 6th, 2011, 2:18 am

This seems to be thread about Defense of the Goblin.

The current version, Defense of the Goblin 2.6.8 for Wesnoth 1.8, requires all players to install the era. The work-around is to use DotG map with Creep Wars era, because Creep Wars era allows any player to join. Perhaps the maintainer should add require_era=no to DotG era?

Locked