Expanding UMC Music

Create music and sound effects for mainline or user-made content.

Moderators: Forum Moderators, Developers

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » July 9th, 2012, 5:26 am

Awesome, thanks.

Also, does anyone know how to remove the cover art from .ogg files?
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

User avatar
shadowm
Site Administrator
Posts: 6479
Joined: November 14th, 2006, 5:54 pm
Location: Chile
Contact:

Re: Expanding UMC Music

Post by shadowm » July 9th, 2012, 6:31 am

Hm.

It seems you people are converting MP3 files to Ogg Vorbis. Although I imagine that in most of these cases the original PCM (.wav) was never posted or it was taken down, I thought I’d mention anyway that converting a lossy source to another lossy format is generally inadvisable due to artifact build-up. I don’t think many people would notice the difference, though — unless either the source or target encoding (or both) were done with a particularly poor quality/bit rate choice.
Author of the unofficial UtBS sequels Invasion from the Unknown and After the Storm.
Elsewhere: shadowmBlogFollow me on Twitter

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » July 9th, 2012, 6:52 am

A few were posted in .ogg files, but yeah the majority were posted as MP3s. I've been using this site for conversion and selecting High (~192 kbit/s), which I believe is a high enough bit rate.

edit - Enchanted Forest has been added to Book 4.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

User avatar
lipk
Developer
Posts: 631
Joined: July 18th, 2011, 1:42 pm
Location: Here and there and everywhere

Re: Expanding UMC Music

Post by lipk » July 24th, 2012, 2:53 pm

Facing the Front by cheeselord
Journey's End by West
Journey's End is mainline...

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » July 24th, 2012, 10:48 pm

Oh. Whoops... :oops:
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Expanding UMC Music

Post by Anonymissimus » November 30th, 2012, 10:19 pm

Hi Pent,

you apparently maintain UMC music now. I'd like to remind you that by maintaining such type of addon you have a special responsibility; you need to take into account that other people's addons may depend on yours. Thus you cannot quite easily change stuff. In my case it would have been somewhat easier if you hadn't renamed the first book (the music is apparently the same). I use #ifhave directives to conditionally use music from UMC music depending on whether the player has UMC music installed.
(In mainline and with the WLP it's similar, I (or we) try to avoid breaking addons depending on the things we change, if possible.)
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » November 30th, 2012, 11:13 pm

The name-unchanged UMC Music is still on the 1.9/1.10 server for exactly that reason. I also mentioned in my main thread that the name-unchanged version would not be re-uploaded to the 1.11+ add-on server(s).
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Expanding UMC Music

Post by Anonymissimus » November 30th, 2012, 11:41 pm

But I have the same addon version target 1.10 and 1.11 using #ifver...
Also, a3deap_DontFearTheReaper.ogg is renamed to a3deap_Dontfearthereaper.ogg for no apparent reason, but the other names stayed the same.
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » November 30th, 2012, 11:50 pm

Huh :hmm: , I don't remember doing that and can't think of a good reason why I would have. Do you mind if I change it back then?
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Anonymissimus
Inactive Developer
Posts: 2458
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: Expanding UMC Music

Post by Anonymissimus » December 1st, 2012, 12:42 am

Please do. Perhaps it's because of the case-insensitivity of the windows system.
And keep the names consistent please.
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » December 1st, 2012, 3:48 am

Fixed on both add-on servers. And there will be no more name changes to anything as far as I'm concerned.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

fabi
Developer
Posts: 1223
Joined: March 21st, 2004, 2:42 pm
Location: Germany

Re: Expanding UMC Music

Post by fabi » March 1st, 2014, 9:56 am

Hello Pentarctagon,
your music expansions don't play in the editor because the wml is not correct.

You need to define a [binary_path] and add the .ogg extension to the name= attribute.

Code: Select all

# The tracks included in this add-on were created by various authors.
# More details can be found here: http://forums.wesnoth.org/viewtopic.php?f=14&t=26079&p=394105

[binary_path]
    path="data/add-ons/UMC_Music_Book_1"
[/binary_path]

#ifdef EDITOR

[editor_music]
     
     [music]
          name=a3deap_DontFearTheReaper.ogg
          append=yes
          title="Don't Fear The Reaper"
     [/music]
     [music]
          name=a3deap_GoForTheWorldAgain.ogg
          append=yes
          title="Go For The World Again"
     [/music]
     [music]
          name=a3deap_HighInTheMountains.ogg
          append=yes
          title="High In The Mountains"
     [/music]
     [music]
          name=a3deap_HoistTheColours.ogg
          append=yes
          title="Hoist The Colors"
     [/music]
     [music]
          name=battlecry.ogg
          append=yes
          title="Battlecry"
     [/music]
     [music]
          name=calm-before-storm.ogg
          append=yes
          title="Calm Before The Storm"
     [/music]
     [music]
          name=gameplay06.ogg
          append=yes
          title="Gameplay06"
     [/music]
     [music]
          name=snowfall.ogg
          append=yes
          title="Snowfall"
     [/music]
     [music]
          name=tribal_war_song.ogg
          append=yes
          title="Tribal War Song"
     [/music]
     
[/editor_music]

#endif
edit: Shadowm just mentioned the binary path is better guarded inside the #ifdef EDITOR. I am not sure if the UMC Music expansions can't be an exception from the rule, maybe just adding a prefix to prevent naming collisions would be enough.
This would grant the music to work out of the box when used in a editor produced scenario.

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » March 1st, 2014, 7:30 pm

fabi wrote:Hello Pentarctagon,
your music expansions don't play in the editor because the wml is not correct.

You need to define a [binary_path] and add the .ogg extension to the name= attribute.

Code: Select all

# The tracks included in this add-on were created by various authors.
# More details can be found here: http://forums.wesnoth.org/viewtopic.php?f=14&t=26079&p=394105

[binary_path]
    path="data/add-ons/UMC_Music_Book_1"
[/binary_path]

#ifdef EDITOR

[editor_music]
     
     [music]
          name=a3deap_DontFearTheReaper.ogg
          append=yes
          title="Don't Fear The Reaper"
     [/music]
     [music]
          name=a3deap_GoForTheWorldAgain.ogg
          append=yes
          title="Go For The World Again"
     [/music]
     [music]
          name=a3deap_HighInTheMountains.ogg
          append=yes
          title="High In The Mountains"
     [/music]
     [music]
          name=a3deap_HoistTheColours.ogg
          append=yes
          title="Hoist The Colors"
     [/music]
     [music]
          name=battlecry.ogg
          append=yes
          title="Battlecry"
     [/music]
     [music]
          name=calm-before-storm.ogg
          append=yes
          title="Calm Before The Storm"
     [/music]
     [music]
          name=gameplay06.ogg
          append=yes
          title="Gameplay06"
     [/music]
     [music]
          name=snowfall.ogg
          append=yes
          title="Snowfall"
     [/music]
     [music]
          name=tribal_war_song.ogg
          append=yes
          title="Tribal War Song"
     [/music]
     
[/editor_music]

#endif
edit: Shadowm just mentioned the binary path is better guarded inside the #ifdef EDITOR. I am not sure if the UMC Music expansions can't be an exception from the rule, maybe just adding a prefix to prevent naming collisions would be enough.
This would grant the music to work out of the box when used in a editor produced scenario.
Thanks, I've uploaded the fixed versions to the add-on server. Also given the response when I last changed the name of something, I just put the [binary_path] inside the #ifdef.

Also, as a side note, it would be useful to have output in the stderr.txt if the editor was not able to find the track that was selected.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

fabi
Developer
Posts: 1223
Joined: March 21st, 2004, 2:42 pm
Location: Germany

Re: Expanding UMC Music

Post by fabi » March 7th, 2014, 9:10 am

Pentarctagon wrote:Thanks, I've uploaded the fixed versions to the add-on server.
Thank you very much. It is nice to have so many extra music available. I also like to express my gratitude to the composers of the music, of course.
Also given the response when I last changed the name of something, I just put the [binary_path] inside the #ifdef.
Okay, I don't agree that backwards compatibility has to be maintained at all costs, but that only said as a side note.
Also, as a side note, it would be useful to have output in the stderr.txt if the editor was not able to find the track that was selected.
Yes, I implemented warnings about non found music tracks when the list is created. Meaning they no longer appear in the playlist.

User avatar
Pentarctagon
Forum Administrator
Posts: 3513
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Expanding UMC Music

Post by Pentarctagon » March 7th, 2014, 6:16 pm

fabi wrote:Yes, I implemented warnings about non found music tracks when the list is created. Meaning they no longer appear in the playlist.
Thanks, that found two other errors that I had missed :)

Also, one thing I've been meaning to ask for a while, would it be possible to have it not auto-scroll back to the top of the list of music after selecting a track? Selecting multiple tracks can get really annoying, especially in my case where I have 210 songs installed plus mainline.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

Post Reply