Modification can affect resistances & movement consts

joshudson · Post by **joshudson** » April 26th, 2006, 3:55 am

See "Wose Traits": http://www.wesnoth.org/forum/viewtopic.php?t=11010
These threads are linked by nature.

Analysis for patch:
in unit.cpp:add_modification, merge the [movement_costs] and [defense] subelements into cfg_

I hope to have a working patch soon, but just in case I don't, this will allow the next person to get a warm start.

My complements on your design.

joshudson · Post by **joshudson** » April 26th, 2006, 7:06 am

First patch. Allows for set new evasions, resistances, and movesment_costs.

Included a test campaign. Note the pre-existing wose has three weird traits.
Costs 2 mp to move in forest
80% blade resistance
60% evasion in forest

Enjoy :)

Website · Post by **Xan** » April 26th, 2006, 11:58 am

Segmentation Fault

* * *

It is possible for config::child("foo") to return NULL.

Website · Post by **Xan** » April 26th, 2006, 12:05 pm

Oh, and only allowing setting the values is really restrictive.

Most modifications can also be removed.

joshudson · Post by **joshudson** » April 26th, 2006, 4:38 pm

Hmm, you're right. Remove doesn't actually work. I'll see what I can do.
I've been thinking about deltas myself.

joshudson · Post by **joshudson** » April 26th, 2006, 8:59 pm

Changed the patch to use deltas instead of new constants.
Couldn't do both. For some reason, the parser converts "+1" to "1".
Removal of modifications works.

joshudson · Post by **joshudson** » April 26th, 2006, 10:13 pm

Grrr. Removal of modifications worked with the "set" method, but not with the "delta" method.

Post by **Darth Fool** » April 27th, 2006, 1:25 am

You could use two different tags, one for setting and one for modding.

joshudson · Post by **joshudson** » April 27th, 2006, 3:50 am

Excellent solution. And hey, that fixed the removal code (at least I think it did).
Syntax invented (I hope this posts right):

[trait]
id=hardy
name= _ "Hardy"
description = "Blade Resistant"
[effect]
apply_to=resistance
[resistance]
blade=-40
[/resistance]
[/effect]
[/trait]
[trait]
id=treeish
name = _ "Tree-ish"
description = "Hard to hit in forest"
[effect]
apply_to=defense
replace=yes
[defense]
forest=50
[/defense]
[/effect]
[/trait]

Particularly, notice "replace=yes" near the bottom. It defaults to no. If
set, the old value is discarded. If cleared, the value is added. Be
careful, to add resistances or defense, you must subtract (the
same is true everywhere else these values are visible in WML).

Patch, Take 3.

joshudson · Post by **joshudson** » April 28th, 2006, 3:16 am

Patch is now on patches.wesnoth.org. https://gna.org/patch/index.php?func=de ... tem_id=541

joshudson · Post by **joshudson** » May 17th, 2006, 5:45 am

Update: XAN committed a slightly modified version of the patch.