The Battle for Wesnoth Forums

'special overlay' is part of the WC2 campaign. It is enabled by the 'enable unitmarker' settings in the WC2 settings menu and you can find the code in https://github.com/wesnoth/wesnoth/blob/be04167fff0468e84189134e2e909341bcd260ce/data/campaigns/World_Conquest/lua/optional_mechanics/unitmarker.lua ...

Hi, i just uploaded this to the 1.17 (dev version) of wesnoth, i'll probably upload it to the 1.16 too after some testing.

Except from (actually quite a lot) code cleanups nothing has changed much so far.

Yes these are mostly caused by badly written addons, some addons seem to include other addons data via macro inclusion, however this is a very bad things to do since It parses the addons basicially twice (or even more times), resulting in much longer loading times. It evades the addon versions check...

The config loading code doesn't differ between manual edits and addon updates though.

The user doesn't know whether an addond that he has installed does this.

It doesn't. I suspect that they reason is that in theory on addon can use another addon via {/other_addon/...}

Yes I've got loads of warning preprocessor: Redefining macro caused by various add-ons I've installed. I've had them always. I do know what causes them and how to get rid of them but since they're all in addons maintained by others any fix would only last until it got updated. Do these cause the ca...

In your log ageless took 7 seconds, i checked on disk and the cache file for ageless is 20 mb and 2mb compressed, i checked on my machine and loading ageless took 0.5 seconds. Without cache it took 2 seconds. 7 seconds is quite a lot imo, especially since the io part should basically be reading that...

Also are these normal times or did you clear the cache before doing this testing? Because if you cleared the cache before it woipd be less bad of course.

Themewml is actually quite old, (and there have been thoughs about replacing/changing it ) I doubt anyone in the current dev team knows many details of themewml.

Hmm, quite interesting, some of these times are quite huge (I'm salso assuming ms means microseconds here since otherwise I'd be way to much), do you with the debug info think it took longer than usual ? I think the reason why each addon is listed twice it because they are once loaded when you start...

You can start Wesnoth with --log-debug=config and then search in the log file for lines like Loading add-on to check how long it took to load a certain addon. But be aware that logging itself might also Increase loading times (since it needs to write all of this stuff to a file, depending on how muc...

Thinking about it, it would indeed be nice if the loading screen would show which addon is currently being loaded though. Iirc the reason why it currently doesn't is that the loadingscreen::progress function doesn't take a string but only enum/int parameters (because those are atomic, and the loadin...

When you have a lot of add-ons reading and creating the cache can take quite some time, also it can happen that a particular addon is slow to load (because it's written badly) But: usually it shouldn't try to reload the cache when joining a game (only when you join the sever) unless that game uses a...

Your welcome

And note to self: we should consider redesigning this api a bit, having an attribute and a subtag with the same name could be problematic in some cases. Maybe renaming [result] to [side_result] or similar.