Search found 2044 matches

by Boucman
June 18th, 2013, 8:16 pm
Forum: Coder’s Corner
Topic: A question of unit_animation::get_end_time()
Replies: 5
Views: 1792

Re: A question of unit_animation::get_end_time()

that was fast, thx a million
by Boucman
June 17th, 2013, 9:12 pm
Forum: Coder’s Corner
Topic: A question of unit_animation::get_end_time()
Replies: 5
Views: 1792

Re: A question of unit_animation::get_end_time()

wow

huh

yes...

obviously wrong here... I need to do a git checkout to fix that... unless someone beats me to it :P
by Boucman
May 16th, 2013, 5:23 pm
Forum: Art Development
Topic: Cavalry Base Sprites
Replies: 22
Views: 12253

Re: Cavalry Base Sprites

dresses are particularly annoying when riding horses. Even in human society riding dresses were actually trousers with a buttoned flat that allowed to free the legs when riding. Elves seems not to have probelms with females wearing trousers (see archer line etc...) so I would expect a female scout t...
by Boucman
March 9th, 2013, 9:06 am
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

ok, it's a bit more clear, I understand why you need a new C++ side feature (to ease writing macro) so let's get all the patches floating around in and then we'll see your idea.

Btw, are you on IRC from time to time ? i'd be interested in discussing a bit with you...
by Boucman
March 4th, 2013, 7:15 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

not sure I understand the meaning of current_time would it be a frame_start_time or something ?
by Boucman
March 3rd, 2013, 9:51 pm
Forum: Coder’s Corner
Topic: wmllint++ - wmllint improved!
Replies: 8
Views: 3322

Re: wmllint++ - wmllint improved!

i'm not sure I understand, are your patches submitted ? if yes i'll ping esr so he reviews them
by Boucman
February 24th, 2013, 11:50 am
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

hmm be very carefull with your testing here. I'm pretty sure image defaults to the base fame and i'm almost certain it doesn't use the last seen image since that would imply complicated code I didn't put in. however I know from years of falling into the same traps in the animation engine that durati...
by Boucman
February 24th, 2013, 8:35 am
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

I am not sure what I see here... what you wrote is perfectly valid with the current syntax because IIRC duration=1 if nothing is specified but if nothing is specified image= will default to the base image for the unit which is not what you want. if you set image= to the image that was just before th...
by Boucman
February 22nd, 2013, 8:52 pm
Forum: Coder’s Corner
Topic: wmllint++ - wmllint improved!
Replies: 8
Views: 3322

Re: wmllint++ - wmllint improved!

In this particular case, and since it's going for wmllint maintainer, it's fine to post patches for wmllint, no need to learn c++

I'm probably stating the obvious but it's always better to state it.

your current wmllint++ could probably be cut into reviewable patches and that would do the trick
by Boucman
February 11th, 2013, 8:25 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

ok, i'll look into your patch... i'm not sure how looping works anymore so i'll hve to look into it. don't hold your breath.

we are speaking about standing animations I guess, since idle animations don't loop

i'm not sure how it works anymore but I remember it was tricky...
by Boucman
February 9th, 2013, 4:27 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

looks perfect, i'm looking forward to your code...

as for the frame, you've pinned what they are pretty well. I'd suggest having the progressive_image_locator as a separate patch so I can proofread one piece at a time, but I think we agree on what is to be done

let's go for it
by Boucman
February 6th, 2013, 8:52 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

I see what you are saying, and would agree wholeheartedly if there weren't cases like this: #define MISSILE_FRAME_MUZZLE_FLARE_HIT_DIAG_SOUTH START_X START_Y missile_start_time=-250 missile_offset=0.5~1.1:250,1.1~1.5:200,1.5~1.7:360 missile_halo_x={START_X}~0 missile_halo_y={START_Y}~0 [missile_fra...
by Boucman
February 3rd, 2013, 9:11 am
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

img[1:50,2:50,3:100] comes for free with the rules we already have. moreover the most common case (all elements have the same fixed duration) becomse img[1~3]:50 I think you are mistaken a bit here. With the current patch any '~' character has to have only numbers either side and an 'atoi' c++ func...
by Boucman
January 30th, 2013, 9:12 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

ok, answring a couple of points ~ vs - : ok i'm convinced i'll apply that part of the patch now to be big debate... there are all sorts of good stuff flying around but the general conversation is starting to be confusing... so i'll do my best to answer what is flying around there are various proposa...
by Boucman
January 28th, 2013, 9:25 pm
Forum: Coder’s Corner
Topic: Simplifying animation frame wml
Replies: 41
Views: 8942

Re: Simplifying animation frame wml

ok, couple of replies here... Pentarctagon : that depends on compiler version, which is why it wasn't caught in the original patch, fixed... ~ vs - : I don't mind as long as it's compatible, slightly favor ~ because - might lead to ambiguities with file names duration : i don't like where you're goi...