shadowmaster wrote:Fixing bug #18294 was the point, and the result is just really generalizing the sorting order in the English language (since type ids match the English name by convention except where it’s required due to name collisions) to localizations. I don’t see any reasons why scenario authors should be able to customize the list order with dirty invisible hacks like that either; if they think they need a specific list order then perhaps they shouldn’t be using a recruit list in the first place.
PapaSmurfReloaded wrote:I don't see the reason to forbid players to do it(nor why you call it a " dirty invisible hack"), perhaps someone wants to do it to make the recruit list more neat and organized(duh)?
Luther wrote:The recruit list needs to be alphabetical by default, because that's the easiest way for players to find the units they want. If you must customize the sort order, please make a feature request for a new attribute to the [multiplayer_side] tag. The reason what you were doing is a dirty hack is because the unit type id needs to reflect the actual name of the unit type. (If someone mixed in some of your units with a campaign or another era, they would have an oddly sorted recruit list for no apparent reason.) Your hack is invisible because the player cannot directly see how their recruit list is being sorted.
EDIT: In general principal, it's not up to an element (e.g. unit type) of a list (e.g. recruit list) to decide how a list shall be sorted. If you try to do that, you end up polluting the element with data that has nothing to do with the element itself. Sorting the list should be the responsibility of the [multiplayer_side] or [side] tags. That's why I suggested the feature request.
PapaSmurfReloaded wrote:Calling it a hack sounds rather odd, and I still don't get why the negative connotation, or what's supposed to be "bad" about it.
PapaSmurfReloaded wrote:I don't think the average player even cares about how units are sorted either(I have yet to see someone saying "OMFG look the units aren't alphabetically sorted, what the ****!").
PapaSmurfReloaded wrote:And I still think there are quite more important issues in Wesnoth right now than whether units must have the same ID and name for no apparent reason.
Users browsing this forum: DarrenG and 1 guest