Weapon specials with a filter on opponent - 1.11

[A Guy]

At the moment, on 1.11.5, weapon specials always show the modified damage if the turn is appropriate for offense or defense. This is a bit misleading for custom weapon specials where boosted attacks/damage is the exception, not the norm (e.g. a weapon with a damage boost against elves.) I propose that a weapon with a special which triggers based on the opponent shows the base attacks/damage by default.

[Ravana]

Would be nice to have that as option, as old player I find it easier to just do necessary calculations. (That is mostly about charge but if openers idea happens I suppose editing that key for charge locally wouldnt cause oos)

[sur.nhm]

At the moment, on 1.11.5, weapon specials always show the modified damage if the turn is appropriate for offense or defense. This is a bit misleading for custom weapon specials where boosted attacks/damage is the exception, not the norm (e.g. a weapon with a damage boost against elves.) I propose that a weapon with a special which triggers based on the opponent shows the base attacks/damage by default.

I'm not sure what you're talking about - weapon specials that inflict more (or less) damage based on a parameter that isn't the unit's resistances?

[A Guy]

At the moment, on 1.11.5, weapon specials always show the modified damage if the turn is appropriate for offense or defense. This is a bit misleading for custom weapon specials where boosted attacks/damage is the exception, not the norm (e.g. a weapon with a damage boost against elves.) I propose that a weapon with a special which triggers based on the opponent shows the base attacks/damage by default.

I'm not sure what you're talking about - weapon specials that inflict more (or less) damage based on a parameter that isn't the unit's resistances?

Yes. Right now, if you have a weapon special which inflicts bonus damage on, say, leader units, the weapon will always show the increased damage on the tooltip - you have to mouse over it to see the actual damage it'd inflict in most cases.

[JaMiT]

What is the WML for the special(s) you have in mind?
(This might be a bug rather than a feature request, but I'll have to see what's happening within the code to be sure.)

[A Guy]

On my phone, so can't copy the code right now. The [filter_opponent] filters for units with upkeep=loyal, or canrecruit=yes, or not levels 0,1, or 2.

EDIT: Here it is.

Code: Select all

    [chance_to_hit]
        id=herobane
        name= _ "herobane"
        name_inactive=
        description= _ "Against loyal units, leaders, or high-leveled units, this weapon has a 20% higher chance to hit, and 20% extra damage."
        description_inactive=
		add=20
        [filter_opponent]
            [filter_wml]
                upkeep=loyal
            [/filter_wml]
            [or]
                canrecruit=yes
            [/or]
            [or]
                [not]
                    level=0
                [/not]
                [not]
                    level=1
                [/not]
                [not]
                    level=2
                [/not]
            [/or]
        [/filter_opponent]
    [/chance_to_hit]
    [damage]
        id=herobane_damage
        multiply=1.2
        [filter_opponent]
            [filter_wml]
                upkeep=loyal
            [/filter_wml]
            [or]
                canrecruit=yes
            [/or]
            [or]
                [not]
                    level=0
                [/not]
                [not]
                    level=1
                [/not]
                [not]
                    level=2
                [/not]
            [/or]
        [/filter_opponent]
    [/damage]