harm_unit doesnt fire advance event when experience=yes

Having trouble with the game? Report issues and get help here. Read this first!

Moderator: Forum Moderators

Forum rules
Before reporting issues in this section, you must read the following topic:
Post Reply
gfgtdf
Developer
Posts: 1431
Joined: February 10th, 2013, 2:25 pm

harm_unit doesnt fire advance event when experience=yes

Post by gfgtdf »

my problem is:
harm_unit doesnt fire post advance event when experience=yes.
using wesnoth 10.6 on win 7 x64.

is this intendet? (if yes then why?).

i think the reason is, that harm_unit uses unstrore unit at the end with advance = yes and fire_event = no by default.
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
Anonymissimus
Inactive Developer
Posts: 2461
Joined: August 15th, 2008, 8:46 pm
Location: Germany

Re: harm_unit doesnt fire advance event when experience=yes

Post by Anonymissimus »

Probably not intended. I added [unstore_unit]fire_event= some time after harm_unit was added and chose default no, which should have changed harm_unit's behavior in that aspect.
You can report it as a bug at gna: http://gna.org/bugs/?group=wesnoth
projects (BfW 1.12):
A Simple Campaign: campaign draft for wml startersPlan Your Advancements: mp mod
The Earth's Gut: sp campaignSettlers of Wesnoth: mp scenarioWesnoth Lua Pack: lua tags and utils
updated to 1.8 and handed over: A Gryphon's Tale: sp campaign
gfgtdf
Developer
Posts: 1431
Joined: February 10th, 2013, 2:25 pm

Re: harm_unit doesnt fire advance event when experience=yes

Post by gfgtdf »

hm i dont find a "post bug" button, do i have to Create anaccount?
and when i post it do i have to Assigned to it to someone?

EDIT: problems solved, found the button
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
User avatar
Elvish_Hunter
Posts: 1575
Joined: September 4th, 2009, 2:39 pm
Location: Lintanir Forest...

Re: harm_unit doesnt fire advance event when experience=yes

Post by Elvish_Hunter »

Fixed in master: http://git.io/YWkPPA .
However, I'm undecided if this fix should be backported to 1.10 or not, because we don't have current plans for a 1.10.7 release, and this may cause OoS problems if a fixed version plays against a non-fixed version. :hmm:
Current maintainer of these add-ons, all on 1.16:
The Sojournings of Grog, Children of Dragons, A Rough Life, Wesnoth Lua Pack, The White Troll (co-author)
User avatar
ivanovic
Lord of Translations
Posts: 1149
Joined: September 28th, 2004, 10:10 pm
Location: Germany

Re: harm_unit doesnt fire advance event when experience=yes

Post by ivanovic »

Elvish_Hunter wrote:Fixed in master: http://git.io/YWkPPA .
However, I'm undecided if this fix should be backported to 1.10 or not, because we don't have current plans for a 1.10.7 release, and this may cause OoS problems if a fixed version plays against a non-fixed version. :hmm:
It should not be backported if it would result in OOS errors.
Post Reply