Unilt filter for different healing

[pkz]

I am trying to filter out units with the heals +4 and heals +8 separately. this one works :
[filter]
[filter_wml]
[abilities]
[heals]
value=4
[/heals]
[/abilities]
[/filter_wml]
[/filter]

gives me only units with healing +4

this one though does not :
[filter]
[filter_wml]
[abilities]
[heals]
value=8
[/heals]
[/abilities]
[/filter_wml]
[/filter]

It gives me units with heals +4 or Heals +8

i also tried this:
[filter]
[filter_wml]
[abilities]
[heals]
value=4
[/heals]
[/abilities]
[/filter_wml]
[not]
[filter_wml]
[abilities]
[heals]
value=8
[/heals]
[/abilities]
[/filter_wml]
[/not]
[/filter]

Any ideas?

[Speedbrain]

Did it store an empty set from your last example?
I'm no master of coding or WML, but it seems the 4 and the 8 should be switched in your last example. You want all the 8's, NOT the 4's, right?

[Dixie]

Look at how they are defined in the core macros of the game:

Spoiler:

Code: Select all

#define ABILITY_HEALS
    # Canned definition of the heal+4 ability to be included in an [abilities] clause.
    [heals]
        value=4
        id=healing
        affect_allies=yes
        name= _ "heals +4"
        female_name= _ "female^heals +4"
        description=  _ "Heals +4:
Allows the unit to heal adjacent allied units at the beginning of our turn.

A unit cared for by this healer may heal up to 4 HP per turn, or stop poison from taking effect for that turn.
A poisoned unit cannot be cured of its poison by a healer, and must seek the care of a village or a unit that can cure."
        affect_self=no
        poison=slowed
        [affect_adjacent]
            adjacent=n,ne,se,s,sw,nw
        [/affect_adjacent]
    [/heals]
#enddef

#define ABILITY_EXTRA_HEAL
    [heals]
        value=8
        id=healing
        affect_allies=yes
        name= _ "heals +8"
        female_name= _ "female^heals +8"
        description= _ "Heals +8:
This unit combines herbal remedies with magic to heal units more quickly than is normally possible on the battlefield.

A unit cared for by this healer may heal up to 8 HP per turn, or stop poison from taking effect for that turn.
A poisoned unit cannot be cured of its poison by a healer, and must seek the care of a village or a unit that can cure."
        affect_self=no
        poison=slowed
        [affect_adjacent]
            adjacent=n,ne,se,s,sw,nw
        [/affect_adjacent]
    [/heals]
#enddef

#define ABILITY_UNPOISON
    # Canned definition of the cure-poison ability to be included
    # in an [abilities] clause.
    [heals]
        affect_allies=yes
        id=curing
        name= _ "cures"
        female_name= _ "female^cures"
        description= _ "Cures:
A curer can cure a unit of poison, although that unit will receive no additional healing on the turn it is cured of the poison."
        affect_self=no
        poison=cured
        [affect_adjacent]
            adjacent=n,ne,se,s,sw,nw
        [/affect_adjacent]
    [/heals]
#enddef

#define ABILITY_CURES
    # Canned definition of the cure ability (which entails heal+8) to be
    # included in an [abilities] clause..
    {ABILITY_UNPOISON}
    {ABILITY_EXTRA_HEAL}
#enddef

If you want to filter the mainline Cures, maybe you could use the invisible UNPOISON ability?

Code: Select all

[filter]
  ability=curing
[/filter]

If you have made some costum healing abilities/have a unit with the EXTRA_HEAL but not UNPOISON... I dunno, create a costum ability instead of using the mainline ones and just give it a different id?

Also: ninja's but speedbrain's comment makes sense.

[Anonymissimus]

Why do HEAL and EXTRA_HEAL have the same id in mainline ? It doesn't make much sense. Then you could filter easily with ability=...
It looks like filter_wml cares for the [heals] tag but not for value=, would explain the experienced behaviour.
You could do (in your custom abilities):

Code: Select all

#undef ABILITY_EXTRA_HEAL
#define ABILITY_EXTRA_HEAL
    [heals]
        value=8
        id=extra_healing
...

So mainline and custom units with this ability are using your custom extra_heal which matches the core one except for the id.

[pkz]

Dixie, that type of filter works, and is simples, but does not differentiate between a heal +4 and a heal +8.. i need a way of filtering them seperatly, for two different actions.

Speedbrain, not it catches the unit. the filter for +8 works fine, as it should. but the filter for +4 picks up the +8 units also. its as if its reading it as all units with that number or greater.

Anonymissimus, not sure how i could apply your idea. how can i get the script to change the id for one (+4) but not the other (+8). I would still need to filter the units apart. and if i can do that i'm laughing.

[Anonymissimus]

Anonymissimus, not sure how i could apply your idea. how can i get the script to change the id for one (+4) but not the other (+8). I would still need to filter the units apart. and if i can do that i'm laughing.

Put that among your utils/abilities.cfg - the core definition except for the #undef and the changed id, to substitute core's ABILITY_EXTRA_HEALING:

Spoiler:

Code: Select all

	#undef ABILITY_EXTRA_HEAL
	#define ABILITY_EXTRA_HEAL
		[heals]
			value=8
			id=extra_healing
			affect_allies=yes
			name= _ "heals +8"
			female_name= _ "female^heals +8"
			description= _ "Heals +8:
This unit combines herbal remedies with magic to heal units more quickly than is normally possible on the battlefield.

A unit cared for by this healer may heal up to 8 HP per turn, or stop poison from taking effect for that turn.
A poisoned unit cannot be cured of its poison by a healer, and must seek the care of a village or a unit that can cure."
			affect_self=no
			poison=slowed
			[affect_adjacent]
				adjacent=n,ne,se,s,sw,nw
			[/affect_adjacent]
		[/heals]
	#enddef

Then in any SUF do

Code: Select all

		[filter]
			ability=healing
		[/filter]
		[filter]
			ability=extra_healing
		[/filter]

[Dixie]

Dixie, that type of filter works, and is simples, but does not differentiate between a heal +4 and a heal +8.. i need a way of filtering them seperatly, for two different actions.

Are you sure? Have you tried it? As I understand it, all mainline units who have heal +8 (id=healing) also have unpoison (id=curing), and none of those that have haling +4 (id=healing) have unpoison.

Thus, you could filter heal+4 like this:

Code: Select all

[filter]
  ability=healing
 [not]
  ability=curing
 [/not]
[/filter]

and heal+8 like this:

Code: Select all

[filter]
  ability=curing
[/filter]

Note that even if it requires a few lines of additionnal code, I think Anonymissimus's way of doing it is pretty valid too.

[silene]

It looks like filter_wml cares for the [heals] tag but not for value=, would explain the experienced behaviour.

No, the code in 1.8 looks sensible, and it really should be looking at value. By the way, I haven't been able to reproduce the issue: units without value=8 are not matched for me.

At the very least, it helped me notice that [filter_wml] never worked in trunk. (If the unit had more attributes than the ones in the filter, it would fail.)