BfW 1.4.4, SoF, Hills of the Shorbear clan does not end.

[energyman76c]

Hi, I am in the middle of that scenario, Victory conditions:
all heros in the cave - check
no enemies in the cave - check
end of the scenario - no.

wesnoth
Battle for Wesnoth v1.4.4
Started on Sat Aug 9 20:29:39 2008

Checking video mode: 1360x754x32...
setting mode to 1360x754x32
set locale to 'C@wesnoth'
set locale to 'C@wesnoth'
set locale to 'C@wesnoth'
no location found for 'data/campaigns/Raajal/translations', not adding textdomain
loadscreen: filesystem counter = 196
loadscreen: binarywml counter = 32528
loadscreen: setconfig counter = 44
loadscreen: parser counter = 244
set locale to 'C@wesnoth'
set locale to 'C@wesnoth'
set locale to 'C@wesnoth'
loadscreen: filesystem counter = 0
loadscreen: binarywml counter = 20215
loadscreen: setconfig counter = 0
loadscreen: parser counter = 4
scenario: '5_Hills_of_the_Shorbear_Clan'
next_scenario: ''

system is gentoo linux, on amd64. Installed via ebuild.

[zookeeper]

Eh, sorry, it's a bug in the scenario code. The scenario is supposed to end when you got everyone within six hexes of the central keep and no enemies are in that area...except that the center of that area is erroneously in 19,16 and not in 19,17 where it should be. So just kill everything within a radius of six around 19,16 and have all your heroes in that area too, and it should work.

[energyman76c]

thanks, that worked.

[zookeeper]

For those interested, here are fixed scenario files for both 1.4 and 1.5. Replace the original file in Wesnoth/data/campaigns/Sceptre_of_Fire/scenarios/ and (after restarting Wesnoth, naturally) restart the scenario from the beginning-of-scenario save or via the previous scenario.

[energyman76c]

btw, there seems to be missing dialog in Caverns on Flame.

[zookeeper]

btw, there seems to be missing dialog in Caverns on Flame.

For some reason, you're completely missing Thursagan there. I don't know how that's possible. Did he actually complete the sceptre on the forge in the previous scenario? Or did he disappear at some other point?

[energyman76c]

in the previous scenario I killed the dragon and the elvish leader - one round before the sceptre was finished. So Thursagan had no time to reappear.

[energyman76c]

kill the dragon, next scenario, no Thursagan and lots of:
20080810 17:25:08 error engine: player not found!

[zookeeper]

in the previous scenario I killed the dragon and the elvish leader - one round before the sceptre was finished. So Thursagan had no time to reappear.

Right. It definitely wasn't intended to be possible to kill the elvish leader, and thus the scenario wasn't defined to not end when all enemy leaders are killed...the easy workaround is to just not kill the elvish leader.

I'll commit the fix (an addition of a victory_when_enemies_defeated=no to the [scenario]) to that too.