How to return some old good features?

Discussion and development of all aspects of the game, including AI improvements and new engines.

Moderators: Developers, Forum Moderators

How to return some old good features?

Postby vicza » April 19th, 2008, 9:24 am

In earlier versions (like 1.3.7-1.3.10) there were some features I liked (mostly visual ones, but still nice) and which were later for some reason removed/changed. So I thought: if in Linux I have to compile Wesnoth anyway, maybe I could change the code to return them back? The features are these:

1) Smooth decreasing of HP-bar during fight. I wrote already about it here.

2) When a unit moved across some hard territory (like mountains or water) its moving was slowed down.

3) After scenario finishing, "End turn" button changed to "End scenario" one, but the screen was not grayed, like currently. I don't need this graying to understand that scenario is finished, it only troubles me to view the final position.

So, could anyone suggest me, what could I change back in the code, to return these features?
vicza
 
Posts: 238
Joined: January 16th, 2008, 11:40 pm
Location: Moscow

Re: How to return some old good features?

Postby megane » April 19th, 2008, 10:01 am

For 3 you can just change wesnoth/data/core/images/terrain/darken-linger.png (to a blank hex, if you desire).
that little girl's parents were attacked by ninjas - generic npc
hee hee! - little girl
megane
Art Contributor
 
Posts: 410
Joined: October 30th, 2006, 4:55 am
Location: The Big Ö (a.k.a. Austria)

Re: How to return some old good features?

Postby AI » April 19th, 2008, 4:20 pm

While I haven't much noticed the removal of #1, I still miss feature #2 and I have no idea why it was removed.
AI
UMC-Dev Cultist
 
Posts: 2395
Joined: January 31st, 2008, 8:38 pm

Re: How to return some old good features?

Postby vicza » April 19th, 2008, 5:20 pm

megane wrote:For 3 you can just change wesnoth/data/core/images/terrain/darken-linger.png (to a blank hex, if you desire).

O, thank you!


Still wondering about two other features...

AI wrote:While I haven't much noticed the removal of #1, I still miss feature #2 and I have no idea why it was removed.

Yes. I've just checked, both 1 and 2 were dropped in version 1.3.13. And (of course) no mention of it in the changelog. :x
vicza
 
Posts: 238
Joined: January 16th, 2008, 11:40 pm
Location: Moscow

Re: How to return some old good features?

Postby Vendanna » April 19th, 2008, 9:07 pm

vicza wrote:1) Smooth decreasing of HP-bar during fight. I wrote already about it here.


Probably some bug, or unit dieing for damage before the hp bar left down (knights etc that had too much hp, in the end, while looking nice I think it slowed the pace of the fight) there should be something on the forum about that.

2) When a unit moved across some hard territory (like mountains or water) its moving was slowed down.


It acted weirdly with units using walking animations (since if the animation was longer than what they needed to move from one tile to the other it would hang the animation) in the end, it was talked why it was removed tought don't know in which part of the forum was.
"Mysteries are revealed in the light of reason."
User avatar
Vendanna
 
Posts: 608
Joined: September 16th, 2006, 10:07 pm
Location: Spain

Re: How to return some old good features?

Postby Dave » April 19th, 2008, 9:09 pm

I think that #1 and #2 were both great features. I have no idea why they were removed. I think they should be put back in.

David
“At Gambling, the deadly sin is to mistake bad play for bad luck.” -- Ian Fleming
Dave
Lead Developer
 
Posts: 6960
Joined: August 17th, 2003, 5:07 am
Location: Texas

Re: How to return some old good features?

Postby Alink » April 19th, 2008, 11:15 pm

Probably better to ask boucman about #1 and #2, but IIRC it was for technical reasons. The new powerful animation engine was some serious changes, and these 2 features were a bit hard to maintain (or priority was given to other new important bugs). A possible explanation is that both need some synchronization between "variable" stuff (HP lost, type of terrains) and the length/speed of the animation, which with the new freedom of the engine is less easy to have.

In fact, someone assigned #1 to me shortly before 1.4 but I was less active at that time and since it seems a bit tricky (probably need fake HP), I didn't wanted to risk introducing nasty bugs (keep incorrect HP bars if anim is interrupted) for such little aesthetic detail. I still hope that we can add it in 1.5, but I doubt that we backport it to 1.4.x, sorry.

Not idea if #2 is still planned.
Alink
Developer
 
Posts: 181
Joined: March 5th, 2007, 6:45 am
Location: Belgium

Re: How to return some old good features?

Postby Boucman » April 20th, 2008, 9:14 am

#1 was removed because the HP bar is directly liked to the unit's HP. So to have this feature we had to have the unit HP decreased by the animation engine during the animation. This was a very bad decoupling. This could be problematic because the game engine had to know the arcanes of the anim engine to guess if it should decrease the HP itself or delegate that work to the anim engine.

this could be added back if/when the halos and bar code is rethought, but that's quite tricky

#2 was removed after lots of thought, again because it was inducing some ugly code coupling in the anim engine. basicaly, this means that the "sliding speed" couldn't be set in WML, because the engine had to force its own sliding (WML cannot make a terrain dependant sliding) It also made things very tricky for units that did not want to have that feature.



#1 could probably be added back using fake units during the fight, but that pulls another truckload of problems with it... reviewing how fake units are used is on my todo list, but it's a big can of worms

#2 could be done by playing on the animation speed instead of the sliding, but again that means that units that don't want to use it can't disable the feature. hmm

yeas that would work...

please write bugs, assign to me so I don't forget them, but don't expect anything soon
Fight key loggers: write some perl using vim
Boucman
Patch Monkey
 
Posts: 2119
Joined: March 31st, 2004, 1:04 pm

Re: How to return some old good features?

Postby vicza » April 20th, 2008, 12:12 pm

Still, I don't understand. #1 was in versions 0.9-1.0. Then, it reappeared in 1.3.3... just to disappear again in 1.3.13? Why? What so special happened inbetween 1.3.12 and 1.3.13 that this feature has suddenly became so undesirable? If it worked previously, why it can't work now?

please write bugs, assign to me so I don't forget them

Actually, there is a bug about #1. Assigned to Alink, BTW.
vicza
 
Posts: 238
Joined: January 16th, 2008, 11:40 pm
Location: Moscow

Re: How to return some old good features?

Postby Boucman » April 20th, 2008, 12:29 pm

thx, reassigned to me

please open a second one for the speed on land
Fight key loggers: write some perl using vim
Boucman
Patch Monkey
 
Posts: 2119
Joined: March 31st, 2004, 1:04 pm

Re: How to return some old good features?

Postby AI » April 20th, 2008, 1:15 pm

Bug #11525, you're already added as CC.
AI
UMC-Dev Cultist
 
Posts: 2395
Joined: January 31st, 2008, 8:38 pm

Re: How to return some old good features?

Postby Boucman » April 20th, 2008, 1:26 pm

thx, reassigned
Fight key loggers: write some perl using vim
Boucman
Patch Monkey
 
Posts: 2119
Joined: March 31st, 2004, 1:04 pm


Return to Coder’s Corner

Who is online

Users browsing this forum: No registered users and 0 guests

cron