"What advances to the unit" -tags
Moderator: Forum Moderators
"What advances to the unit" -tags
Would people appreciate if I would make "which unit advances to this unit" -tags (or similar) into the Help section in-game?
If, then I would try and get it ready before the Devs release 1.2.0, though if this has been implemented already (in the SNV version), then of course I won't do it...
jg
P.S: Didn't really think it would go into the Developer's discussion because I'm not one!
If, then I would try and get it ready before the Devs release 1.2.0, though if this has been implemented already (in the SNV version), then of course I won't do it...
jg
P.S: Didn't really think it would go into the Developer's discussion because I'm not one!
moved to coder's corner
this sounds like a good idea, and submiting patch is the best way to become a dev
AFAIK this has not been implemented in 1.3
and it won't be implemented in 1.2...
sorry, but we are in very deep code freeze right now and no more feature will make it in 1.2 only bugfixes....
but I'm perfectly fine with merging that type of patches in 1.3 so feel free to code it
this sounds like a good idea, and submiting patch is the best way to become a dev
AFAIK this has not been implemented in 1.3
and it won't be implemented in 1.2...
sorry, but we are in very deep code freeze right now and no more feature will make it in 1.2 only bugfixes....
but I'm perfectly fine with merging that type of patches in 1.3 so feel free to code it
Fight key loggers: write some perl using vim
-
- Inactive Developer
- Posts: 787
- Joined: March 31st, 2006, 6:55 am
Ok. Did it... In what way would you like to have the patch? Till now it is only the basic codework. So since you won't probably want the whole Wesnoth, do you just want the changed files?
I will still implement this into the WML-code of every unit, but a little later. I thought it would be good to show what I did first, so I could get some comments before I go on.
jg
I will still implement this into the WML-code of every unit, but a little later. I thought it would be good to show what I did first, so I could get some comments before I go on.
jg
Post the diff to patches.wesnoth.org.
"If gameplay requires it, they can be made to live on Venus." -- scott
-
- Inactive Developer
- Posts: 787
- Joined: March 31st, 2006, 6:55 am
Patches get reviewed before committing.
Also read this post about submitting patches http://www.wesnoth.org/forum/viewtopic. ... 866#136866
Also read this post about submitting patches http://www.wesnoth.org/forum/viewtopic. ... 866#136866
The units should be updated by a script anyway, so you don't have to give diffs for those. Just describe how they need to be changed.jg wrote:Because I have to ask this anyway, I'll ask it straightaway. Who do you want me to give you the changes for the units? I don't really think you would like me to submit 150+ .diff files for that... Would it be good if I just submit a gz/bz file of all the units that have been modified?
EDIT: Now, why exactly do the unit .cfg's need to be changed? It's redundant, the code should figure out what the unit advances from by itself, and it should be rather easy, too.
-
- Inactive Developer
- Posts: 787
- Joined: March 31st, 2006, 6:55 am
yes, you'd have to figure the advance tree by looking at all available units, not write it in a (unreliable) WML key...
esp since this stuff can change from one campaign to the other, the advance_to and advance_from tag etc....
fyi, yes 150+files in diff is fine by me, I can review that.
but changing the WML key, in that particular case, is a bad idea
esp since this stuff can change from one campaign to the other, the advance_to and advance_from tag etc....
fyi, yes 150+files in diff is fine by me, I can review that.
but changing the WML key, in that particular case, is a bad idea
Fight key loggers: write some perl using vim
-
- Inactive Developer
- Posts: 787
- Joined: March 31st, 2006, 6:55 am
Yes, I'll try and make it look for itsself what the unit advances_from. Sorry that this is taking awfully long, but it takes some time for me to find myself into a new program...
But work is getting along nonetheless. As soon as I get the patch ready I'll try and make it a snv diff, so you can read it...
jg
But work is getting along nonetheless. As soon as I get the patch ready I'll try and make it a snv diff, so you can read it...
jg