Requesting Editor Artwork

[fabi]

The map editor of 1.12 will come with some improvements on different fields.
The price of this progress includes some artwork to be (re)done.

• Tool buttons
  • Missing images
    • Touched
    • Active and Pressed
    • Disabled
    • Disabled and Pressed - *Not* needed
  • Current Images are not of the Wesnoth style
• Brush buttons
  • Not in Wesnoth style but there are new versions in the dev branch
  • Touched
  • Active and Pressed
  • Disabled
  • Disabled and Pressed
• Terrain group buttons -- Touched version
• Editor side bar width changed
  • Some images are still in the wrong dimension
  • Those which fit have been done by myself...

Recently it lost the ugly red frames marking the selected tool and brush.
This was done by replacing the former "press" buttons with "radio" ones.

Radiobox buttons know more states and thus demand more images to be drawn.
We have active, pressed and normal images.
The lacking ones are: touched, active-pressed and disabled.

A set of radio buttons also includes pressed-disabled images.
But their state is only used by the brush buttons, not by the tool ones.

Another issue are the terrain group buttons.
They only lack of the touched images, no disabled states for them.

[LordBob]

I can take care of it.
Just to make sure that we understand your needs, could you:
- confirm the exhaustive list of "tools", "brush", and "terrain group" buttons that need attention
- confirm that by "Wesnoth style" you refer to the gold-circled, dark blue style used for checkboxes and the dialog buttons
- confirm the new dimension for buttons in the side bar (and which images are concerned by this)

Next, I'm not sure what the radiobox button paragraph is about. Which buttons in your above list, if any, are the radiobox type ? Or is radiobox a different type of generic button for which you need images as well ?

[fabi]

I can take care of it.

Cool.

Just to make sure that we understand your needs, could you:
- confirm the exhaustive list of "tools", "brush", and "terrain group" buttons that need attention

http://sourceforge.net/p/wesnoth/code/c ... ns/editor/
Every one of them needs attention.
I mean, every set there needs completion.

- confirm that by "Wesnoth style" you refer to the gold-circled, dark blue style used for checkboxes and the dialog buttons

Yes, I suggest to make every button in the editor to match that style.
It is already done for the brush buttons in the development version.

- confirm the new dimension for buttons in the side bar (and which images are concerned by this)

The current tool buttons are 24x24.
The terrain group buttons are just one pixel bigger, thus I suggest to take the icons from the old tool buttons and reuse the frame from the terrain group ones.
This would make them 25x25.

Next, I'm not sure what the radiobox button paragraph is about.

Which buttons in your above list, if any, are the radiobox type ?

All brush (named brush-*), tool (non Wesnoth style grey) and terrain group (named group_*) buttons are of type radiobox.
It's just that some of them can't be disabled (the terrain group buttons and the paint, fill, starting_position and select tools) or can't be disabled and pressed (The tool buttons and every other tool).

Only the utility buttons (non Wesnoth style grey) are of different types.
These are:

• flip_map which is a checkbox (needs no disabled versions)
• toggle_grid is a checkbox (needs no disabled versions)
• undo is a press button (needs disabled)
• redo is a press button (needs disabled)
• zoom_default is a checkbox (needs no disabled versions)
• zoom_in is a turbo button (needs disabled)
• zoom_out is a turbo button (needs disabled)

Checkboxes depend on the same set of images as radioboxes.
A press or turbo button needs normal, active, disabled, active-pressed.

Or is radiobox a different type of generic button for which you need images as well ?

Radiobox is a generic type that defaults to the images you did in the other thread.
The editor buttons look differently but behave the same.
You can only select one brush, one tool and one terrain group.

I think the situation is easy for the brushes:
The hex grid might be better golden not black.
I don't know about the grey inner either, maybe the green of flip and undo works.
Size stays the same.
Every set of the brushes needs an extra touched, disabled and disabled-pressed image.

The situation for the group buttons is very simpel:
Every group needs an extra touched button.

[LordBob]

Me again: I went ahead and did a blank base for the tools buttons. I had not seen your answer, so they're based on the size of the existing ones (24*24 pixels), but resizing them will be easy. So if I got it right, all brushes, tools, utilities and terrain group buttons should become 25*25 pixels, shouldn't they ?

From left to right, top-down:
o button
o button-pressed
o button-disabled
o button-active
o button-active-pressed
o button-touched

For the "radiobox" types, considering how there will normally be one button in the "pressed" state tightly packed with many similar others, I'm thinking it might be preferable to introduce a contrasting colour and/or brighter background for this particular state, lest it becomes difficult to spot which button is currently pressed.

[vultraz]

I've been busy the past few days, so I wasn't able to get down to working on the toolkit buttons like I said I was going to. However, LordBob seems to be doing everything better than I could, so I think I'll let him keep at it, unless there's a specific set you'd like me to work on.

[fabi]

Me again: I went ahead and did a blank base for the tools buttons. I had not seen your answer, so they're based on the size of the existing ones (24*24 pixels), but resizing them will be easy. So if I got it right, all brushes, tools, utilities and terrain group buttons should become 25*25 pixels, shouldn't they ?

Yes for all but the brushes.
They can stay at the current size. But I wouldn't mind to have them changed. It is just that I fear the grid for the bigger ones won't fit in a smaller button.

Considering how there will normally be one button in the "pressed" state tightly packed with many similar others, I'm thinking it might be preferable to introduce a contrasting colour and/or brighter background, or a different border for this particular state, lest it becomes difficult to spot which button is currently pressed.

The tools and utilities are already placed on a bright grey background.

edit: But the pressed brush could feature a golden hex grid while the normal ones stay black?

[vultraz]

Me again: I went ahead and did a blank base for the tools buttons. I had not seen your answer, so they're based on the size of the existing ones (24*24 pixels), but resizing them will be easy. So if I got it right, all brushes, tools, utilities and terrain group buttons should become 25*25 pixels, shouldn't they ?

Yes for all but the brushes.
They can stay at the current size. But I wouldn't mind to have them changed. It is just that I fear the grid for the bigger ones won't fit in a smaller button.

Currently, the brush buttons, at 30x30 pixels, were barely able to fit the largest brush icon; I had to chop off the top and bottom. Given that, I'm not sure how they could be made to work with 24x24.

EDIT: RE the group buttons, currently they're 25x25. If you want, I can use LordBob's images that he just posted to quickly generate full image sets for all the group buttons, but they would be 24x24. Is the one pixel x-y decrease ok?

[fabi]

EDIT: RE the group buttons, currently they're 25x25. If you want, I can use LordBob's images that he just posted to quickly generate full image sets for all the group buttons, but they would be 24x24. Is the one pixel x-y decrease ok?

Yes it is for me. Can we coordinate this on irc?

LordBob, do you have an irc client running?

[LordBob]

EDIT: RE the group buttons, currently they're 25x25. If you want, I can use LordBob's images that he just posted to quickly generate full image sets for all the group buttons, but they would be 24x24. Is the one pixel x-y decrease ok?

Or you can wait a couple minutes until I'll provide a 25*25 blank set :p
But yes, I would appreciate if you took care of assembling the existing tile group icons (or newer, better ones) with the blank set.

As for the "pressed" state, it's my mistake; by background I was refering to the blue core of the button (which would become brighter when pressed) and not its surroundings. But changing the colour of the icon works just as well; maybe I'll do both, stay tuned.


@ Fabi: I think I still have an IRC client installed. I'll jump to wesnoth-dev in a minute

[LordBob]

And done. I've attached the full blank button set in 25*25. Compared to the above, I've added a "diasbled-pressed" image just in case, and also a new state "highlighted" and "highlighted-pressed", which I think could serve to put in evidence the selected button when working with a "radiobox" type set, or maybe some future needs we're not fully aware of yet.

Edit: and there's the 30*30 set
Edit (2): I've also attached the layer source file for each set. Within each file, you'll find a separate group of layers for each state of the button.
Edit (3): as discussed, the brush tip icons for 30*30 buttons

[LordBob]

More buttons! This time a set of frames that should help highlight the terrain tile(s) selected as background and/or foreground when using the brush.

I've included 3 bases that should be displayed belwo the terrain hex (though on second thought it would be best not to use any for the "normal" state of the button).
They're meant to be combined with a set of 9 frames that are overlayed on top of the hex depending on the different states of the button.

As before, I'm also attaching the PSD file for future needs.

[LordBob]

Aaaaand still more buttons! Weeheeeee, fun !

The same kind as before, only larger for units

[LordBob]

Oh no! More buttons!

An alternate set of frames for the terrain button. Compared to earlier frames, these are thinner and more discreet. The base and working principle are unchanged.

[LordBob]

Buttons everywhere. Do you hear their voices, too?

(sorry, not much to say. More alternate sets and revisions. The top row is an alternate alternate design with different shapes for the primary/secondary selectors, should we want to develop a colourblind-user-friendly editor )

[LordBob]

Next a set of tools icons, meant to be overlayed on top of the new 30 pix button base. The icons are basically unchanged, I only stylized them to match the new brush tip buttons. For each tool that was as far as I knew a radio button type, I've included a "pressed" variant.