Propose (minor) change to dawn/dusk overlay colors

[Coffee]

Hello

After playing around with some liminal units for a bit I noticed that it would be nice to have a more consistent dawn/dusk color tint for the schedule to reinforce graphically when to attack/defend. I did a bit of research into what dawn/dusk should look like in real life and why they should look that way and I think a small change would be also more representative of what occurs in nature.

This would only be a minor change and I suspect some people would not even notice it.

Long reasoning:

Spoiler:

Normally dawn is the time when the first rays of sun appear and dusk is the last time you can see anything with natural light. However, in the schedule dawn probably covers the whole of dawn to sunrise and similarly for sunset to dusk.

Both occur in opposite directions so the only difference is that after a night a lot of the air has cooled down and is not in the way of the light rays to an observer (because it has sunk or is still).

This means that sunsets are more spectacular in the sky but leave slightly less red light to hit the ground, which is what we are interested here.

Anyway here is a video of both sunset and sunrise that shows it all clearly.

Not much green light comes through, leaving only mostly red and a little blue (combination is pink/purple)

The outcome of it all (sadly hard to see, but more noticeable in-game - left is new coloring)

Spoiler:

To see this you could change the file, data/core/macros/schedules.cfg to have:

Code: Select all

#define DAWN
    [time]
        id=dawn
        name= _ "Dawn"
        image=misc/schedule-dawn.png
        red=-10
        green=-25
        blue=-10
        sound=ambient/morning.ogg
    [/time]
#enddef
...
#define DUSK
    [time]
        id=dusk
        name= _ "Dusk"
        image=misc/schedule-dusk.png
        red=-12
        green=-25
        blue=-8
        sound=ambient/night.ogg
    [/time]
#enddef

These amounts of red/blue/green have the added advantage of being exactly half the difference between day and night totals.