My Terrain (Mine!)

Contribute art for mainline Wesnoth.

Moderators: Forum Moderators, Developers

Forum rules
Before posting critique in this forum, you must read the following thread:

Re: My Terrain (Mine!)

Postby zookeeper » October 14th, 2016, 7:38 am

Since the water animations already force redraws, having additional animations affecting the same hexes shouldn't really affect performance, as long as the frame intervals are the same. Basically, the time it takes to redraw a hex is the same regardless of whether it happens because of one animation or several. The only thing that would hurt performance would be if the additional animations caused redraws to happen more often, but that doesn't need to be the case here.

Currently, the water animation frames are 100ms long and have random_start=no, so if the water-on-walls animations do the same, they'll play nicely in sync and there shouldn't be any problem with that.
User avatar
zookeeper
WML Wizard
 
Posts: 9561
Joined: September 11th, 2004, 10:40 pm
Location: Finland

Re: My Terrain (Mine!)

Postby doofus-01 » October 15th, 2016, 7:17 pm

OK, so maybe I'll get them animated after all. But not in time for 1.13.6.

Speaking of which, if the deadline for that is still this weekend, I should mention that the stone walls have been revised to be cleaned up a bit, and have rough cave wall transitions. There is still a little more to do, but I think it could be used without looking broken. Wall decoration overlays might need to be adjusted a bit though, but I think that's just a UMC thing.
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby zookeeper » October 15th, 2016, 8:29 pm

The release is now tentatively planned for end of the month.
User avatar
zookeeper
WML Wizard
 
Posts: 9561
Joined: September 11th, 2004, 10:40 pm
Location: Finland

Re: My Terrain (Mine!)

Postby doofus-01 » October 16th, 2016, 11:00 pm

Oh, well, I guess that's good. In a way.

I think the walls are close enough to done now, and I've got a door and gate impassable terrain. The north/south facing doors are a bit problematic, since I don't want to put them on the edge of the hex, but that's where they look best. This is the current layout in the PR:
Spoiler:
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby beetlenaut » October 16th, 2016, 11:33 pm

Those are cool. But I think you need two versions of the north/south door. One for cave tunnels, where the door can't be any wider, and a wider one for everywhere else.
Campaigns: Dead Water
The Founding of Borstep
Secrets of the Ancients
User avatar
beetlenaut
Developer
 
Posts: 2043
Joined: December 8th, 2007, 3:21 am
Location: Oaxaca, Mexico

Re: My Terrain (Mine!)

Postby Eagle_11 » October 17th, 2016, 12:24 pm

Try fiting the door facing S on the line between 2 hexes, instead in the middle of hex. The stone wall to cave transition looks nice.
The dungeon cell gate needs angle adjustment so they line up in one continous line when 2x 2-tile wide are adjacent.
User avatar
Eagle_11
Forum Regular
 
Posts: 553
Joined: November 20th, 2013, 12:20 pm

Re: My Terrain (Mine!)

Postby ForestDragon » October 17th, 2016, 12:37 pm

hi, could you make a transition for cases like this:
Code: Select all
    w             w
            d

w means wall, d means door
sometimes helping inferno8 with his add-ons: Era of Magic, and an extremely visually beautiful campaign: To Lands Unknown
Creator of Tale of Alan (abandoned) and The Golden Age (my era, also rather abandoned),XP Bank
"Join the code side, we have COOKIES!!!" :)
User avatar
ForestDragon
 
Posts: 1135
Joined: March 6th, 2014, 1:32 pm

Re: My Terrain (Mine!)

Postby doofus-01 » October 22nd, 2016, 7:41 pm

doors_20161022.jpg
This is the current status. The shading isn't done, especially on the wooden "pillars" that flank the doors. And I haven't started the wooden diagonal versions.
EDIT: I should mention that I'm not really happy with the n/s facing doors, and suspect the concept isn't really compatible with the current hex system. Placing the door right on the horizontal borders is no good because it makes it unclear which hex is impassible. I'm leaning towards just dropping them.
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby zookeeper » October 22nd, 2016, 9:05 pm

The N/S doors won't work visually unless there's walls to the left and right, but we can include them nevertheless. You also couldn't chain them the way you seem to allow for diagonal walls to be chained (without an extra set of special connections between them), but that's fine too. That said, I'd think no one would lose sleep if we only had the diagonal versions.

Also, if we're going to make these a core terrain, then we need to account for what gates are for: opening them. One can of course just make them disappear (by changing the terrain) when opened, but especially with chained diagonal gates that would look weird. So, basically, each one should have also an "open" version. The only reasonable way to do that currently seems to be to just have two versions of each terrain, open and closed, with only the closed one being impassable and the open one acting as an embellishment only.
User avatar
zookeeper
WML Wizard
 
Posts: 9561
Joined: September 11th, 2004, 10:40 pm
Location: Finland

Re: My Terrain (Mine!)

Postby doofus-01 » October 23rd, 2016, 5:15 am

zookeeper wrote:That said, I'd think no one would lose sleep if we only had the diagonal versions.
Thank God for that. It makes things much simpler, and the open/closed gate thing should not be much of an issue. Let's see what the next 24 hrs brings.
Attachments
doors2_20161022.jpg
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby LordBob » October 23rd, 2016, 8:01 am

For what it's worth, I haven't had a look at our underground terrains in ages but this is really starting to look like a nice dungeon setting I'd d love to run an adventure in ^_^
Want to see more of my art ? Visit my blog !
User avatar
LordBob
Portrait Director
 
Posts: 1194
Joined: December 8th, 2008, 8:18 pm
Location: Bordeaux, France

Re: My Terrain (Mine!)

Postby doofus-01 » October 24th, 2016, 1:42 am

Thanks, LordBob. (Just to be clear, I didn't draw the stone walls, I just 'repackaged' the existing ones, and drew some transitions.)

Not that some touch-ups wouldn't be warranted at some point, but I think this is ready to merge, I'll comment in the PR when I'm done here.
1. I've given up on the idea of ~BLIT()'ing the pillars and just baked them in to a "long" version.
2. There is no "long version" for the N/S facing, it is just the single image, and it should only show up in the straight, vertical passages of the stone walls (Xo*).
3. There are open-door versions, so 4 terrains in this PR. (Hopefully there will be more, but not for now.)
4. The default image is SE facing with pillar, as can be seen in a couple of glitchy instances in the screen-shot. Maybe a different image should be default, but I think the glitches only occur where it makes no sense to put a portal anyway. Unless I missed something.
screen-shot:
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby Eagle_11 » October 25th, 2016, 10:02 am

wooden door open nw-se doesnt look really connected to the wall.
User avatar
Eagle_11
Forum Regular
 
Posts: 553
Joined: November 20th, 2013, 12:20 pm

Re: My Terrain (Mine!)

Postby doofus-01 » October 30th, 2016, 1:55 am

The previous pull request got merged, but there are obviously some transitions that were missing. I've just put up https://github.com/wesnoth/wesnoth/pull/848 for some of those missing images. First is a default wall-castle transition. The images aren't finished (they are too sharp right now), but here is a screen-shot that shows the design:
Spoiler:
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3491
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: My Terrain (Mine!)

Postby zookeeper » October 30th, 2016, 1:59 pm

I have a WIP of an alternate solution to the castles<->walls problems, which I think would work even with the stone walls (not quite as well as with cave walls, but adequately anyway). There's some layering glitches to work out, especially with stone walls, but I think this would be a better solution than new sets of corner tiles if it works out.
Attachments
castletocavewallprogress3.jpg
User avatar
zookeeper
WML Wizard
 
Posts: 9561
Joined: September 11th, 2004, 10:40 pm
Location: Finland

PreviousNext

Return to Art Contributions

Who is online

Users browsing this forum: No registered users and 4 guests