josteph's patches

General feedback and discussion of the game.

Moderators: Forum Moderators, Developers

Post Reply
User avatar
josteph
Developer
Posts: 677
Joined: August 19th, 2017, 6:58 pm

josteph's patches

Post by josteph » May 13th, 2019, 6:15 pm

I'd like to share the patches I use.

Several of these changes are subjective. They don't have to be your cup of tea. No less than five of them were already rejected from master. Therefore, I'm explicitly not proposing any of these to be mainlined. However, I use them, and I'm posting them here in case someone else wants to use them too.

1. In the help pages of units that have weapon specials or abilities, I shorten the "special notes" sentences to a word each:
2019-05-13-165442_1920x1080_scrot.png
2019-05-13-165442_1920x1080_scrot.png (58.7 KiB) Viewed 725 times
(I've made a less intrusive change for 1.15)

2. I change the damage and strikes display from 5x4 to 5–4 which I'm used to from 1.12.
2019-05-13-165516_1920x1080_scrot.png
2019-05-13-165516_1920x1080_scrot.png (28.09 KiB) Viewed 725 times
(see #9 for the red/black icons)

3. I reverse the time-of-day graphics so the sun rises on the left rather than the right, both in-game and in the help. Unlike the addon "Reverse Time Graphics", which does this for the mainline timeofday schedules only, my patch will work even for UMC campaigns that use custom time-of-day graphics.
2019-05-13-165630_1920x1080_scrot.png
2019-05-13-165630_1920x1080_scrot.png (91.53 KiB) Viewed 725 times
4. Where resistances/vulnerabilities are shown I group them blade,impact,pierce,(space),arcane,cold,fire rather than alphabetically.
2019-05-13-165714_1920x1080_scrot.png
2019-05-13-165714_1920x1080_scrot.png (28.12 KiB) Viewed 725 times
5. One of the tooltips of the sidebar shows how many damage points a unit's attack would inflict to each visible enemy unit. I change that tooltip from sorted by damage:
34819727-7a451530-f6b6-11e7-8b67-5e67d3fd6fc8.png
34819727-7a451530-f6b6-11e7-8b67-5e67d3fd6fc8.png (172.23 KiB) Viewed 725 times
to sorted by unit type:
2019-05-13-165922_1920x1080_scrot.png
2019-05-13-165922_1920x1080_scrot.png (103.24 KiB) Viewed 725 times
what's more, different shades of red and green are used:
2019-05-13-180656_1920x1080_scrot.png
2019-05-13-180656_1920x1080_scrot.png (140.36 KiB) Viewed 725 times
(I proposed this in #2341)

6. In textboxes, Ctrl+A does "Go to start of line" rather than "Select all".
(Revert of a change in master)

7. I make Ctrl+Mousewheel scroll horizontally, in addition to Alt+Mousewheel which does so by default.

8. Savefiles are named with underscores rather than spaces: HttT-The_Elves_Besieged_replay.gz rather than HttT-The Elves Besieged replay.gz
(Revert of a change in master)

9. Where the damage type and range of an attack are shown (for example, "melee–blade"), I show images for "melee" and for "blade".
2019-05-13-173650_1920x1080_scrot.png
2019-05-13-173650_1920x1080_scrot.png (83.81 KiB) Viewed 725 times
2019-05-13-173655_1920x1080_scrot.png
2019-05-13-173655_1920x1080_scrot.png (51.48 KiB) Viewed 725 times
2019-05-13-170943_1920x1049_scrot.png
2019-05-13-170943_1920x1049_scrot.png (50.52 KiB) Viewed 725 times
(backported from master: https://github.com/wesnoth/wesnoth/projects/4)

10. I remove the real-world clock from the top bar.

11. I use a customized version of the asymmetric theme:
Screenshot_2019-04-01_20-47-55.png
The screenshot shows the damage calculations histogram, as in the asymmetric theme, and the two different time-of-day images, which are enabled by C++ changes I made. I have pushed them to master and backported most of them to 1.14. (The remaining ones are potentially ineligible for backport.)

12. I change the "resistances" tooltip in the sidebar to show the ratio corresponding to the resistance/vulnerability percentage. (previous thread)
2019-03-25-144052_175x252_scrot.png
2019-03-25-144052_175x252_scrot.png (51.14 KiB) Viewed 725 times
2019-03-25-144825_173x282_scrot.png
2019-03-25-144825_173x282_scrot.png (64.05 KiB) Viewed 725 times
13. I change XP display in the UI from "32/42XP" to "10↓ 32↑": (previous thread)
2019-05-13-174851_1152x864_scrot.png
(the "32/42XP" format is available in a tooltip)

User avatar
EarthCake
Posts: 350
Joined: March 29th, 2019, 1:57 pm
Location: Dragonstone

Re: josteph's patches

Post by EarthCake » May 13th, 2019, 6:32 pm

This all is totally cool!

I would like to see all this in the mainline.

User avatar
SatHyre
Posts: 58
Joined: March 30th, 2008, 7:06 am
Location: dago

Re: josteph's patches

Post by SatHyre » May 14th, 2019, 7:44 am

hello,
10 : dont remove the clock please.
13 : a very good idea. you see directly how many XP you need to level.

User avatar
shadowm
Site Administrator
Posts: 6545
Joined: November 14th, 2006, 5:54 pm
Location: Chile
Contact:

Re: josteph's patches

Post by shadowm » May 14th, 2019, 2:44 pm

SatHyre wrote:
May 14th, 2019, 7:44 am
hello,
10 : dont remove the clock please.
13 : a very good idea. you see directly how many XP you need to level.
josteph wrote:
May 13th, 2019, 6:15 pm
Several of these changes are subjective. They don't have to be your cup of tea. No less than five of them were already rejected from master. Therefore, I'm explicitly not proposing any of these to be mainlined. However, I use them, and I'm posting them here in case someone else wants to use them too.
Author of the unofficial UtBS sequels Invasion from the Unknown and After the Storm.

Post Reply