Sorting the "damage versus" tooltip by unit

General feedback and discussion of the game.

Moderator: Forum Moderators

Post Reply
User avatar
josteph
Inactive Developer
Posts: 741
Joined: August 19th, 2017, 6:58 pm

Sorting the "damage versus" tooltip by unit

Post by josteph »

In the sidebar, the attack type and range has a tooltip that shows the damage versus each enemy unit, taking their resistances into account.

I generally want to look up a specific enemy unit in the tooltip, so I use a patch that adds the same information, sorted alphabetically rather than by amount of damage:
damage-tooltip.png
damage-tooltip.png (311.01 KiB) Viewed 1876 times
Enjoy.
Attachments
damage-tooltip.diff
(2.25 KiB) Downloaded 242 times
User avatar
Pentarctagon
Project Manager
Posts: 5564
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Sorting the "damage versus" tooltip by unit

Post by Pentarctagon »

Was there some reason to post a patch here, rather than making a pull request for it? Sorting by unit type rather than damage sounds more useful to me, honestly.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code
User avatar
josteph
Inactive Developer
Posts: 741
Joined: August 19th, 2017, 6:58 pm

Re: Sorting the "damage versus" tooltip by unit

Post by josteph »

No good reason, I guess. Submitted https://github.com/wesnoth/wesnoth/pull/2341
Post Reply