Sorting the "damage versus" tooltip by unit

General feedback and discussion of the game.

Moderators: Forum Moderators, Developers

Post Reply
josteph
Posts: 26
Joined: August 19th, 2017, 6:58 pm

Sorting the "damage versus" tooltip by unit

Post by josteph » December 24th, 2017, 1:53 am

In the sidebar, the attack type and range has a tooltip that shows the damage versus each enemy unit, taking their resistances into account.

I generally want to look up a specific enemy unit in the tooltip, so I use a patch that adds the same information, sorted alphabetically rather than by amount of damage:
damage-tooltip.png
damage-tooltip.png (311.01 KiB) Viewed 736 times
Enjoy.
Attachments
damage-tooltip.diff
(2.25 KiB) Downloaded 29 times

User avatar
Pentarctagon
Forum Administrator
Posts: 3428
Joined: March 22nd, 2009, 10:50 pm
Location: Earth (occasionally)

Re: Sorting the "damage versus" tooltip by unit

Post by Pentarctagon » December 27th, 2017, 2:54 am

Was there some reason to post a patch here, rather than making a pull request for it? Sorting by unit type rather than damage sounds more useful to me, honestly.
99 little bugs in the code, 99 little bugs
take one down, patch it around
-2,147,483,648 little bugs in the code

josteph
Posts: 26
Joined: August 19th, 2017, 6:58 pm

Re: Sorting the "damage versus" tooltip by unit

Post by josteph » December 30th, 2017, 7:25 am

No good reason, I guess. Submitted https://github.com/wesnoth/wesnoth/pull/2341

Post Reply