Wesnoth 1.13.8 (1.14 Beta 1)

Get help with compiling or installing the game, and discuss announcements of new official releases.

Moderators: Forum Moderators, Developers

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby gfgtdf » May 21st, 2017, 2:27 am

seems like you are trying to use [unstore_unit] with an invalid variable, (the wml data that [unstore_unit]variable= points to is not a unit wml)


EDIT: oh and the erromessae also says the [unstore_unit] tag was found somehere in a [while] tag.
Scenario with Robots SP scenario (1.11/1.12), allows you to build your units with components, PYR No preperation turn 1.12 mp-mod that allows you to select your units immideately after the game begins.
gfgtdf
Developer
 
Posts: 898
Joined: February 10th, 2013, 2:25 pm

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby doofus-01 » May 21st, 2017, 3:02 am

Right, but it's worked fine for almost two years, so it's not a simple WML blunder. (May be a Lua-generated WML blunder?)
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3525
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Celtic_Minstrel » May 21st, 2017, 3:34 am

I'm not sure why this error is appearing now when it didn't before, but it should be easy to fix in the [unstore_unit] tag implementation by simply checking if the type is empty and doing nothing in that case.
Author of The Black Cross of Aleron campaign and Default++ era.
Maintainer of Steelhive.
User avatar
Celtic_Minstrel
Developer
 
Posts: 753
Joined: August 3rd, 2012, 11:26 pm

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby doofus-01 » May 21st, 2017, 4:59 am

Celtic_Minstrel wrote:I'm not sure why this error is appearing now when it didn't before, but it should be easy to fix in the [unstore_unit] tag implementation by simply checking if the type is empty and doing nothing in that case.
The unit was unstored just fine back in mid-March. But if that makes it easier to debug, I suppose that is progress.
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3525
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Ravana » May 21st, 2017, 8:44 am

Notice though, that the stack traceback line numbers can be useful. First one especially.

I read it that as: in some event, in [while] (possibly FOREACH then), [unstore_unit] tries to unstore empty variable.


1.12 logged error message for this, but didnt show in chat. Few weeks ago I debugged such error by adding logging near those Lua file lines.
User avatar
Ravana
Moderator
 
Posts: 1438
Joined: January 29th, 2012, 12:49 am
Location: Estonia

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby vultraz » May 21st, 2017, 12:49 pm

I see this as WML becoming stricter. That's good.
Creator of Shadows of Deception (for 1.12) and co-creator of the Era of Chaos (for 1.12/1.13).
SurvivalXtreme rocks!!!
What happens when you get scared half to death...twice?
User avatar
vultraz
Community Manager
 
Posts: 816
Joined: February 7th, 2011, 12:51 pm
Location: Dodging Daleks

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby tamanegi » May 21st, 2017, 4:50 pm

Hi, I met a crash on 1.13.7-1.13.8.
ASAIK crash happens when [story] contains [part] but any [part] won't be displayed due to conditional.
Following is a minimal example (_main.cfg of a campaign). This ends in segmentation fault on my Linux (debian testing). It does not crash in 1.12.

Code: Select all
[campaign]
  id = segfault
  rank = 999
  name = "segfault"
  define = SEGFAULT
  description = "story/part crash test"
  first_scenario = Segfault
[/campaign]

#ifdef SEGFAULT
  [scenario]
    id = Segfault

    [story]
      # comment out everything inside story prevents crash
      [if]
        [variable]
          name = non_exsistent_virual_variable
          equals = true
        [/variable]
        [then]
          [part]
            story = "seg fault"
          [/part]
        [/then]
        ## if uncomment following lines, crash does not happen
        #[else]
        #  [part]
        #    story = "safe"
        #  [/part]
        #[/else]
      [/if]
      ## activating following lines also prevent crash
      #[part]
      #  story = _"prevent crash"
      #[/part]
    [/story]
  [/scenario]
#endif /* SEGFAULT */


In addition to above one, when I use "passable" or "overwrite" in [unit], engine puts warning like "warning unit: Unknown attribute 'passable' discarded.", though it works as expected. I guess "passable" and "overwrite" should be listed in static std::string internalized_attrs[] (anonymous namespace in units/unit.cpp)?
Discord: @tamanegi
It is true that we cannot be free from bugs, but at least let our bugs not always the same...
A Group in a War: my first campaign, An Independence War: and the sequel
User avatar
tamanegi
 
Posts: 98
Joined: August 25th, 2014, 11:38 am
Location: Japan

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Inky » May 21st, 2017, 6:40 pm

Thanks to all the devs for another awesome release (especially to whoever added the resistances and movement cost tooltips to the recruit/recall list, that's so helpful!!)

Add-on manager:
- What happened to the option to sort add-ons by last updated? That's the sorting I always used and it doesn't seem to be there anymore.
- For me there's a horizontal scrollbar and I have to scroll every time to see the Exit button, which is pretty inconvenient. (My wesnoth resolution is 1280x720.)
- When I updated all add-ons, the Update All button wasn't greyed out and the server still showed I had the older versions. It was only after restarting Wesnoth that the update all button got greyed out.

Other:
- Viewing the Credits just gives me a blank screen.
- I really don't like the new damage calculations window. Maybe it's due to a similar font issue that nuorc had, but the numbers in the charts are difficult to read, compared to the very clear numbers in the 1.12.6 dialogue. I also preferred the way the colored bars looked in 1.12.6.
Images:
Commented playthroughs with screenshots:
Let's Play Dead Water, Let's Play Invasion from the Unknown and Let's Play After the Storm (in progress)
User avatar
Inky
Moderator
 
Posts: 432
Joined: September 22nd, 2014, 1:02 am
Location: USA

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Celtic_Minstrel » May 21st, 2017, 7:19 pm

Inky wrote:What happened to the option to sort add-ons by last updated? That's the sorting I always used and it doesn't seem to be there anymore.
Was it already gone in 1.13.7? I know a few of the columns disappear on smaller resolutions, but other than the buttons column I'm pretty sure that's only really small resolutions (like 800x600).

Inky wrote:For me there's a horizontal scrollbar and I have to scroll every time to see the Exit button, which is pretty inconvenient. (My wesnoth resolution is 1280x720.)
Ugh, I'll have to look into that again. It's hard to avoid entirely since it depends to some extent on the addons listed...

Inky wrote:Viewing the Credits just gives me a blank screen.
Known, jyrkive's fix should be in the next release.

Inky wrote:I also preferred the way the colored bars looked in 1.12.6.
I too prefer the shaded bars. This is harder to do in the new framework, though, so I'm not sure if it'll happen.
Author of The Black Cross of Aleron campaign and Default++ era.
Maintainer of Steelhive.
User avatar
Celtic_Minstrel
Developer
 
Posts: 753
Joined: August 3rd, 2012, 11:26 pm

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Inky » May 21st, 2017, 10:17 pm

Re: Add-on manager sorting options- There used to be an Options button where you could select the types of addons, whether or not they were installed, and sorting options (downloads, last update etc.) It seems the first two have been converted to dropdown menus but the sorting options aren't there anymore?

And I've noticed that when I click on a column, sometimes it takes 2 clicks before any sorting takes place.

Preferences: When I change an option in one category and then view another category before closing the window (example: toggle the grid in Display, then view Hotkeys), the change doesn't happen.

Tooltip font issue mentioned by nuorc: I have the same issue and it's confusing especially for trait tooltips (like +1 damage) since they aren't color coded. The tooltips in the recruit/recall windows are perfectly clear though, I don't know if there is a way to use these tooltips for the unit info panel also?

Opinion on the Status table: The Human/Computer labels cluttering the team names are pretty useless most of the time - I think they can be removed from the regular status table since they are already viewable in the Scenario Settings tab.
Commented playthroughs with screenshots:
Let's Play Dead Water, Let's Play Invasion from the Unknown and Let's Play After the Storm (in progress)
User avatar
Inky
Moderator
 
Posts: 432
Joined: September 22nd, 2014, 1:02 am
Location: USA

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby doofus-01 » May 22nd, 2017, 12:34 am

Celtic_Minstrel wrote:I'm not sure why this error is appearing now when it didn't before, but it should be easy to fix in the [unstore_unit] tag implementation by simply checking if the type is empty and doing nothing in that case.
Turns out most of my problems were from the decision to start removing empty tags. The specific problem batted around here was from this condition
Code: Select all
            [while]
                [have_unit]
                    search_recall_list=yes
                    [and]
                        [filter_wml] 
                            [variables]
                                on_call=yes
                            [/variables]
                        [/filter_wml]
                    [/and]
                    [and]
                        x,y=recall,recall
                    [/and]
               [/have_unit]
...
changing how it evaluates in BfW 1.13.8 compared to what it used to be, as it is now "true" longer than it should be. Maybe it's related to the [variables] tag, I don't have any more time to burn on this to find out though.
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3525
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Celtic_Minstrel » May 22nd, 2017, 1:01 am

What do you mean by saying it's true longer than it should be? That sounds like a pretty serious bug.
Author of The Black Cross of Aleron campaign and Default++ era.
Maintainer of Steelhive.
User avatar
Celtic_Minstrel
Developer
 
Posts: 753
Joined: August 3rd, 2012, 11:26 pm

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby doofus-01 » May 22nd, 2017, 2:46 am

This code used to work:
Spoiler:

But now the [while] loop keeps going beyond when the last unit is unstored, so there is that lua error (then the [kill] tag kills everyone when the id filter uses a non-existing variable, which doesn't really seem like the greatest behaviour, but that's a discussion for another day).
I've rewritten it in a more sensible way that works. I don't know if it's Wesnoth or the add-on that are to blame for this, a simple test with mainline (HttT first scenario) works just fine:
put in start event:
So, I guess it must have something to do with [filter_wml] or [variables], if it is an error with Wesnoth.
Bad Moon Rising(BfW 1.12 supported, but new work in BfW 1.13 only) | Trinity(BfW 1.12 only) | Archaic Era(BfW 1.12 & 1.13) | Tales of the Setting Sun(On Hold/Abandoned)
GitHub link for these projects
User avatar
doofus-01
Art Contributor
 
Posts: 3525
Joined: January 6th, 2008, 9:27 pm
Location: USA ...

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby Samonella » May 22nd, 2017, 4:46 am

1.13.8 looks great! Thanks to the devs for your work!

I notice that unit's terrain defenses and movement costs (in the help encyclopedia) don't display correctly from the map editor; they all list all terrains as 0% defense and impassible. It works fine in other places (in game and from the main menu) though. Not sure if this bug was in earlier 1.13 versions.
The last few months have been nothing but one big, painful reminder that TIMTLTW.

Creator of Armory Mod, The Rising Underworld, and Vengeance of a Drake: an RPG
Samonella
 
Posts: 270
Joined: January 8th, 2016, 5:41 pm
Location: USA

Re: Wesnoth 1.13.8 (1.14 Beta 1)

Postby vultraz » May 22nd, 2017, 10:27 am

Inky wrote:Re: Add-on manager sorting options- There used to be an Options button where you could select the types of addons, whether or not they were installed, and sorting options (downloads, last update etc.) It seems the first two have been converted to dropdown menus but the sorting options aren't there anymore?


Those options were for default sorting order when opening the manager. We decided those weren't really worth preserving.
Creator of Shadows of Deception (for 1.12) and co-creator of the Era of Chaos (for 1.12/1.13).
SurvivalXtreme rocks!!!
What happens when you get scared half to death...twice?
User avatar
vultraz
Community Manager
 
Posts: 816
Joined: February 7th, 2011, 12:51 pm
Location: Dodging Daleks

PreviousNext

Return to Release Announcements, Compiling & Installation

Who is online

Users browsing this forum: No registered users and 2 guests